Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improvement](test) add sync for test_agg_keys_schema_change_datev2 #13643

Merged
merged 4 commits into from
Oct 25, 2022

Conversation

morningman
Copy link
Contributor

@morningman morningman commented Oct 25, 2022

Proposed changes

Issue Number: close #xxx

Problem summary

  1. add "sync" to avoid some potential meta sync problem when running regression test on multi-node cluster
  2. Use /tmp dir as dest dir of outfile test, to avoid "No such file or directory" error.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

1
add more sync

Revert "1"

This reverts commit b1284ba.
@morningman morningman marked this pull request as draft October 25, 2022 07:27
@morningman morningman marked this pull request as ready for review October 25, 2022 07:39
Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 6f18726 into apache:master Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants