Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix](concat) be crash caused by function concat(ifnull) #13693

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

jacktengg
Copy link
Contributor

Proposed changes

Issue Number: close #13692

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.35 seconds
load time: 566 seconds
storage size: 17154655338 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221026193905_clickbench_pr_34310.html

@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.61 seconds
load time: 564 seconds
storage size: 17154644858 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221027113047_clickbench_pr_34531.html

@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.8 seconds
load time: 625 seconds
storage size: 17154875751 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221027063937_clickbench_pr_34614.html

Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Oct 27, 2022
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 859ffa6 into apache:master Oct 28, 2022
@yiguolei yiguolei mentioned this pull request Nov 1, 2022
liaoxin01 pushed a commit to liaoxin01/doris that referenced this pull request Nov 12, 2022
…unction concat(ifnull) (apache#13693)"

commit 859ffa6
Author: TengJianPing <18241664+jacktengg@users.noreply.github.com>
Date:   Fri Oct 28 08:42:51 2022 +0800

    [bugfix](concat) be crash caused by function concat(ifnull) (apache#13693)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/sql/function Issues or PRs related to the SQL functions area/vectorization dev/merged-1.1.4 kind/test reviewed usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] be crash caused by concat(ifnull)
4 participants