[improvement](function) add timezone cache for convert_tz #14616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/sql/function
|
TeamCity pipeline, clickbench performance test result: |
mrhhsg
force-pushed
the
cache_time_zone
branch
from
902afd5
to
5090d40
Compare
mrhhsg
force-pushed
the
cache_time_zone
branch
2 times, most recently
from
2697030
to
d764011
Compare
|
PR approved by anyone and no changes requested. |
Gabriel39
reviewed
Nov 28, 2022
|
Before this PR After this PR |
mrhhsg
force-pushed
the
cache_time_zone
branch
from
d764011
to
f557105
Compare
mrhhsg
force-pushed
the
cache_time_zone
branch
from
f557105
to
cced55f
Compare
Gabriel39
reviewed
Nov 29, 2022
| @@ -47,6 +51,10 @@ struct ConvertTZImpl { | |||
| const ColumnString* from_tz_column, const ColumnString* to_tz_column, | |||
| ReturnColumnType* result_column, NullMap& result_null_map, | |||
| size_t input_rows_count) { | |||
| auto convert_ctx = reinterpret_cast<ConvertTzCtx*>( | |||
| context->get_function_state(FunctionContext::FunctionStateScope::THREAD_LOCAL)); | |||
| std::map<StringRef, cctz::time_zone> time_zone_cache_; | |||
There was a problem hiding this comment.
Suggested change
| std::map<StringRef, cctz::time_zone> time_zone_cache_; | |
| std::map<StringRef, cctz::time_zone> time_zone_cache; |
There was a problem hiding this comment.
time_zone_cache_ is a temporary map.
time_zone_cache is a reference to the map.
13 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
cctz::fixed_time_zonewill lock&unlock the mutex in each call, this is a non-negligible performance cost.This PR adds a map to cache the timezone to avoid finding the same timezone repeatedly.
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...