Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improvement](config) update high_priority_flush_thread_num_per_store default value to 6 #14775

Merged
merged 1 commit into from
Dec 7, 2022
Merged

[improvement](config) update high_priority_flush_thread_num_per_store default value to 6 #14775

merged 1 commit into from
Dec 7, 2022

Conversation

zhannngchen
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Problem summary

Align this config with flush_thread_num_per_store
Current default value 1 is too small for the machine with single disk.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 2, 2022 •
edited
Loading

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.3 seconds
load time: 470 seconds
storage size: 17123356207 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221207021446_clickbench_pr_58961.html

@zhannngchen zhannngchen force-pushed the update-highpri-mem-flush-thread-num branch from 6800c95 to 5901187 Compare December 4, 2022 10:53
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2022

clang-tidy review says "All clean, LGTM! 👍"

@zhannngchen zhannngchen force-pushed the update-highpri-mem-flush-thread-num branch from 5901187 to 318ef90 Compare December 4, 2022 13:36
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2022

clang-tidy review says "All clean, LGTM! 👍"

@zhannngchen zhannngchen force-pushed the update-highpri-mem-flush-thread-num branch from 318ef90 to 98c3dde Compare December 5, 2022 13:00
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2022

clang-tidy review says "All clean, LGTM! 👍"

@zhannngchen zhannngchen force-pushed the update-highpri-mem-flush-thread-num branch from 98c3dde to cac53ea Compare December 6, 2022 03:22
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

clang-tidy review says "All clean, LGTM! 👍"

@zhannngchen zhannngchen force-pushed the update-highpri-mem-flush-thread-num branch from cac53ea to 02f7759 Compare December 6, 2022 05:46
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

clang-tidy review says "All clean, LGTM! 👍"

@zhannngchen zhannngchen force-pushed the update-highpri-mem-flush-thread-num branch from 02f7759 to f7a77ec Compare December 7, 2022 01:43
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

clang-tidy review says "All clean, LGTM! 👍"

yiguolei
yiguolei approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit dfa58e7 into apache:master Dec 7, 2022
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Dec 7, 2022
@zhannngchen @Doris-Extras
[improvement](config) update high_priority_flush_thread_num_per_store…
26cb2ef 
… default value to 6 (apache#14775)
@yiguolei yiguolei mentioned this pull request Dec 7, 2022
Merged
13 tasks
yiguolei added a commit that referenced this pull request Dec 7, 2022
@yiguolei @zhannngchen
[improvement](config) update high_priority_flush_thread_num_per_store…
d23b5b6 
… default value to 6 (#14775) (#14889)

Co-authored-by: zhannngchen <48427519+zhannngchen@users.noreply.github.com>
PraveenNanda124
PraveenNanda124 reviewed Dec 8, 2022
View reviewed changes
Copy link

@PraveenNanda124 PraveenNanda124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@yiguolei yiguolei mentioned this pull request Dec 13, 2022
Open
morningman pushed a commit that referenced this pull request Dec 14, 2022
@zhannngchen @morningman
[improvement](config) update high_priority_flush_thread_num_per_store…
e33708d 
… default value to 6 (#14775)
@morningman morningman mentioned this pull request Dec 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PraveenNanda124 PraveenNanda124 PraveenNanda124 left review comments

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/1.1.5-merged dev/1.2.1-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhannngchen @hello-stephen @yiguolei @PraveenNanda124 @morningman