Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](if) fix coredump of if const #14858

Merged
merged 3 commits into from
Dec 7, 2022
Merged

[fix](if) fix coredump of if const #14858

merged 3 commits into from
Dec 7, 2022

Conversation

jacktengg
Copy link
Contributor

Proposed changes

Issue Number: close #14857

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/sql/function Issues or PRs related to the SQL functions area/vectorization kind/test labels Dec 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 6, 2022 •
edited
Loading

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.87 seconds
load time: 430 seconds
storage size: 17123356249 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221206133114_clickbench_pr_58750.html

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2022

clang-tidy review says "All clean, LGTM! 👍"

@starocean999
Copy link
Contributor

LGTM

yiguolei
yiguolei approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 3286fb4 into apache:master Dec 7, 2022
@jacktengg jacktengg deleted the fix-if-const branch December 7, 2022 03:04
yiguolei pushed a commit to yiguolei/incubator-doris that referenced this pull request Dec 7, 2022
@jacktengg @Doris-Extras
[fix](if) fix coredump of if const (apache#14858)
db65f6b
@yiguolei yiguolei mentioned this pull request Dec 7, 2022
Merged
13 tasks
@hf200012 hf200012 added the usercase Important user case type label label Dec 7, 2022
yiguolei added a commit that referenced this pull request Dec 7, 2022
@yiguolei @jacktengg
[fix](if) fix coredump of if const (#14858) (#14878)
1b2da9e 
Co-authored-by: TengJianPing <18241664+jacktengg@users.noreply.github.com>
@yiguolei yiguolei mentioned this pull request Dec 13, 2022
Open
morningman pushed a commit that referenced this pull request Dec 14, 2022
@jacktengg @morningman
[fix](if) fix coredump of if const (#14858)
8c507ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
area/sql/function Issues or PRs related to the SQL functions area/vectorization dev/1.1.5-merged dev/1.2.1-merged kind/test usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] be coredump for if statement with const
6 participants
@jacktengg @hello-stephen @starocean999 @yiguolei @hf200012 @morningman