Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](merge-on-write) fix that the query result has duplicate keys #16336

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

liaoxin01
Copy link
Contributor

@liaoxin01 liaoxin01 commented Feb 1, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

The query result has duplicate keys in unique key with MoW model. This bug is introduced by #12866.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

clang-tidy review says "All clean, LGTM! 👍"

@liaoxin01 liaoxin01 marked this pull request as draft February 1, 2023 11:52
@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 1, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.73 seconds
load time: 468 seconds
storage size: 17170994448 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230206071042_clickbench_pr_90748.html

@liaoxin01 liaoxin01 marked this pull request as ready for review February 3, 2023 11:56
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

PR approved by anyone and no changes requested.

@zhannngchen zhannngchen merged commit 2bee26b into apache:master Feb 6, 2023
morningman pushed a commit that referenced this pull request Feb 6, 2023
…16336)

* [fix](merge-on-write) fix that the query result has duplicate keys

* add ut
zclllyybb pushed a commit to zclllyybb/doris that referenced this pull request Feb 8, 2023
…pache#16336)

* [fix](merge-on-write) fix that the query result has duplicate keys

* add ut
@liaoxin01 liaoxin01 deleted the fix_dup_mow branch February 6, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/1.2.2-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants