Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](external scan node)Use consistent hash to collect BE only when the file cache is enabled. #20560

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Jun 7, 2023

Proposed changes

Issue Number: close #xxx

Use consistent hash to collect BE only when the file cache is enabled. And move the consistent BE assign code to FederationBackendPolicy.
Fix explain split number and file size incorrect bug.

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the area/planner Issues or PRs related to the query planner label Jun 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

@Jibing-Li Jibing-Li marked this pull request as ready for review June 7, 2023 14:14
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

@Jibing-Li
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

Use consistent hash to collect BE only when the file cache is enabled.
@Jibing-Li
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@xxiao2018 xxiao2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

PR approved by anyone and no changes requested.

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 8, 2023

PR approved by at least one committer and no changes requested.

@yiguolei yiguolei merged commit 195beec into apache:master Jun 9, 2023
xiaokang pushed a commit that referenced this pull request Jun 9, 2023
…the file cache is enabled. #20560

Use consistent hash to collect BE only when the file cache is enabled. And move the consistent BE assign code to FederationBackendPolicy.
Fix explain split number and file size incorrect bug.
@Jibing-Li Jibing-Li deleted the assign branch June 9, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner dev/2.0-beta-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants