Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](nereids)fix some planner bugs #21533

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

starocean999
Copy link
Contributor

Proposed changes

  1. allow cast boolean as date like type in nereids, the result is null
  2. PruneOlapScanTablet rule can prune tablet even if a mv index is selected.
  3. constant conjunct should not be pushed through agg node in old planner

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@starocean999
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added area/nereids area/planner Issues or PRs related to the query planner kind/test labels Jul 5, 2023
@morrySnow morrySnow added dev/2.0.0 2.0.0 release sqlancer labels Jul 5, 2023
@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.61 seconds
stream load tsv: 452 seconds loaded 74807831229 Bytes, about 157 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 57 seconds loaded 1101869774 Bytes, about 18 MB/s
stream load parquet: 28 seconds loaded 861443392 Bytes, about 29 MB/s
insert into select: 66.1 seconds inserted 10000000 Rows, about 151K ops/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230705101849_clickbench_pr_172756.html

@hello-stephen
Copy link
Contributor

(From new mechine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 52.93 seconds
stream load tsv: 511 seconds loaded 74807831229 Bytes, about 139 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 87.2 seconds inserted 10000000 Rows, about 114K ops/s
storage size: 17162751724 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230705190539_clickbench_pr_172758.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 2e651bb into apache:master Jul 6, 2023
@xiaokang xiaokang added dev/2.0.0-merged and removed dev/2.0.0 2.0.0 release labels Jul 6, 2023
xiaokang pushed a commit that referenced this pull request Jul 6, 2023
1. allow cast boolean as date like type in nereids, the result is null
2. PruneOlapScanTablet rule can prune tablet even if a mv index is selected.
3. constant conjunct should not be pushed through agg node in old planner
morrySnow pushed a commit that referenced this pull request Aug 14, 2024
this issue seems introduced by #21533

Fix issue that query not hit partition in original planner, which will
cause serve performance degradation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. area/nereids area/planner Issues or PRs related to the query planner dev/2.0.0-merged kind/test reviewed sqlancer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants