-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](delete) Fix parsing error of delete where date statement #22690
Conversation
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
fc1e335
to
7cdda13
Compare
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
|
||
qt_delete_date2 "select * from cost order by id" | ||
|
||
sql 'ADMIN SET FRONTEND CONFIG ("enable_date_conversion" = "true");' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will cause unpredicatable problems when running regression tests in parallel.
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Issue Number: close #22679
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...