-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature](Routine Load)Support Partial Update #22785
[Feature](Routine Load)Support Partial Update #22785
Conversation
bb19616
to
7a0f5f8
Compare
f2ac103
to
a57cb86
Compare
run buildall |
} | ||
Database db = Env.getCurrentInternalCatalog().getDbOrAnalysisException(job.getDbFullName()); | ||
Table table = db.getTableOrAnalysisException(job.getTableName()); | ||
if (isPartialUpdate && ((OlapTable) table).getKeysType() != KeysType.UNIQUE_KEYS) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should use !((OlapTable) table).getEnableUniqueKeyMergeOnWrite()
Database db = Env.getCurrentInternalCatalog().getDbOrAnalysisException(job.getDbFullName()); | ||
Table table = db.getTableOrAnalysisException(job.getTableName()); | ||
if (isPartialUpdate && ((OlapTable) table).getKeysType() != KeysType.UNIQUE_KEYS) { | ||
throw new AnalysisException("load by PARTIAL_COLUMNS is only supported in unique tables."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"in unique table MoW"
@@ -339,6 +353,9 @@ public void checkDBTable(Analyzer analyzer) throws AnalysisException { | |||
&& !(table.getType() == Table.TableType.OLAP && ((OlapTable) table).hasDeleteSign())) { | |||
throw new AnalysisException("load by MERGE or DELETE need to upgrade table to support batch delete."); | |||
} | |||
if (isPartialUpdate && ((OlapTable) table).getKeysType() != KeysType.UNIQUE_KEYS) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx, PTAL again:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
run buildall |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
run clickbench-new (clickbench) |
(From new machine)TeamCity pipeline, clickbench performance test result: |
run P0 |
(cherry picked from commit 221e860)
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...