Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature](Routine Load)Support Partial Update #22785

Merged

Conversation

CalvinKirs
Copy link
Member

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@CalvinKirs CalvinKirs force-pushed the master-partial_columns-routine-load branch from bb19616 to 7a0f5f8 Compare August 10, 2023 01:42
@CalvinKirs CalvinKirs force-pushed the master-partial_columns-routine-load branch from f2ac103 to a57cb86 Compare August 10, 2023 06:03
@CalvinKirs CalvinKirs marked this pull request as ready for review August 10, 2023 06:04
@CalvinKirs
Copy link
Member Author

run buildall

}
Database db = Env.getCurrentInternalCatalog().getDbOrAnalysisException(job.getDbFullName());
Table table = db.getTableOrAnalysisException(job.getTableName());
if (isPartialUpdate && ((OlapTable) table).getKeysType() != KeysType.UNIQUE_KEYS) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should use !((OlapTable) table).getEnableUniqueKeyMergeOnWrite()

Database db = Env.getCurrentInternalCatalog().getDbOrAnalysisException(job.getDbFullName());
Table table = db.getTableOrAnalysisException(job.getTableName());
if (isPartialUpdate && ((OlapTable) table).getKeysType() != KeysType.UNIQUE_KEYS) {
throw new AnalysisException("load by PARTIAL_COLUMNS is only supported in unique tables.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"in unique table MoW"

@@ -339,6 +353,9 @@ public void checkDBTable(Analyzer analyzer) throws AnalysisException {
&& !(table.getType() == Table.TableType.OLAP && ((OlapTable) table).hasDeleteSign())) {
throw new AnalysisException("load by MERGE or DELETE need to upgrade table to support batch delete.");
}
if (isPartialUpdate && ((OlapTable) table).getKeysType() != KeysType.UNIQUE_KEYS) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, PTAL again:)

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CalvinKirs
Copy link
Member Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 10, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@CalvinKirs
Copy link
Member Author

run clickbench-new (clickbench)

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.82 seconds
stream load tsv: 508 seconds loaded 74807831229 Bytes, about 140 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162228900 Bytes

@CalvinKirs
Copy link
Member Author

run P0

@zhannngchen zhannngchen merged commit 221e860 into apache:master Aug 10, 2023
18 of 21 checks passed
@CalvinKirs CalvinKirs deleted the master-partial_columns-routine-load branch August 10, 2023 09:44
CalvinKirs added a commit to CalvinKirs/incubator-doris that referenced this pull request Aug 11, 2023
morningman pushed a commit to morningman/doris that referenced this pull request Aug 28, 2023
morningman pushed a commit to morningman/doris that referenced this pull request Sep 1, 2023
morningman pushed a commit to morningman/doris that referenced this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.2-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants