Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new-feature](complex-type) support read nested parquet and orc file with complex type #22793

Merged
merged 3 commits into from
Aug 10, 2023
Merged

[new-feature](complex-type) support read nested parquet and orc file with complex type #22793

merged 3 commits into from
Aug 10, 2023

Conversation

amorynan
Copy link
Contributor

@amorynan amorynan commented Aug 9, 2023

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

@amorynan
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@AshinGau
Copy link
Member

LGTM

AshinGau
AshinGau previously approved these changes Aug 10, 2023
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 10, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 10, 2023
@yiguolei yiguolei changed the title [FIX](complex-type) update complex type parquet reader [new-feature](complex-type) support read nested parquet and orc file with complex type Aug 10, 2023
@amorynan amorynan requested a review from yiguolei August 10, 2023 02:47
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 10, 2023
@amorynan
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

yiguolei
yiguolei approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 10, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

morningman
morningman approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amorynan
Copy link
Contributor Author

run clickbench

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.6 seconds
stream load tsv: 514 seconds loaded 74807831229 Bytes, about 138 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.3 seconds inserted 10000000 Rows, about 341K ops/s
storage size: 17162319578 Bytes

@yiguolei yiguolei merged commit be1e0dc into apache:master Aug 10, 2023
18 of 21 checks passed
xiaokang pushed a commit that referenced this pull request Aug 11, 2023
@amorynan @xiaokang
[new-feature](complex-type) support read nested parquet and orc file …
da158fd 
…with complex type (#22793)
amorynan added a commit to amorynan/doris that referenced this pull request Aug 23, 2023
@amorynan
[new-feature](complex-type) support read nested parquet and orc file …
0c1b2bd 
…with complex type (apache#22793)
@xiaokang xiaokang mentioned this pull request Aug 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airborne12 airborne12 airborne12 left review comments

@yiguolei yiguolei yiguolei approved these changes

@morningman morningman morningman approved these changes

@AshinGau AshinGau AshinGau left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.1-merged kind/feature Categorizes issue or PR as related to a new feature. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@amorynan @AshinGau @hello-stephen @airborne12 @morningman @yiguolei @xiaokang