Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore](json reader) add original data to error messge for tracing #22803

Merged
merged 1 commit into from
Sep 2, 2023
Merged

[chore](json reader) add original data to error messge for tracing #22803

merged 1 commit into from
Sep 2, 2023

Conversation

eldenmoon
Copy link
Member

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@eldenmoon
Copy link
Member Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@eldenmoon
Copy link
Member Author

run buildall

@xiaokang xiaokang removed the dev/2.0.0 2.0.0 release label Aug 15, 2023
xiaokang
xiaokang previously approved these changes Aug 18, 2023
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 18, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

airborne12
airborne12 approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldenmoon
Copy link
Member Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

clang-tidy review says "All clean, LGTM! 👍"

@eldenmoon
Copy link
Member Author

run buildall

@hello-stephen
Copy link
Contributor

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.81 seconds
stream load tsv: 529 seconds loaded 74807831229 Bytes, about 134 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17161899824 Bytes

dataroaring
dataroaring approved these changes Sep 2, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 6b56896 into apache:master Sep 2, 2023
15 checks passed
xiaokang pushed a commit that referenced this pull request Sep 5, 2023
@eldenmoon @xiaokang
[chore](json reader) add original data to error messge for tracing (#…
f4cd21b 
…22803)
eldenmoon added a commit that referenced this pull request Sep 15, 2023
@eldenmoon
[chore](json reader) add original data to error messge for tracing (#…
757685b 
…22803)
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Sep 25, 2023
@eldenmoon
[chore](json reader) add original data to error messge for tracing (a…
7d8057a 
…pache#22803)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@airborne12 airborne12 airborne12 approved these changes

@xiaokang xiaokang xiaokang left review comments

Assignees
No one assigned
Labels
dev/2.0.2-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eldenmoon @hello-stephen @xiaokang @airborne12 @dataroaring