[Fix](statistics)Fix update cached column stats bug. #23049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
Kikyou1997
approved these changes
Aug 17, 2023
xiaokang
pushed a commit
that referenced
this pull request
Aug 17, 2023
`show column cached stats` sometimes show wrong min/max value: ``` mysql> show column cached stats hive.tpch100.region; +-------------+-------+------+----------+-----------+---------------+------+------+--------------+ | column_name | count | ndv | num_null | data_size | avg_size_byte | min | max | updated_time | +-------------+-------+------+----------+-----------+---------------+------+------+--------------+ | r_regionkey | 5.0 | 5.0 | 0.0 | 24.0 | 4.0 | N/A | N/A | null | | r_comment | 5.0 | 5.0 | 0.0 | 396.0 | 66.0 | N/A | N/A | null | | r_name | 5.0 | 5.0 | 0.0 | 40.8 | 6.8 | N/A | N/A | null | +-------------+-------+------+----------+-----------+---------------+------+------+--------------+ ``` This pr is to fix this bug. It is because while transferring ColumnStatistic object to JSON, it doesn't contain the minExpr and maxExpr attribute.
airborne12
pushed a commit
to airborne12/apache-doris
that referenced
this pull request
Aug 21, 2023
`show column cached stats` sometimes show wrong min/max value: ``` mysql> show column cached stats hive.tpch100.region; +-------------+-------+------+----------+-----------+---------------+------+------+--------------+ | column_name | count | ndv | num_null | data_size | avg_size_byte | min | max | updated_time | +-------------+-------+------+----------+-----------+---------------+------+------+--------------+ | r_regionkey | 5.0 | 5.0 | 0.0 | 24.0 | 4.0 | N/A | N/A | null | | r_comment | 5.0 | 5.0 | 0.0 | 396.0 | 66.0 | N/A | N/A | null | | r_name | 5.0 | 5.0 | 0.0 | 40.8 | 6.8 | N/A | N/A | null | +-------------+-------+------+----------+-----------+---------------+------+------+--------------+ ``` This pr is to fix this bug. It is because while transferring ColumnStatistic object to JSON, it doesn't contain the minExpr and maxExpr attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show column cached statssometimes show wrong min/max value:This pr is to fix this bug. It is because while transferring ColumnStatistic object to JSON, it doesn't contain the minExpr and maxExpr attribute.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...