[fix](planner)literal expr should do nothing in substituteImpl() method #23438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
morrySnow
approved these changes
Aug 25, 2023
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
englefly
approved these changes
Aug 25, 2023
xiaokang
pushed a commit
that referenced
this pull request
Aug 25, 2023
…od (#23438) substitute a literal expr is pointless and wrong. This pr keep literal expr unchanged during substitute process
GoGoWen
pushed a commit
to GoGoWen/incubator-doris
that referenced
this pull request
Sep 7, 2023
…od (apache#23450) substitute a literal expr is pointless and wrong. This pr keep literal expr unchanged during substitute process pick from master apache#23438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
substitute a literal expr is pointless and wrong. This pr keep literal expr unchanged during substitute process
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...