Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](compile)Fix Ambiguous regex Namespace Issue on MacOS Compilation #30652

Merged
merged 1 commit into from
Jan 31, 2024
Merged

[fix](compile)Fix Ambiguous regex Namespace Issue on MacOS Compilation #30652

merged 1 commit into from
Jan 31, 2024

Conversation

zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Jan 31, 2024

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zy-kkk
Copy link
Member Author

zy-kkk commented Jan 31, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

dataroaring
dataroaring approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 36905 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 65d6272f9577fd5bbce2b953ff93eb0c97bdacbf, data reload: false

------ Round 1 ----------------------------------
q1	17691	4794	4367	4367
q2	2039	138	128	128
q3	10607	926	933	926
q4	4648	764	739	739
q5	7679	2808	2767	2767
q6	183	119	120	119
q7	1125	732	715	715
q8	9313	2012	2004	2004
q9	7206	6326	6291	6291
q10	8102	2414	2461	2414
q11	409	207	207	207
q12	786	287	277	277
q13	18006	3287	3338	3287
q14	270	257	251	251
q15	528	494	481	481
q16	503	407	404	404
q17	931	504	538	504
q18	6771	6095	6028	6028
q19	1570	1368	1319	1319
q20	566	346	343	343
q21	6780	3062	3028	3028
q22	821	312	306	306
Total cold run time: 106534 ms
Total hot run time: 36905 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4345	4395	4378	4378
q2	317	246	237	237
q3	2999	2885	2836	2836
q4	1842	1639	1657	1639
q5	5228	5282	5214	5214
q6	192	113	115	113
q7	2169	1770	1747	1747
q8	3100	3300	3259	3259
q9	8395	8289	8250	8250
q10	5977	3577	3529	3529
q11	557	462	466	462
q12	752	569	577	569
q13	11490	3113	3070	3070
q14	282	250	249	249
q15	534	496	487	487
q16	531	485	470	470
q17	1835	1650	1677	1650
q18	7996	7750	7517	7517
q19	8755	1552	1509	1509
q20	2134	1905	1906	1905
q21	4742	4518	4528	4518
q22	538	484	490	484
Total cold run time: 74710 ms
Total hot run time: 54092 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.17% (8624/23841)
Line Coverage: 28.24% (70534/249746)
Region Coverage: 27.25% (36404/133597)
Branch Coverage: 24.03% (18642/77578)
Coverage Report: http://coverage.selectdb-in.cc/coverage/65d6272f9577fd5bbce2b953ff93eb0c97bdacbf_65d6272f9577fd5bbce2b953ff93eb0c97bdacbf/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 175208 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 65d6272f9577fd5bbce2b953ff93eb0c97bdacbf, data reload: false

query1	921	335	320	320
query2	6583	1916	1943	1916
query3	6692	207	199	199
query4	31674	22159	22198	22159
query5	4479	370	415	370
query6	260	156	157	156
query7	4607	264	263	263
query8	247	169	175	169
query9	9033	2300	2261	2261
query10	422	194	204	194
query11	18745	15425	15356	15356
query12	121	69	68	68
query13	1635	374	373	373
query14	9889	7166	7293	7166
query15	226	175	176	175
query16	7327	267	250	250
query17	1852	497	475	475
query18	1932	282	247	247
query19	178	133	126	126
query20	73	71	76	71
query21	196	130	135	130
query22	4686	4744	4504	4504
query23	31231	30307	30366	30307
query24	10905	2754	2828	2754
query25	516	318	312	312
query26	737	146	142	142
query27	2248	286	282	282
query28	5810	1859	1842	1842
query29	921	623	611	611
query30	279	136	133	133
query31	924	705	713	705
query32	98	53	51	51
query33	663	220	204	204
query34	936	463	481	463
query35	873	785	758	758
query36	1363	1170	1214	1170
query37	92	58	55	55
query38	3228	3152	3140	3140
query39	1316	1266	1244	1244
query40	191	87	84	84
query41	41	35	35	35
query42	92	80	87	80
query43	514	497	488	488
query44	1094	684	717	684
query45	202	188	176	176
query46	1078	648	630	630
query47	1594	1544	1517	1517
query48	394	311	323	311
query49	1113	275	278	275
query50	697	312	315	312
query51	5243	5146	5189	5146
query52	84	81	75	75
query53	333	266	268	266
query54	264	185	191	185
query55	80	72	73	72
query56	176	160	161	160
query57	952	897	907	897
query58	173	156	155	155
query59	2384	2433	2246	2246
query60	197	181	172	172
query61	93	86	82	82
query62	642	367	371	367
query63	276	264	265	264
query64	4894	3694	3500	3500
query65	3282	3242	3233	3233
query66	959	317	316	316
query67	14695	14297	14225	14225
query68	4319	497	511	497
query69	446	321	305	305
query70	1534	1446	1557	1446
query71	298	219	214	214
query72	5847	3142	2836	2836
query73	682	320	310	310
query74	6654	6135	6154	6135
query75	3061	2383	2318	2318
query76	2554	916	1026	916
query77	375	229	240	229
query78	9179	8750	8511	8511
query79	2065	505	503	503
query80	1902	333	317	317
query81	539	197	194	194
query82	645	77	89	77
query83	275	115	114	114
query84	256	71	76	71
query85	2111	347	337	337
query86	507	413	383	383
query87	3408	3253	3253	3253
query88	3668	2145	2167	2145
query89	433	361	351	351
query90	1917	187	182	182
query91	152	119	118	118
query92	52	41	43	41
query93	2505	432	440	432
query94	1340	162	158	158
query95	501	459	461	459
query96	616	323	316	316
query97	4311	4106	4113	4106
query98	231	186	186	186
query99	1122	674	763	674
Total cold run time: 279160 ms
Total hot run time: 175208 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.1 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 65d6272f9577fd5bbce2b953ff93eb0c97bdacbf, data reload: false

query1	0.04	0.03	0.02
query2	0.06	0.02	0.02
query3	0.24	0.06	0.06
query4	1.64	0.10	0.10
query5	0.52	0.51	0.52
query6	1.18	0.64	0.63
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.56	0.48	0.49
query10	0.56	0.55	0.57
query11	0.12	0.09	0.08
query12	0.11	0.09	0.09
query13	0.61	0.60	0.61
query14	0.77	0.79	0.80
query15	0.80	0.79	0.77
query16	0.38	0.38	0.38
query17	0.99	1.05	0.97
query18	0.22	0.27	0.23
query19	1.88	1.76	1.79
query20	0.01	0.01	0.02
query21	15.45	0.57	0.56
query22	2.23	2.61	1.02
query23	17.15	0.79	0.75
query24	2.83	1.42	0.93
query25	0.28	0.25	0.22
query26	0.52	0.14	0.15
query27	0.05	0.06	0.05
query28	10.85	0.85	0.85
query29	12.95	3.18	3.09
query30	0.66	0.54	0.54
query31	2.80	0.35	0.36
query32	3.32	0.48	0.49
query33	3.18	3.22	3.23
query34	15.80	4.23	4.32
query35	4.27	4.28	4.37
query36	1.10	1.05	1.06
query37	0.06	0.04	0.05
query38	0.04	0.03	0.03
query39	0.03	0.01	0.01
query40	0.16	0.13	0.13
query41	0.08	0.02	0.01
query42	0.02	0.02	0.01
query43	0.02	0.02	0.02
Total cold run time: 104.6 s
Total hot run time: 30.1 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 65d6272f9577fd5bbce2b953ff93eb0c97bdacbf with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       14.4 seconds inserted 10000000 Rows, about 694K ops/s

@zy-kkk zy-kkk merged commit 3c7aa0b into apache:master Jan 31, 2024
28 of 29 checks passed
yiguolei pushed a commit that referenced this pull request Jan 31, 2024
@zy-kkk @Doris-Extras
[fix](compile)Fix Ambiguous regex Namespace Issue on MacOS Compilation (
be1d5a3 
#30652)
@zy-kkk zy-kkk deleted the fix_max_compile branch January 31, 2024 14:01
yiguolei pushed a commit that referenced this pull request Jan 31, 2024
@zy-kkk @Doris-Extras
[fix](compile)Fix Ambiguous regex Namespace Issue on MacOS Compilation (
6507694 
#30652)
@adonis0147 adonis0147 mentioned this pull request Feb 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@Jibing-Li Jibing-Li Jibing-Li approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.5 reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zy-kkk @doris-robot @Jibing-Li @dataroaring @wm1581066