[pick][improvement](jdbc catalog) Optimize connection pool parameter settings #31177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. |
github-actions
bot
added
the
area/planner
zy-kkk
force-pushed
the
jdbc_pool_improve
branch
from
ab9d5bc
to
470c806
Compare
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -307,6 +307,7 @@ class JdbcTableDescriptor : public TableDescriptor { | |||
| public: | |||
| JdbcTableDescriptor(const TTableDescriptor& tdesc); | |||
| std::string debug_string() const override; | |||
| int64_t jdbc_catalog_id() const { return _jdbc_catalog_id; } | |||
There was a problem hiding this comment.
warning: function 'jdbc_catalog_id' should be marked [[nodiscard]] [modernize-use-nodiscard]
Suggested change
| int64_t jdbc_catalog_id() const { return _jdbc_catalog_id; } | |
| [[nodiscard]] int64_t jdbc_catalog_id() const { return _jdbc_catalog_id; } |
| @@ -315,8 +316,14 @@ | |||
| const std::string& jdbc_table_name() const { return _jdbc_table_name; } | |||
| const std::string& jdbc_user() const { return _jdbc_user; } | |||
| const std::string& jdbc_passwd() const { return _jdbc_passwd; } | |||
| int32_t connection_pool_min_size() const { return _connection_pool_min_size; } | |||
There was a problem hiding this comment.
warning: function 'connection_pool_min_size' should be marked [[nodiscard]] [modernize-use-nodiscard]
Suggested change
| int32_t connection_pool_min_size() const { return _connection_pool_min_size; } | |
| [[nodiscard]] int32_t connection_pool_min_size() const { return _connection_pool_min_size; } |
| @@ -315,8 +316,14 @@ | |||
| const std::string& jdbc_table_name() const { return _jdbc_table_name; } | |||
| const std::string& jdbc_user() const { return _jdbc_user; } | |||
| const std::string& jdbc_passwd() const { return _jdbc_passwd; } | |||
| int32_t connection_pool_min_size() const { return _connection_pool_min_size; } | |||
| int32_t connection_pool_max_size() const { return _connection_pool_max_size; } | |||
There was a problem hiding this comment.
warning: function 'connection_pool_max_size' should be marked [[nodiscard]] [modernize-use-nodiscard]
Suggested change
| int32_t connection_pool_max_size() const { return _connection_pool_max_size; } | |
| [[nodiscard]] int32_t connection_pool_max_size() const { return _connection_pool_max_size; } |
| @@ -315,8 +316,14 @@ | |||
| const std::string& jdbc_table_name() const { return _jdbc_table_name; } | |||
| const std::string& jdbc_user() const { return _jdbc_user; } | |||
| const std::string& jdbc_passwd() const { return _jdbc_passwd; } | |||
| int32_t connection_pool_min_size() const { return _connection_pool_min_size; } | |||
| int32_t connection_pool_max_size() const { return _connection_pool_max_size; } | |||
| int32_t connection_pool_max_wait_time() const { return _connection_pool_max_wait_time; } | |||
There was a problem hiding this comment.
warning: function 'connection_pool_max_wait_time' should be marked [[nodiscard]] [modernize-use-nodiscard]
Suggested change
| int32_t connection_pool_max_wait_time() const { return _connection_pool_max_wait_time; } | |
| [[nodiscard]] int32_t connection_pool_max_wait_time() const { return _connection_pool_max_wait_time; } |
| int32_t connection_pool_min_size() const { return _connection_pool_min_size; } | ||
| int32_t connection_pool_max_size() const { return _connection_pool_max_size; } | ||
| int32_t connection_pool_max_wait_time() const { return _connection_pool_max_wait_time; } | ||
| int32_t connection_pool_max_life_time() const { return _connection_pool_max_life_time; } |
There was a problem hiding this comment.
warning: function 'connection_pool_max_life_time' should be marked [[nodiscard]] [modernize-use-nodiscard]
Suggested change
| int32_t connection_pool_max_life_time() const { return _connection_pool_max_life_time; } | |
| [[nodiscard]] int32_t connection_pool_max_life_time() const { return _connection_pool_max_life_time; } |
| int32_t connection_pool_max_size() const { return _connection_pool_max_size; } | ||
| int32_t connection_pool_max_wait_time() const { return _connection_pool_max_wait_time; } | ||
| int32_t connection_pool_max_life_time() const { return _connection_pool_max_life_time; } | ||
| bool connection_pool_keep_alive() const { return _connection_pool_keep_alive; } |
There was a problem hiding this comment.
warning: function 'connection_pool_keep_alive' should be marked [[nodiscard]] [modernize-use-nodiscard]
Suggested change
| bool connection_pool_keep_alive() const { return _connection_pool_keep_alive; } | |
| [[nodiscard]] bool connection_pool_keep_alive() const { return _connection_pool_keep_alive; } |
TPC-H: Total hot run time: 50161 ms |
TPC-DS: Total hot run time: 237938 ms |
ClickBench: Total hot run time: 30.7 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
TeamCity be ut coverage result: |
zy-kkk
force-pushed
the
jdbc_pool_improve
branch
from
470c806
to
9f09db5
Compare
|
run buildall |
TPC-H: Total hot run time: 49947 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 240261 ms |
ClickBench: Total hot run time: 30.35 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
pick from (#30588)
This PR makes the following changes to the connection pool of JDBC Catalog
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...