Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement](nereids)send is_nereids flag to be #31752

Merged
merged 2 commits into from
Mar 7, 2024
Merged

[enhancement](nereids)send is_nereids flag to be #31752

merged 2 commits into from
Mar 7, 2024

Conversation

starocean999
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

@starocean999
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 38255 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c8f03d32c7b31f83c7e08992dfcfc9b5afd3cffd, data reload: false

------ Round 1 ----------------------------------
q1	17673	4117	4058	4058
q2	2028	156	143	143
q3	10554	968	939	939
q4	4662	961	962	961
q5	7592	2915	3016	2915
q6	182	125	127	125
q7	1314	837	862	837
q8	9500	2077	2070	2070
q9	7750	6432	6456	6432
q10	8234	2577	2546	2546
q11	418	232	217	217
q12	756	336	325	325
q13	17962	2993	2962	2962
q14	281	259	261	259
q15	491	452	444	444
q16	477	406	416	406
q17	961	879	865	865
q18	6751	5885	5904	5885
q19	1598	1539	1525	1525
q20	565	287	290	287
q21	7663	3805	3754	3754
q22	798	300	306	300
Total cold run time: 108210 ms
Total hot run time: 38255 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4045	4002	4033	4002
q2	332	227	233	227
q3	2956	2947	2935	2935
q4	1909	1886	1891	1886
q5	5278	5254	5252	5252
q6	205	115	118	115
q7	2271	1802	1804	1802
q8	3213	3291	3281	3281
q9	8545	8556	8564	8556
q10	6172	3743	3738	3738
q11	521	456	436	436
q12	692	522	536	522
q13	12548	2813	2766	2766
q14	273	249	259	249
q15	472	449	438	438
q16	450	398	411	398
q17	1693	1683	1685	1683
q18	7974	7381	7349	7349
q19	1726	1628	1624	1624
q20	1959	1705	1737	1705
q21	4953	4807	4857	4807
q22	550	469	477	469
Total cold run time: 68737 ms
Total hot run time: 54240 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 177693 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c8f03d32c7b31f83c7e08992dfcfc9b5afd3cffd, data reload: false

query1	933	359	338	338
query2	7475	2152	2013	2013
query3	6712	213	215	213
query4	25957	21065	21115	21065
query5	4302	593	462	462
query6	285	178	194	178
query7	4641	305	308	305
query8	233	176	174	174
query9	8468	2205	2190	2190
query10	439	234	279	234
query11	14953	14349	14334	14334
query12	133	90	86	86
query13	1654	421	432	421
query14	9015	7043	6929	6929
query15	241	198	194	194
query16	7268	276	280	276
query17	955	589	581	581
query18	1931	296	279	279
query19	211	166	167	166
query20	99	96	100	96
query21	204	133	131	131
query22	4593	4490	4428	4428
query23	32020	30810	30442	30442
query24	12505	3081	3126	3081
query25	708	396	392	392
query26	1918	173	173	173
query27	3029	365	365	365
query28	6499	1817	1815	1815
query29	1302	606	627	606
query30	308	146	148	146
query31	948	734	720	720
query32	97	62	59	59
query33	752	258	256	256
query34	998	482	493	482
query35	917	850	822	822
query36	932	793	819	793
query37	276	66	69	66
query38	3228	3094	3086	3086
query39	1418	1371	1379	1371
query40	297	159	119	119
query41	56	52	53	52
query42	113	100	105	100
query43	450	400	401	400
query44	1084	721	705	705
query45	207	200	193	193
query46	1050	816	777	777
query47	1667	1542	1566	1542
query48	433	350	374	350
query49	1194	336	334	334
query50	801	387	386	386
query51	6768	6481	6481	6481
query52	109	95	95	95
query53	368	288	288	288
query54	310	252	249	249
query55	88	86	85	85
query56	263	233	247	233
query57	1097	992	1010	992
query58	245	220	222	220
query59	2619	2265	2375	2265
query60	274	247	268	247
query61	102	96	94	94
query62	665	422	415	415
query63	318	290	283	283
query64	6492	3365	3226	3226
query65	3072	3054	3015	3015
query66	1468	347	338	338
query67	14990	14306	14624	14306
query68	9714	587	606	587
query69	654	400	388	388
query70	1366	1098	1094	1094
query71	554	289	295	289
query72	9152	2756	2603	2603
query73	1570	340	340	340
query74	7248	6892	6876	6876
query75	4301	2738	2702	2702
query76	5726	1076	1181	1076
query77	650	255	269	255
query78	10289	9641	9545	9545
query79	11706	521	539	521
query80	2272	389	384	384
query81	495	215	204	204
query82	328	88	85	85
query83	251	149	146	146
query84	287	79	81	79
query85	1222	342	324	324
query86	353	285	257	257
query87	3393	3128	3147	3128
query88	4147	2366	2379	2366
query89	518	367	372	367
query90	2093	177	180	177
query91	158	139	130	130
query92	62	49	49	49
query93	7007	534	517	517
query94	1366	192	191	191
query95	465	352	353	352
query96	618	264	265	264
query97	4039	3863	3894	3863
query98	220	215	201	201
query99	1079	794	775	775
Total cold run time: 308460 ms
Total hot run time: 177693 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.84 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c8f03d32c7b31f83c7e08992dfcfc9b5afd3cffd, data reload: false

query1	0.04	0.04	0.04
query2	0.06	0.03	0.03
query3	0.24	0.06	0.05
query4	1.67	0.09	0.09
query5	0.49	0.50	0.48
query6	1.20	0.66	0.68
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.58	0.51	0.51
query10	0.56	0.56	0.55
query11	0.13	0.10	0.10
query12	0.13	0.11	0.10
query13	0.58	0.57	0.56
query14	0.74	0.76	0.75
query15	0.83	0.80	0.81
query16	0.38	0.36	0.37
query17	1.03	0.97	0.99
query18	0.26	0.25	0.27
query19	1.79	1.75	1.72
query20	0.01	0.01	0.01
query21	15.41	0.64	0.60
query22	3.47	5.53	2.59
query23	17.40	1.03	1.05
query24	2.14	0.21	0.55
query25	0.27	0.13	0.03
query26	0.17	0.14	0.14
query27	0.03	0.03	0.03
query28	12.30	0.85	0.82
query29	12.68	3.23	3.26
query30	0.61	0.56	0.54
query31	2.80	0.34	0.35
query32	3.36	0.43	0.44
query33	2.98	2.96	2.92
query34	15.51	4.29	4.28
query35	4.32	4.30	4.29
query36	1.09	1.02	1.01
query37	0.07	0.05	0.05
query38	0.04	0.03	0.02
query39	0.02	0.01	0.02
query40	0.17	0.14	0.13
query41	0.08	0.02	0.02
query42	0.02	0.02	0.02
query43	0.03	0.03	0.02
Total cold run time: 105.75 s
Total hot run time: 30.84 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit c8f03d32c7b31f83c7e08992dfcfc9b5afd3cffd with default session variables
Stream load json:         18 seconds loaded 2358488459 Bytes, about 124 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       18.3 seconds inserted 10000000 Rows, about 546K ops/s

@starocean999
Copy link
Contributor Author

run buildall

@starocean999 starocean999 marked this pull request as ready for review March 7, 2024 02:17
yiguolei
yiguolei approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 7, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 8e41be9 into apache:master Mar 7, 2024
24 of 30 checks passed
yiguolei pushed a commit that referenced this pull request Mar 9, 2024
@starocean999 @Doris-Extras
[enhancement](nereids)send is_nereids flag to be (#31752)
3b56c4b
@Mryange Mryange mentioned this pull request Oct 9, 2024
Merged
HappenLee pushed a commit that referenced this pull request Oct 10, 2024
@Mryange
[enhancement](util) print if using nereids planner when be coredump #…
9115b64 
…31981 (#41605)

pick #31752
pick #31981


```
*** Query id: 77433c763b14535-be989f185c71e240 ***
*** is nereids: 0 ***
*** tablet id: 0 ***
*** Aborted at 1728464190 (unix time) try "date -d @1728464190" if you are using GNU date ***
*** Current BE git commitID: eaaf726 ***
*** SIGABRT unknown detail explain (@0x47000060661) received by PID 394849 (TID 395426 OR 0x7ff4a5f36700) from PID 394849; stack trace: ***
 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /mnt/disk2/yanxuecheng/branch-2.0/doris/be/src/common/signal_handler.h:421
 1# 0x00007FF6CED47B50 in /lib64/libc.so.6
 2# gsignal in /lib64/libc.so.6



*** Query id: 1b3633126e640e0-b1f06a5bb6c0b1cc ***
*** is nereids: 1 ***
*** tablet id: 0 ***
*** Aborted at 1728464469 (unix time) try "date -d @1728464469" if you are using GNU date ***
*** Current BE git commitID: eaaf726 ***
*** SIGABRT unknown detail explain (@0x4700006f5b8) received by PID 456120 (TID 456600 OR 0x7f72da8df700) from PID 456120; stack trace: ***
 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) at /mnt/disk2/yanxuecheng/branch-2.0/doris/be/src/common/signal_handler.h:421
 1# 0x00007F745021BB50 in /lib64/libc.so.6
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seawinde seawinde seawinde approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. meta-change reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@starocean999 @doris-robot @yiguolei @seawinde