-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](pipelinex) Fix MaxScannerThreadNum
calculation error in file scan operator when turn on pipelinex.
#33037
[Fix](pipelinex) Fix MaxScannerThreadNum
calculation error in file scan operator when turn on pipelinex.
#33037
Conversation
…scan operator when turn on pipelinex.
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
run buildall |
MaxScannerThreadNum
calculation error in file scan operator when turn on pipelinex.MaxScannerThreadNum
calculation error in file scan operator when turn on pipelinex.
TPC-H: Total hot run time: 38813 ms
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 181625 ms
|
ClickBench: Total hot run time: 29.87 s
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
|
…scan operator when turn on pipelinex. (#33037) MaxScannerThreadNum in file scan operator when turn on pipelinex is incorrect, it will cost many memory and causing performance degradation. This PR fix it.
…scan operator when turn on pipelinex. (apache#33037) MaxScannerThreadNum in file scan operator when turn on pipelinex is incorrect, it will cost many memory and causing performance degradation. This PR fix it.
…scan operator when turn on pipelinex. (apache#33037) MaxScannerThreadNum in file scan operator when turn on pipelinex is incorrect, it will cost many memory and causing performance degradation. This PR fix it.
Proposed changes
MaxScannerThreadNum
in file scan operator when turn on pipelinex is incorrect, it will cost many memory and causing performance degradation. This PR fix it.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...