Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](fe) partitionInfo is null, fe can not start #33108

Merged
merged 1 commit into from
Apr 2, 2024
Merged

[fix](fe) partitionInfo is null, fe can not start #33108

merged 1 commit into from
Apr 2, 2024

Conversation

SWJTU-ZhangLei
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@SWJTU-ZhangLei
Copy link
Contributor Author

#17863

@SWJTU-ZhangLei
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39181 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 755fd956a1ee095878558d7d1ada4678c6639071, data reload: false

------ Round 1 ----------------------------------
q1	17688	4083	4059	4059
q2	2030	188	187	187
q3	10727	1440	1465	1440
q4	10834	904	1072	904
q5	7673	3055	2996	2996
q6	222	136	137	136
q7	1150	679	635	635
q8	9846	2091	2083	2083
q9	6909	6371	6197	6197
q10	8471	3536	3480	3480
q11	416	239	240	239
q12	381	217	210	210
q13	17776	2892	2943	2892
q14	277	245	240	240
q15	531	487	491	487
q16	516	380	381	380
q17	950	913	897	897
q18	7360	6535	6467	6467
q19	1593	1537	1546	1537
q20	621	322	319	319
q21	3550	3114	3096	3096
q22	395	300	307	300
Total cold run time: 109916 ms
Total hot run time: 39181 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4075	4066	4040	4040
q2	331	226	224	224
q3	2987	2952	2993	2952
q4	1907	1877	1861	1861
q5	5287	5210	5229	5210
q6	203	122	121	121
q7	2229	1819	1828	1819
q8	3196	3278	3292	3278
q9	8438	8496	8487	8487
q10	3779	3826	3828	3826
q11	543	463	459	459
q12	717	541	526	526
q13	4930	2880	2932	2880
q14	298	261	257	257
q15	513	467	469	467
q16	457	411	424	411
q17	1705	1686	1675	1675
q18	7666	7206	7262	7206
q19	1635	1627	1621	1621
q20	1927	1721	1711	1711
q21	4982	4782	4736	4736
q22	512	423	425	423
Total cold run time: 58317 ms
Total hot run time: 54190 ms

dataroaring
dataroaring approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-DS: Total hot run time: 181758 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 755fd956a1ee095878558d7d1ada4678c6639071, data reload: false

query1	1212	1119	1107	1107
query2	6504	1921	1875	1875
query3	6663	218	218	218
query4	24659	21456	21495	21456
query5	4189	389	394	389
query6	265	184	180	180
query7	4608	311	294	294
query8	239	177	181	177
query9	8448	2234	2210	2210
query10	570	259	267	259
query11	14793	14389	14489	14389
query12	147	97	97	97
query13	1643	394	387	387
query14	8610	6939	6805	6805
query15	203	175	185	175
query16	7141	280	275	275
query17	990	599	582	582
query18	1929	294	284	284
query19	218	165	167	165
query20	107	94	97	94
query21	199	140	129	129
query22	5014	4809	4814	4809
query23	34045	33036	33023	33023
query24	12115	3220	3087	3087
query25	671	379	382	379
query26	1893	159	158	158
query27	2972	335	344	335
query28	6716	1849	1819	1819
query29	1317	587	568	568
query30	297	152	143	143
query31	975	729	721	721
query32	89	62	57	57
query33	700	252	247	247
query34	1026	482	506	482
query35	848	694	689	689
query36	1026	866	889	866
query37	281	78	75	75
query38	3525	3423	3438	3423
query39	1602	1539	1533	1533
query40	290	134	131	131
query41	46	41	43	41
query42	111	98	104	98
query43	438	422	407	407
query44	1078	705	700	700
query45	282	262	256	256
query46	1072	783	760	760
query47	1900	1789	1808	1789
query48	373	301	299	299
query49	1164	364	352	352
query50	803	388	409	388
query51	6812	6772	6734	6734
query52	113	102	98	98
query53	368	288	291	288
query54	315	227	229	227
query55	88	76	81	76
query56	235	219	216	216
query57	1199	1122	1131	1122
query58	247	223	222	222
query59	2664	2367	2416	2367
query60	263	259	249	249
query61	112	122	111	111
query62	691	449	442	442
query63	309	287	294	287
query64	6519	3132	3422	3132
query65	3118	3011	3033	3011
query66	1455	350	328	328
query67	15374	15161	15009	15009
query68	5057	558	568	558
query69	493	336	334	334
query70	1172	1144	1145	1144
query71	417	294	282	282
query72	6275	2747	2565	2565
query73	720	322	323	322
query74	6666	6354	6424	6354
query75	2974	2278	2304	2278
query76	2956	1033	1172	1033
query77	389	255	249	249
query78	10833	10208	10149	10149
query79	8381	525	530	525
query80	2045	429	414	414
query81	529	225	226	225
query82	1612	106	105	105
query83	262	163	163	163
query84	261	87	92	87
query85	2110	278	277	277
query86	503	287	275	275
query87	3698	3487	3513	3487
query88	4322	2272	2270	2270
query89	519	383	386	383
query90	1991	182	185	182
query91	135	114	112	112
query92	58	53	50	50
query93	6141	545	538	538
query94	1238	196	190	190
query95	444	336	331	331
query96	611	271	266	266
query97	2660	2492	2477	2477
query98	236	222	210	210
query99	1322	833	822	822
Total cold run time: 292918 ms
Total hot run time: 181758 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.35 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 755fd956a1ee095878558d7d1ada4678c6639071, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.04	0.04
query3	0.24	0.05	0.05
query4	1.67	0.07	0.07
query5	0.47	0.48	0.50
query6	1.16	0.66	0.65
query7	0.02	0.01	0.02
query8	0.06	0.05	0.04
query9	0.56	0.51	0.51
query10	0.58	0.55	0.56
query11	0.15	0.11	0.11
query12	0.13	0.12	0.12
query13	0.62	0.60	0.60
query14	0.77	0.79	0.80
query15	0.87	0.85	0.85
query16	0.35	0.36	0.35
query17	0.97	0.98	0.97
query18	0.26	0.25	0.25
query19	1.84	1.75	1.73
query20	0.01	0.01	0.00
query21	15.44	0.80	0.69
query22	3.28	4.84	1.85
query23	17.68	1.36	1.04
query24	1.96	0.21	0.22
query25	0.13	0.11	0.09
query26	0.29	0.18	0.19
query27	0.08	0.09	0.08
query28	13.43	0.96	0.95
query29	12.80	3.52	3.51
query30	0.25	0.07	0.05
query31	2.85	0.38	0.40
query32	3.27	0.47	0.47
query33	2.87	2.84	2.85
query34	15.50	4.34	4.34
query35	4.42	4.37	4.37
query36	0.68	0.47	0.48
query37	0.21	0.16	0.19
query38	0.17	0.17	0.15
query39	0.05	0.03	0.04
query40	0.17	0.14	0.14
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 106.58 s
Total hot run time: 30.35 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 755fd956a1ee095878558d7d1ada4678c6639071 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       15.3 seconds inserted 10000000 Rows, about 653K ops/s

@dataroaring dataroaring merged commit 2c1af39 into apache:master Apr 2, 2024
31 of 33 checks passed
SWJTU-ZhangLei added a commit to SWJTU-ZhangLei/incubator-doris that referenced this pull request Apr 3, 2024
@SWJTU-ZhangLei
[fix](fe) partitionInfo is null, fe can not start (apache#33108)
c727538
@xiaokang xiaokang mentioned this pull request Apr 3, 2024
Merged
xiaokang pushed a commit that referenced this pull request Apr 3, 2024
@SWJTU-ZhangLei
[fix](fe) partitionInfo is null, fe can not start (#33108) (#33203)
0f3d5a2
yiguolei pushed a commit that referenced this pull request Apr 10, 2024
@SWJTU-ZhangLei @Doris-Extras
[fix](fe) partitionInfo is null, fe can not start (#33108)
f47e059
yiguolei pushed a commit that referenced this pull request Apr 10, 2024
@SWJTU-ZhangLei @Doris-Extras
[fix](fe) partitionInfo is null, fe can not start (#33108)
a69f3eb
@htyoung
Copy link
Contributor

htyoung commented Jun 26, 2024

close #32690

This was referenced Jun 26, 2024
Closed
Merged
morningman pushed a commit that referenced this pull request Jun 27, 2024
@htyoung
[fix](fe) partitionInfo may throw NPE cause fe can not start (#36875)
9087f1e 
## Proposed changes

Issue Number: close #32690

Similar PR：#33108

Co-authored-by: tongyang.han <tongyang.han@jiduauto.com>
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@SWJTU-ZhangLei
[fix](fe) partitionInfo is null, fe can not start (apache#33108) (apa…
5427ed6 
…che#33203)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@Yukang-Lian Yukang-Lian Yukang-Lian approved these changes

@gavinchou gavinchou gavinchou approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/1.2.9-merged dev/2.0.8-merged p0_c reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@SWJTU-ZhangLei @doris-robot @htyoung @gavinchou @Yukang-Lian @dataroaring @xiaokang @morningman