[pipelineX](runtime filter) Fix task timeout caused by runtime filter(#33332) #33369
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| runtime_filter->set_filter_timer(filter_timer); | ||
| ExecEnv::GetInstance()->runtime_filter_timer_queue()->push_filter_timer(filter_timer); | ||
| } | ||
| void RuntimeFilterTimerQueue::start() { |
There was a problem hiding this comment.
warning: method 'start' can be made static [readability-convert-member-functions-to-static]
be/src/pipeline/pipeline_x/dependency.h:236:
- void start();
+ static void start();| @@ -188,6 +189,17 @@ class PipelineXTask : public PipelineTask { | |||
| return nullptr; | |||
| } | |||
|
|
|||
| Dependency* _runtime_filter_blocked_dependency() { | |||
There was a problem hiding this comment.
warning: method '_runtime_filter_blocked_dependency' can be made static [readability-convert-member-functions-to-static]
| Dependency* _runtime_filter_blocked_dependency() { | |
| static Dependency* _runtime_filter_blocked_dependency() { |
| void init_runtime_filter_dependency( | ||
| std::vector<std::shared_ptr<pipeline::RuntimeFilterDependency>>& | ||
| runtime_filter_dependencies, | ||
| const int id, const int node_id, const std::string& name); |
There was a problem hiding this comment.
warning: parameter 'id' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
| const int id, const int node_id, const std::string& name); | |
| int id, const int node_id, const std::string& name); |
| void init_runtime_filter_dependency( | ||
| std::vector<std::shared_ptr<pipeline::RuntimeFilterDependency>>& | ||
| runtime_filter_dependencies, | ||
| const int id, const int node_id, const std::string& name); |
There was a problem hiding this comment.
warning: parameter 'node_id' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls]
| const int id, const int node_id, const std::string& name); | |
| const int id, int node_id, const std::string& name); |
Proposed changes
pick #33332
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...