[fix](nereids) Use correct PREAGGREGATION in agg(filter(scan)) #33454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
liutang123
changed the title
|
@BiteTheDDDDt hello, do you have time to see this pr? |
|
run buildall |
| String childNameWithFuncName = ctx.isBaseIndex() | ||
| ? normalizeName(aggFunc.child(0).toSql()) | ||
| : normalizeName(CreateMaterializedViewStmt.mvColumnBuilder( | ||
| matchingAggType, normalizeName(aggFunc.child(0).toSql()))); | ||
|
|
||
| boolean contains = containsAllColumn(aggFunc.child(0), ctx.keyNameToColumn.keySet()); | ||
| if (contains || ctx.keyNameToColumn.containsKey(childNameWithFuncName)) { | ||
| if (ctx.isDupKeysOrMergeOnWrite || (!ctx.isBaseIndex() && contains)) { | ||
| if (canUseKeyColumn || ctx.isDupKeysOrMergeOnWrite || (!ctx.isBaseIndex() && contains)) { |
There was a problem hiding this comment.
maybe we can use ctx.isBaseIndex() to replace canUseKeyColumn?
There was a problem hiding this comment.
It doesn't seem to work.
...ain/java/org/apache/doris/nereids/rules/rewrite/mv/SelectMaterializedIndexWithAggregate.java
Show resolved
Hide resolved
|
run feut |
morrySnow
previously approved these changes
Apr 11, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
github-actions
bot
removed
the
approved
|
run buildall |
|
run buildall |
BiteTheDDDDt
previously approved these changes
Apr 12, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
run buildall |
TPC-H: Total hot run time: 38325 ms |
TPC-DS: Total hot run time: 183712 ms |
ClickBench: Total hot run time: 30.28 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
@morrySnow Hi, Wenxin. This PR is ready for merge. Do you have time to have a look at it? |
| } | ||
|
|
||
| qt_right_when_preagg_on "select k1, min(k2), max(k3) from test_scan_preaggregation where k1 = 1 group by k1;" | ||
| qt_right_when_preagg_off "select k1, sum(v1) from test_scan_preaggregation group by k1;" |
There was a problem hiding this comment.
qt_right_when_preagg_off is misleading, the preagg should be on ? and please use explain to verify the preagg status
There was a problem hiding this comment.
Sorry, I was originally going to test aggregation on key columns. I modified the test sql.
github-actions
bot
removed
the
approved
|
run buildall |
TPC-H: Total hot run time: 38509 ms |
TPC-DS: Total hot run time: 183093 ms |
ClickBench: Total hot run time: 30.41 s |
|
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G' |
|
@starocean999 Hi, I fix the regression test case, can you take another look at this PR? |
BiteTheDDDDt
approved these changes
Apr 15, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
starocean999
approved these changes
Apr 15, 2024
yiguolei
pushed a commit
that referenced
this pull request
Apr 16, 2024
1. set `PreAggStatus` to `ON` when agg key column by max or min; 2. #28747 may change `PreAggStatus` of scan, inherit it from the previous one.
yiguolei
pushed a commit
that referenced
this pull request
Apr 17, 2024
1. set `PreAggStatus` to `ON` when agg key column by max or min; 2. #28747 may change `PreAggStatus` of scan, inherit it from the previous one.
dataroaring
pushed a commit
that referenced
this pull request
Apr 24, 2024
1. set `PreAggStatus` to `ON` when agg key column by max or min; 2. #28747 may change `PreAggStatus` of scan, inherit it from the previous one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #33351
PreAggStatustoONwhen agg key column by max or min;PreAggStatusof scan, inherit it from the previous one.Further comments
Further regression test case will be conducted later.