Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](Nereids) could not query variant that not from table #33704

Merged
merged 1 commit into from
Apr 16, 2024
Merged

[fix](Nereids) could not query variant that not from table #33704

merged 1 commit into from
Apr 16, 2024

Conversation

morrySnow
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow morrySnow requested review from eldenmoon and 924060929 and removed request for eldenmoon April 16, 2024 07:00
@doris-robot
Copy link

TPC-H: Total hot run time: 38476 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2c066ead7c31d0ff32c155b97219ee5b30bd0dbe, data reload: false

------ Round 1 ----------------------------------
q1	17864	6997	4273	4273
q2	2005	190	187	187
q3	10582	1103	1236	1103
q4	10468	936	774	774
q5	7578	2736	2656	2656
q6	219	132	131	131
q7	1011	598	566	566
q8	9234	2050	2039	2039
q9	7411	6598	6514	6514
q10	8436	3529	3511	3511
q11	428	234	232	232
q12	382	225	213	213
q13	18757	2921	2954	2921
q14	270	211	233	211
q15	526	463	480	463
q16	519	390	380	380
q17	961	694	666	666
q18	7344	6833	6773	6773
q19	8113	1540	1540	1540
q20	639	317	302	302
q21	3492	2796	2716	2716
q22	359	306	305	305
Total cold run time: 116598 ms
Total hot run time: 38476 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4341	4194	4206	4194
q2	359	261	264	261
q3	3006	2733	2749	2733
q4	1861	1565	1572	1565
q5	5372	5355	5319	5319
q6	209	122	121	121
q7	2263	1883	1891	1883
q8	3229	3356	3318	3318
q9	8552	8611	8954	8611
q10	4075	4038	3918	3918
q11	596	494	483	483
q12	775	733	663	663
q13	16175	3220	3127	3127
q14	316	292	290	290
q15	529	483	479	479
q16	491	431	458	431
q17	1824	1491	1532	1491
q18	8097	8010	7716	7716
q19	1656	1599	1623	1599
q20	2071	1888	1827	1827
q21	5093	4878	4951	4878
q22	537	474	443	443
Total cold run time: 71427 ms
Total hot run time: 55350 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185784 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2c066ead7c31d0ff32c155b97219ee5b30bd0dbe, data reload: false

query1	894	380	363	363
query2	6318	2782	2430	2430
query3	6646	212	204	204
query4	23744	21386	21310	21310
query5	4194	424	405	405
query6	266	203	177	177
query7	4592	288	280	280
query8	227	178	183	178
query9	8520	2347	2324	2324
query10	413	241	248	241
query11	14772	14217	14204	14204
query12	135	88	87	87
query13	1643	376	365	365
query14	9514	7961	7967	7961
query15	256	180	185	180
query16	8252	257	262	257
query17	1976	599	541	541
query18	2066	276	277	276
query19	324	144	150	144
query20	89	84	84	84
query21	197	123	118	118
query22	5008	4847	4798	4798
query23	33768	33202	33348	33202
query24	11123	3001	3001	3001
query25	592	380	386	380
query26	724	158	156	156
query27	2305	370	382	370
query28	6078	2083	2084	2083
query29	842	637	615	615
query30	249	184	183	183
query31	972	752	739	739
query32	93	55	55	55
query33	645	253	255	253
query34	877	489	500	489
query35	866	734	706	706
query36	1112	919	956	919
query37	122	77	75	75
query38	3492	3442	3321	3321
query39	1634	1573	1593	1573
query40	175	130	126	126
query41	45	42	43	42
query42	106	95	95	95
query43	589	543	554	543
query44	1073	737	747	737
query45	277	279	278	278
query46	1195	754	724	724
query47	2040	2008	2010	2008
query48	382	294	307	294
query49	799	395	375	375
query50	788	397	391	391
query51	6887	6828	6927	6828
query52	96	89	87	87
query53	343	276	278	276
query54	315	237	231	231
query55	77	71	72	71
query56	240	212	222	212
query57	1191	1106	1109	1106
query58	220	204	197	197
query59	3370	3473	3604	3473
query60	253	225	228	225
query61	88	85	85	85
query62	603	448	439	439
query63	302	274	272	272
query64	4678	3925	3901	3901
query65	3067	3004	3025	3004
query66	757	333	332	332
query67	15460	14886	14931	14886
query68	5189	541	536	536
query69	523	308	309	308
query70	1207	1203	1209	1203
query71	423	277	271	271
query72	6675	2736	2590	2590
query73	716	321	318	318
query74	6763	6407	6395	6395
query75	3445	2714	2650	2650
query76	3335	1028	979	979
query77	586	273	273	273
query78	11048	10236	10324	10236
query79	8830	518	518	518
query80	1912	455	459	455
query81	519	246	242	242
query82	737	97	98	97
query83	205	167	168	167
query84	268	89	89	89
query85	1085	318	312	312
query86	385	302	321	302
query87	3461	3323	3258	3258
query88	4706	2340	2350	2340
query89	528	365	364	364
query90	1921	185	185	185
query91	136	107	104	104
query92	55	48	54	48
query93	6861	506	501	501
query94	1039	188	185	185
query95	403	302	299	299
query96	622	265	264	264
query97	3133	3081	2951	2951
query98	229	222	213	213
query99	1212	882	846	846
Total cold run time: 289113 ms
Total hot run time: 185784 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.77 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2c066ead7c31d0ff32c155b97219ee5b30bd0dbe, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.67	0.07	0.07
query5	0.50	0.47	0.50
query6	1.48	0.72	0.72
query7	0.01	0.01	0.02
query8	0.05	0.04	0.05
query9	0.54	0.51	0.50
query10	0.54	0.56	0.55
query11	0.16	0.12	0.11
query12	0.15	0.11	0.12
query13	0.61	0.59	0.58
query14	0.75	0.78	0.77
query15	0.83	0.81	0.80
query16	0.37	0.36	0.36
query17	1.03	0.97	1.01
query18	0.20	0.26	0.25
query19	1.77	1.72	1.79
query20	0.01	0.01	0.01
query21	15.42	0.66	0.65
query22	4.10	8.02	1.38
query23	18.24	1.28	1.22
query24	1.64	0.33	0.22
query25	0.14	0.08	0.09
query26	0.26	0.16	0.16
query27	0.07	0.08	0.08
query28	13.24	1.01	0.97
query29	12.56	3.29	3.27
query30	0.26	0.08	0.06
query31	2.86	0.38	0.37
query32	3.29	0.47	0.46
query33	2.85	2.80	2.86
query34	17.16	4.37	4.44
query35	4.51	4.48	4.51
query36	0.64	0.47	0.46
query37	0.18	0.16	0.15
query38	0.15	0.15	0.14
query39	0.04	0.03	0.04
query40	0.18	0.14	0.15
query41	0.10	0.05	0.05
query42	0.05	0.04	0.05
query43	0.04	0.04	0.03
Total cold run time: 109 s
Total hot run time: 29.77 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 2c066ead7c31d0ff32c155b97219ee5b30bd0dbe with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      33 seconds loaded 861443392 Bytes, about 24 MB/s
Insert into select:       14.1 seconds inserted 10000000 Rows, about 709K ops/s

@morrySnow
Copy link
Contributor Author

run p1

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

eldenmoon
eldenmoon approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morrySnow morrySnow merged commit c86d6c9 into apache:master Apr 16, 2024
25 of 29 checks passed
@morrySnow morrySnow deleted the fix_element_at branch April 16, 2024 09:20
yiguolei pushed a commit that referenced this pull request Apr 16, 2024
@morrySnow @Doris-Extras
[fix](Nereids) could not query variant that not from table (#33704)
71a1866
yiguolei pushed a commit that referenced this pull request Apr 17, 2024
@morrySnow @Doris-Extras
[fix](Nereids) could not query variant that not from table (#33704)
81f7c53
dataroaring pushed a commit that referenced this pull request Apr 24, 2024
@morrySnow @dataroaring
[fix](Nereids) could not query variant that not from table (#33704)
ab2b62e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldenmoon eldenmoon eldenmoon approved these changes

@924060929 924060929 924060929 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@morrySnow @doris-robot @924060929 @eldenmoon