Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore](runtime-filter) adjust need_local_merge setting conditions #33886

Merged
merged 6 commits into from
Apr 19, 2024
Merged

[Chore](runtime-filter) adjust need_local_merge setting conditions #33886

merged 6 commits into from
Apr 19, 2024

Conversation

BiteTheDDDDt
Copy link
Contributor

Proposed changes

adjust need_local_merge setting conditions

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 38565 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3e14b9e5d8ced1e95d9e6b30138ef79af52ef5c4, data reload: false

------ Round 1 ----------------------------------
q1	17599	4415	4382	4382
q2	2013	196	187	187
q3	10434	1119	1153	1119
q4	10194	847	722	722
q5	7504	2727	2660	2660
q6	220	138	140	138
q7	1006	600	581	581
q8	9208	2064	2051	2051
q9	7433	6609	6557	6557
q10	8463	3533	3494	3494
q11	458	254	231	231
q12	457	221	217	217
q13	17772	2963	2903	2903
q14	274	223	231	223
q15	522	485	463	463
q16	536	391	369	369
q17	960	698	682	682
q18	7461	6874	6645	6645
q19	6498	1537	1524	1524
q20	650	311	306	306
q21	3487	3177	2803	2803
q22	370	308	309	308
Total cold run time: 113519 ms
Total hot run time: 38565 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4422	4237	4225	4225
q2	361	269	258	258
q3	2965	2748	2814	2748
q4	1850	1599	1559	1559
q5	5310	5280	5319	5280
q6	212	127	126	126
q7	2263	1848	1908	1848
q8	3216	3360	3364	3360
q9	8566	8525	8673	8525
q10	4056	3901	3993	3901
q11	601	517	498	498
q12	793	665	614	614
q13	16071	3291	3190	3190
q14	316	299	271	271
q15	519	475	494	475
q16	490	441	449	441
q17	1844	1521	1525	1521
q18	8218	8023	7958	7958
q19	1694	1529	1574	1529
q20	2049	1882	1826	1826
q21	9180	4947	4963	4947
q22	548	500	449	449
Total cold run time: 75544 ms
Total hot run time: 55549 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186028 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3e14b9e5d8ced1e95d9e6b30138ef79af52ef5c4, data reload: false

query1	881	370	367	367
query2	6235	3226	2435	2435
query3	6656	210	205	205
query4	22986	21212	21315	21212
query5	4120	405	396	396
query6	277	177	170	170
query7	4578	288	293	288
query8	230	179	186	179
query9	8551	2309	2299	2299
query10	420	249	247	247
query11	14774	14192	14199	14192
query12	131	96	85	85
query13	1643	369	373	369
query14	9531	8673	7970	7970
query15	227	184	187	184
query16	7856	265	258	258
query17	1743	563	566	563
query18	1933	271	286	271
query19	212	147	149	147
query20	93	89	81	81
query21	205	125	123	123
query22	5032	4861	4783	4783
query23	33902	33048	33108	33048
query24	6146	2987	3105	2987
query25	497	400	393	393
query26	699	175	153	153
query27	1942	368	380	368
query28	3886	2082	2084	2082
query29	838	628	617	617
query30	266	180	184	180
query31	950	761	751	751
query32	61	54	56	54
query33	513	249	268	249
query34	879	500	494	494
query35	830	735	705	705
query36	1047	931	907	907
query37	117	73	79	73
query38	3434	3341	3350	3341
query39	1625	1588	1594	1588
query40	172	131	131	131
query41	45	46	45	45
query42	108	106	100	100
query43	588	557	537	537
query44	1124	756	744	744
query45	284	249	272	249
query46	1087	765	739	739
query47	2008	1920	1917	1917
query48	382	305	326	305
query49	755	411	418	411
query50	831	411	416	411
query51	6972	6979	6858	6858
query52	96	94	87	87
query53	349	279	288	279
query54	265	238	233	233
query55	80	73	73	73
query56	248	228	230	228
query57	1232	1123	1146	1123
query58	216	203	198	198
query59	3437	3152	2973	2973
query60	267	240	242	240
query61	109	104	107	104
query62	522	462	464	462
query63	311	289	275	275
query64	4211	4196	3874	3874
query65	3068	3011	3014	3011
query66	763	336	352	336
query67	15488	15052	15160	15052
query68	6983	554	561	554
query69	549	300	313	300
query70	1290	1207	1184	1184
query71	1465	1268	1274	1268
query72	6542	2727	2585	2585
query73	716	321	325	321
query74	6856	6317	6343	6317
query75	3696	2650	2592	2592
query76	3783	991	1041	991
query77	615	256	268	256
query78	11196	10280	10186	10186
query79	12682	544	540	540
query80	2657	464	449	449
query81	532	245	242	242
query82	1186	97	92	92
query83	240	166	168	166
query84	263	86	81	81
query85	1111	330	263	263
query86	459	282	314	282
query87	3490	3320	3279	3279
query88	5481	2321	2337	2321
query89	551	385	386	385
query90	2211	192	183	183
query91	124	95	97	95
query92	62	45	49	45
query93	8374	521	512	512
query94	1275	181	181	181
query95	388	302	304	302
query96	613	264	260	260
query97	3134	2938	2912	2912
query98	243	216	209	209
query99	1279	866	886	866
Total cold run time: 291010 ms
Total hot run time: 186028 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.42% (8922/25189)
Line Coverage: 27.13% (73320/270251)
Region Coverage: 26.26% (37859/144194)
Branch Coverage: 23.08% (19295/83602)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3e14b9e5d8ced1e95d9e6b30138ef79af52ef5c4_3e14b9e5d8ced1e95d9e6b30138ef79af52ef5c4/report/index.html

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 38283 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dba40dc8005d451a021546b6b180ef4cebdf5391, data reload: false

------ Round 1 ----------------------------------
q1	17599	4219	4272	4219
q2	2012	182	197	182
q3	10444	1122	1065	1065
q4	10191	795	759	759
q5	7507	2643	2662	2643
q6	222	134	135	134
q7	1008	607	581	581
q8	9218	2038	2020	2020
q9	7398	6535	6508	6508
q10	8576	3506	3511	3506
q11	457	237	234	234
q12	445	223	224	223
q13	18652	2935	2955	2935
q14	276	222	228	222
q15	511	487	481	481
q16	516	391	380	380
q17	947	610	696	610
q18	7279	6790	6701	6701
q19	6296	1521	1503	1503
q20	638	332	306	306
q21	3476	2768	2849	2768
q22	359	307	303	303
Total cold run time: 114027 ms
Total hot run time: 38283 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4353	4215	4222	4215
q2	377	263	272	263
q3	2944	2724	2748	2724
q4	1845	1550	1564	1550
q5	5310	5331	5307	5307
q6	209	125	126	125
q7	2234	1864	1896	1864
q8	3231	3357	3344	3344
q9	8576	8494	8616	8494
q10	4079	3866	3993	3866
q11	636	505	491	491
q12	802	604	682	604
q13	16173	3286	3169	3169
q14	316	297	296	296
q15	528	490	489	489
q16	506	453	454	453
q17	1795	1555	1508	1508
q18	8072	8195	8061	8061
q19	1664	1520	1554	1520
q20	2034	1836	1871	1836
q21	10840	4994	4871	4871
q22	552	506	470	470
Total cold run time: 77076 ms
Total hot run time: 55520 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185129 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dba40dc8005d451a021546b6b180ef4cebdf5391, data reload: false

query1	892	375	376	375
query2	6201	2682	2341	2341
query3	6658	203	203	203
query4	25645	21390	21577	21390
query5	4188	418	422	418
query6	283	185	190	185
query7	4575	293	286	286
query8	247	186	180	180
query9	8667	2329	2301	2301
query10	418	251	256	251
query11	14800	14312	14277	14277
query12	129	89	88	88
query13	1651	366	371	366
query14	9922	7147	8026	7147
query15	253	176	187	176
query16	8169	252	260	252
query17	1949	564	540	540
query18	2088	284	271	271
query19	240	146	149	146
query20	96	83	82	82
query21	201	127	131	127
query22	5018	4885	4858	4858
query23	34033	33230	33346	33230
query24	10852	3092	3078	3078
query25	587	387	386	386
query26	718	161	160	160
query27	2273	354	378	354
query28	5762	2117	2050	2050
query29	854	635	601	601
query30	279	199	176	176
query31	984	737	790	737
query32	97	55	54	54
query33	690	265	266	265
query34	929	505	506	505
query35	829	720	729	720
query36	1112	930	929	929
query37	109	72	69	69
query38	3455	3348	3299	3299
query39	1637	1597	1577	1577
query40	174	127	128	127
query41	48	44	48	44
query42	108	106	98	98
query43	593	546	549	546
query44	1106	735	739	735
query45	326	278	269	269
query46	1081	769	762	762
query47	2043	1986	1971	1971
query48	379	292	301	292
query49	873	401	395	395
query50	773	398	402	398
query51	6964	6806	6730	6730
query52	110	84	93	84
query53	339	279	277	277
query54	311	236	241	236
query55	76	71	75	71
query56	245	231	243	231
query57	1185	1133	1110	1110
query58	225	215	203	203
query59	3435	3165	3037	3037
query60	266	239	226	226
query61	87	87	85	85
query62	605	447	444	444
query63	313	282	289	282
query64	4842	3939	3848	3848
query65	3111	3011	3018	3011
query66	758	338	341	338
query67	15448	14907	14828	14828
query68	5979	553	546	546
query69	522	302	301	301
query70	1204	1180	1229	1180
query71	1452	1265	1267	1265
query72	6419	2636	2447	2447
query73	726	320	320	320
query74	6736	6402	6438	6402
query75	3725	2614	2657	2614
query76	4203	926	926	926
query77	579	261	264	261
query78	10884	10169	10165	10165
query79	6677	532	521	521
query80	1090	445	446	445
query81	522	242	241	241
query82	954	104	100	100
query83	199	170	172	170
query84	262	87	83	83
query85	1189	269	266	266
query86	440	301	284	284
query87	3456	3276	3214	3214
query88	4922	2384	2341	2341
query89	509	386	370	370
query90	1934	185	181	181
query91	127	96	97	96
query92	56	46	48	46
query93	5359	504	509	504
query94	1025	179	178	178
query95	401	296	295	295
query96	612	264	259	259
query97	3105	2915	2983	2915
query98	234	229	210	210
query99	1220	894	855	855
Total cold run time: 290036 ms
Total hot run time: 185129 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.46 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit dba40dc8005d451a021546b6b180ef4cebdf5391, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.03
query3	0.23	0.05	0.05
query4	1.67	0.08	0.09
query5	0.48	0.49	0.51
query6	1.48	0.73	0.72
query7	0.02	0.01	0.02
query8	0.04	0.04	0.04
query9	0.56	0.49	0.50
query10	0.54	0.57	0.53
query11	0.16	0.11	0.11
query12	0.14	0.12	0.12
query13	0.60	0.58	0.58
query14	0.75	0.79	0.76
query15	0.82	0.80	0.81
query16	0.36	0.36	0.37
query17	1.03	0.94	0.96
query18	0.21	0.25	0.23
query19	1.81	1.74	1.76
query20	0.01	0.00	0.01
query21	15.40	0.67	0.65
query22	3.88	7.78	2.11
query23	18.29	1.38	1.26
query24	1.99	0.22	0.20
query25	0.14	0.09	0.08
query26	0.28	0.16	0.17
query27	0.08	0.07	0.07
query28	13.35	1.01	0.98
query29	12.64	3.28	3.23
query30	0.25	0.08	0.05
query31	2.85	0.38	0.37
query32	3.29	0.46	0.46
query33	2.84	2.83	2.85
query34	16.89	4.39	4.43
query35	4.54	4.57	4.48
query36	0.65	0.46	0.46
query37	0.19	0.16	0.15
query38	0.16	0.14	0.15
query39	0.04	0.04	0.03
query40	0.17	0.14	0.14
query41	0.09	0.05	0.04
query42	0.06	0.04	0.05
query43	0.04	0.04	0.03
Total cold run time: 109.13 s
Total hot run time: 30.46 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit dba40dc8005d451a021546b6b180ef4cebdf5391 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      33 seconds loaded 861443392 Bytes, about 24 MB/s
Insert into select:       13.7 seconds inserted 10000000 Rows, about 729K ops/s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.42% (8922/25189)
Line Coverage: 27.12% (73291/270206)
Region Coverage: 26.26% (37872/144193)
Branch Coverage: 23.07% (19288/83602)
Coverage Report: http://coverage.selectdb-in.cc/coverage/dba40dc8005d451a021546b6b180ef4cebdf5391_dba40dc8005d451a021546b6b180ef4cebdf5391/report/index.html

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.41% (8920/25189)
Line Coverage: 27.11% (73252/270201)
Region Coverage: 26.25% (37843/144187)
Branch Coverage: 23.06% (19279/83596)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d9ecb7c954dcf3fdd9cd96c0737f4e7d77de488a_d9ecb7c954dcf3fdd9cd96c0737f4e7d77de488a/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 38125 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d9ecb7c954dcf3fdd9cd96c0737f4e7d77de488a, data reload: false

------ Round 1 ----------------------------------
q1	17608	4295	4192	4192
q2	2010	189	204	189
q3	10429	1109	1103	1103
q4	10197	758	743	743
q5	7487	2687	2621	2621
q6	220	132	134	132
q7	1000	596	588	588
q8	9234	2031	2015	2015
q9	7305	6544	6495	6495
q10	8598	3535	3501	3501
q11	451	230	226	226
q12	475	213	213	213
q13	17763	2904	2966	2904
q14	271	237	230	230
q15	527	476	463	463
q16	516	388	384	384
q17	946	747	636	636
q18	7294	6674	6719	6674
q19	5933	1496	1484	1484
q20	631	309	300	300
q21	3466	2732	2852	2732
q22	359	302	300	300
Total cold run time: 112720 ms
Total hot run time: 38125 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4309	4191	4245	4191
q2	372	265	269	265
q3	2935	2744	2682	2682
q4	1831	1542	1550	1542
q5	5325	5308	5278	5278
q6	207	121	124	121
q7	2213	1882	1890	1882
q8	3170	3327	3298	3298
q9	8583	8519	8530	8519
q10	4099	3938	3840	3840
q11	637	491	496	491
q12	801	614	613	613
q13	17581	3199	3153	3153
q14	313	279	285	279
q15	551	491	482	482
q16	481	450	472	450
q17	1814	1536	1503	1503
q18	7985	8088	7806	7806
q19	1725	1530	1556	1530
q20	1950	1790	1830	1790
q21	5048	4920	4887	4887
q22	565	458	488	458
Total cold run time: 72495 ms
Total hot run time: 55060 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185113 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d9ecb7c954dcf3fdd9cd96c0737f4e7d77de488a, data reload: false

query1	883	370	360	360
query2	6190	2751	2417	2417
query3	6656	200	206	200
query4	25425	21348	21444	21348
query5	4176	404	403	403
query6	279	200	175	175
query7	4602	283	285	283
query8	241	183	175	175
query9	8455	2327	2312	2312
query10	403	237	258	237
query11	14813	14109	14187	14109
query12	133	85	82	82
query13	1649	350	358	350
query14	9310	8118	8062	8062
query15	296	196	192	192
query16	8219	262	258	258
query17	2120	570	573	570
query18	2029	289	280	280
query19	339	152	153	152
query20	102	83	88	83
query21	206	132	128	128
query22	4990	4897	4819	4819
query23	33793	33334	33419	33334
query24	10813	3049	3085	3049
query25	582	378	376	376
query26	665	155	151	151
query27	2238	371	351	351
query28	6219	2060	2081	2060
query29	869	622	610	610
query30	322	181	185	181
query31	1032	745	779	745
query32	87	52	52	52
query33	652	237	237	237
query34	965	482	484	482
query35	881	711	730	711
query36	1082	950	926	926
query37	114	68	67	67
query38	3428	3347	3426	3347
query39	1113	1037	1029	1029
query40	175	131	127	127
query41	44	42	45	42
query42	101	99	98	98
query43	586	561	551	551
query44	1131	757	763	757
query45	315	283	266	266
query46	1096	745	749	745
query47	1984	1950	1912	1912
query48	382	291	292	291
query49	829	387	405	387
query50	768	399	384	384
query51	7072	6940	7029	6940
query52	103	90	93	90
query53	373	275	287	275
query54	302	239	232	232
query55	82	73	76	73
query56	250	237	231	231
query57	1292	1233	1160	1160
query58	225	197	203	197
query59	3604	3146	3128	3128
query60	243	216	221	216
query61	86	86	85	85
query62	576	440	432	432
query63	305	282	281	281
query64	4538	3858	3181	3181
query65	3067	3049	3063	3049
query66	756	322	320	320
query67	15331	14816	14832	14816
query68	5173	544	533	533
query69	472	305	297	297
query70	1167	1202	1204	1202
query71	1384	1260	1259	1259
query72	6501	2662	2422	2422
query73	713	317	316	316
query74	6756	6414	6484	6414
query75	3274	2623	2618	2618
query76	2691	983	980	980
query77	395	259	266	259
query78	10973	10293	10245	10245
query79	7828	514	522	514
query80	1839	444	436	436
query81	526	241	236	236
query82	1599	93	97	93
query83	286	167	163	163
query84	266	84	85	84
query85	1390	263	263	263
query86	472	317	314	314
query87	3529	3240	3324	3240
query88	5209	2312	2332	2312
query89	490	366	364	364
query90	1878	184	180	180
query91	125	99	96	96
query92	55	52	51	51
query93	6409	507	499	499
query94	1130	178	183	178
query95	395	295	296	295
query96	616	266	263	263
query97	3139	2950	2945	2945
query98	231	217	219	217
query99	1211	872	856	856
Total cold run time: 290109 ms
Total hot run time: 185113 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.25 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d9ecb7c954dcf3fdd9cd96c0737f4e7d77de488a, data reload: false

query1	0.03	0.03	0.04
query2	0.09	0.04	0.04
query3	0.23	0.05	0.06
query4	1.65	0.09	0.10
query5	0.49	0.52	0.51
query6	1.43	0.73	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.56	0.50	0.48
query10	0.56	0.55	0.54
query11	0.16	0.11	0.11
query12	0.14	0.11	0.12
query13	0.59	0.58	0.58
query14	0.75	0.76	0.80
query15	0.81	0.80	0.79
query16	0.38	0.37	0.37
query17	1.03	0.95	0.95
query18	0.24	0.24	0.24
query19	1.82	1.73	1.66
query20	0.01	0.01	0.01
query21	15.40	0.67	0.66
query22	3.90	6.63	2.84
query23	18.27	1.36	1.25
query24	1.65	0.22	0.25
query25	0.15	0.09	0.08
query26	0.27	0.16	0.17
query27	0.08	0.08	0.08
query28	13.45	0.99	0.96
query29	12.59	3.27	3.29
query30	0.26	0.07	0.06
query31	2.85	0.38	0.38
query32	3.27	0.46	0.47
query33	2.78	2.83	2.83
query34	17.11	4.39	4.45
query35	4.46	4.51	4.49
query36	0.65	0.48	0.46
query37	0.18	0.15	0.15
query38	0.16	0.14	0.14
query39	0.05	0.03	0.03
query40	0.18	0.14	0.13
query41	0.09	0.05	0.05
query42	0.05	0.04	0.05
query43	0.04	0.03	0.04
Total cold run time: 108.93 s
Total hot run time: 31.25 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit d9ecb7c954dcf3fdd9cd96c0737f4e7d77de488a with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      34 seconds loaded 861443392 Bytes, about 24 MB/s
Insert into select:       13.5 seconds inserted 10000000 Rows, about 740K ops/s

mrhhsg
mrhhsg approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@mrhhsg mrhhsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit fe251a9 into apache:master Apr 19, 2024
24 of 28 checks passed
yiguolei pushed a commit that referenced this pull request Apr 19, 2024
@BiteTheDDDDt @Doris-Extras
[Chore](runtime-filter) adjust need_local_merge setting conditions (#…
09b973d 
…33886)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiguolei yiguolei yiguolei approved these changes

@mrhhsg mrhhsg mrhhsg approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BiteTheDDDDt @doris-robot @mrhhsg @yiguolei