Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](merge-cloud) Remove expired loadJob when replayEndLoadJob #34020

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

SWJTU-ZhangLei
Copy link
Contributor

  • When starting fe with lots of finished job, it maybe OOM, so we remove expired loadJob when replaying editlog

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

* When starting fe with lots of finished job, it maybe `OOM`, so
  we remove expired loadJob when replaying editlog
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Copy link
Contributor

PR approved by anyone and no changes requested.

@SWJTU-ZhangLei
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

ClickBench: Total hot run time: 31.73 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0d77a783177a49bfe6bd1a92b524510825103174, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.24	0.05	0.05
query4	1.67	0.09	0.08
query5	0.50	0.52	0.51
query6	1.20	0.82	0.84
query7	0.02	0.01	0.02
query8	0.06	0.04	0.05
query9	0.49	0.45	0.43
query10	0.51	0.51	0.51
query11	0.14	0.10	0.11
query12	0.14	0.11	0.11
query13	0.66	0.65	0.64
query14	0.90	1.06	1.00
query15	0.84	0.85	0.85
query16	0.37	0.38	0.37
query17	1.04	0.94	1.09
query18	0.19	0.27	0.24
query19	1.87	1.68	1.74
query20	0.02	0.01	0.01
query21	15.44	0.67	0.67
query22	4.33	7.37	2.00
query23	18.26	1.40	1.33
query24	1.36	0.34	0.35
query25	0.17	0.09	0.09
query26	0.26	0.18	0.17
query27	0.09	0.09	0.09
query28	13.33	1.04	1.01
query29	12.70	3.37	3.36
query30	0.27	0.07	0.07
query31	2.86	0.40	0.40
query32	3.23	0.48	0.49
query33	2.75	2.98	2.96
query34	17.29	4.51	4.49
query35	4.64	4.64	4.73
query36	0.64	0.47	0.46
query37	0.21	0.18	0.17
query38	0.20	0.18	0.19
query39	0.05	0.05	0.05
query40	0.18	0.14	0.14
query41	0.10	0.06	0.06
query42	0.08	0.06	0.06
query43	0.05	0.05	0.05
Total cold run time: 109.47 s
Total hot run time: 31.73 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 23, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit a78a237 into apache:master Apr 23, 2024
27 of 29 checks passed
dataroaring pushed a commit that referenced this pull request Apr 24, 2024
* When starting fe with lots of finished job, it maybe `OOM`, so
  we remove expired loadJob when replaying editlog
htyoung pushed a commit to htyoung/doris that referenced this pull request Aug 9, 2024
…he#34020)

* When starting fe with lots of finished job, it maybe `OOM`, so
  we remove expired loadJob when replaying editlog

(cherry picked from commit a78a237)
htyoung pushed a commit to htyoung/doris that referenced this pull request Aug 12, 2024
…he#34020)

* When starting fe with lots of finished job, it maybe `OOM`, so
  we remove expired loadJob when replaying editlog

(cherry picked from commit a78a237)
htyoung pushed a commit to htyoung/doris that referenced this pull request Aug 12, 2024
…he#34020)

* When starting fe with lots of finished job, it maybe `OOM`, so
  we remove expired loadJob when replaying editlog

(cherry picked from commit a78a237)
morningman pushed a commit that referenced this pull request Aug 13, 2024
cherry pick from #31952
#34020
Co-authored-by: Lei Zhang <27994433+SWJTU-ZhangLei@users.noreply.github.com>
morningman pushed a commit that referenced this pull request Aug 13, 2024
cherry pick from #31952
#34020
Co-authored-by: Lei Zhang <27994433+swjtu-zhanglei@users.noreply.github.com>
morningman pushed a commit that referenced this pull request Aug 13, 2024
bp #31952 #34020

---------

Co-authored-by: Lei Zhang <27994433+swjtu-zhanglei@users.noreply.github.com>
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Aug 27, 2024
bp apache#31952 apache#34020

---------

Co-authored-by: Lei Zhang <27994433+swjtu-zhanglei@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants