Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](nereids)days_diff should match datetimev2 function sigature in higher priority #35191

Merged
merged 1 commit into from
May 23, 2024

Conversation

starocean999
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@starocean999
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-DS: Total hot run time: 181652 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b3072112c139000e22608ce2576913140e2f385a, data reload: false

query1	918	384	362	362
query2	6785	2307	2335	2307
query3	6647	212	214	212
query4	25372	21251	21225	21225
query5	4194	417	422	417
query6	270	169	170	169
query7	4584	299	285	285
query8	237	183	175	175
query9	8836	2398	2369	2369
query10	429	245	238	238
query11	15044	14210	14279	14210
query12	137	89	93	89
query13	1658	376	359	359
query14	10552	8284	7514	7514
query15	234	162	169	162
query16	8085	261	272	261
query17	1853	561	535	535
query18	2065	280	264	264
query19	207	145	149	145
query20	92	84	87	84
query21	201	127	135	127
query22	5082	4842	4824	4824
query23	34072	33632	33622	33622
query24	10829	3037	2816	2816
query25	621	362	364	362
query26	1384	154	151	151
query27	3014	306	320	306
query28	7281	2039	2026	2026
query29	892	605	612	605
query30	309	170	174	170
query31	991	764	744	744
query32	92	50	52	50
query33	736	244	237	237
query34	1083	474	470	470
query35	817	673	666	666
query36	1057	904	907	904
query37	137	66	69	66
query38	2899	2774	2782	2774
query39	1604	1546	1559	1546
query40	203	133	125	125
query41	56	44	42	42
query42	108	97	96	96
query43	570	514	554	514
query44	1228	734	741	734
query45	268	258	255	255
query46	1069	737	725	725
query47	2006	1897	1916	1897
query48	395	289	294	289
query49	1081	391	389	389
query50	769	378	379	378
query51	6904	6816	6749	6749
query52	107	88	92	88
query53	341	283	280	280
query54	835	426	432	426
query55	74	70	70	70
query56	251	217	222	217
query57	1257	1144	1136	1136
query58	234	200	204	200
query59	3465	3215	3132	3132
query60	264	234	244	234
query61	114	84	84	84
query62	689	490	481	481
query63	312	279	277	277
query64	8902	2176	1767	1767
query65	3177	3098	3124	3098
query66	1414	387	343	343
query67	15641	15119	15046	15046
query68	4590	532	541	532
query69	471	297	319	297
query70	1180	1126	1125	1125
query71	369	273	262	262
query72	7885	2569	2353	2353
query73	707	313	317	313
query74	6692	6249	6260	6249
query75	3318	2650	2611	2611
query76	2367	975	1079	975
query77	401	263	259	259
query78	10638	10775	10254	10254
query79	1695	512	513	512
query80	787	429	425	425
query81	535	243	251	243
query82	462	92	93	92
query83	232	163	165	163
query84	231	84	82	82
query85	999	265	259	259
query86	531	313	311	311
query87	3283	3121	3101	3101
query88	3758	2304	2304	2304
query89	471	372	382	372
query90	1955	183	182	182
query91	124	96	98	96
query92	63	46	49	46
query93	1395	508	497	497
query94	1193	176	185	176
query95	399	287	294	287
query96	577	269	261	261
query97	3224	2996	3004	2996
query98	237	233	215	215
query99	1182	882	907	882
Total cold run time: 284985 ms
Total hot run time: 181652 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.39 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b3072112c139000e22608ce2576913140e2f385a, data reload: false

query1	0.04	0.04	0.04
query2	0.09	0.03	0.04
query3	0.23	0.05	0.04
query4	1.67	0.07	0.07
query5	0.50	0.50	0.51
query6	1.12	0.72	0.72
query7	0.02	0.01	0.02
query8	0.06	0.04	0.04
query9	0.54	0.50	0.48
query10	0.55	0.56	0.54
query11	0.16	0.11	0.10
query12	0.14	0.12	0.12
query13	0.59	0.58	0.59
query14	0.76	0.77	0.78
query15	0.82	0.81	0.81
query16	0.38	0.36	0.35
query17	0.97	1.02	0.97
query18	0.20	0.26	0.24
query19	1.81	1.65	1.70
query20	0.02	0.01	0.01
query21	15.52	0.69	0.65
query22	4.29	7.87	1.88
query23	18.27	1.45	1.28
query24	1.46	0.34	0.19
query25	0.14	0.08	0.08
query26	0.26	0.17	0.16
query27	0.08	0.09	0.09
query28	13.46	1.01	1.02
query29	13.13	3.30	3.31
query30	0.25	0.06	0.06
query31	2.86	0.39	0.38
query32	3.27	0.48	0.47
query33	2.91	2.90	2.88
query34	17.19	4.38	4.39
query35	4.59	4.54	4.48
query36	0.64	0.45	0.46
query37	0.18	0.16	0.15
query38	0.15	0.14	0.15
query39	0.04	0.03	0.04
query40	0.16	0.13	0.14
query41	0.09	0.05	0.04
query42	0.05	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.7 s
Total hot run time: 30.39 s

@starocean999 starocean999 changed the title days_diff should match datetimev2 function sigature in higher priority [fix](nereids)days_diff should match datetimev2 function sigature in higher priority May 22, 2024
@starocean999 starocean999 marked this pull request as ready for review May 23, 2024 01:50
Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 23, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants