Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](function) support return JsonType for If function #35199

Merged
merged 1 commit into from
May 23, 2024
Merged

[fix](function) support return JsonType for If function #35199

merged 1 commit into from
May 23, 2024

Conversation

DarvenDuan
Copy link
Contributor

Proposed changes

Issue Number: close #34579

add a FunctionSignature for If to support return Type is JsonType.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@DarvenDuan
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 42251 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 55f947e49aa13b6420f8a2657b9acd25708cf318, data reload: false

------ Round 1 ----------------------------------
q1	17659	4620	4297	4297
q2	2024	185	192	185
q3	10570	1239	1243	1239
q4	10246	843	823	823
q5	7484	2834	2760	2760
q6	219	138	141	138
q7	967	615	617	615
q8	9218	2166	2147	2147
q9	9202	6713	6714	6713
q10	9305	3971	3902	3902
q11	435	261	240	240
q12	482	230	235	230
q13	17562	3278	3188	3188
q14	253	213	219	213
q15	505	480	464	464
q16	527	408	402	402
q17	996	763	714	714
q18	8621	8059	7833	7833
q19	6290	1592	1535	1535
q20	636	328	318	318
q21	5158	4167	4021	4021
q22	370	274	287	274
Total cold run time: 118729 ms
Total hot run time: 42251 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4617	4510	4432	4432
q2	401	299	284	284
q3	3130	2975	2877	2877
q4	1911	1630	1646	1630
q5	5545	5551	5561	5551
q6	222	129	128	128
q7	2203	1832	1807	1807
q8	3278	3423	3433	3423
q9	8691	8762	8673	8673
q10	4023	3786	3831	3786
q11	590	504	493	493
q12	810	633	618	618
q13	15910	3223	3140	3140
q14	297	287	272	272
q15	530	483	486	483
q16	498	440	431	431
q17	1845	1544	1530	1530
q18	7729	7627	7607	7607
q19	1683	1577	1609	1577
q20	2032	1807	1797	1797
q21	9517	4675	4631	4631
q22	575	487	509	487
Total cold run time: 76037 ms
Total hot run time: 55657 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 171189 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 55f947e49aa13b6420f8a2657b9acd25708cf318, data reload: false

query1	908	400	376	376
query2	6455	2401	2273	2273
query3	6648	209	201	201
query4	19387	17451	17387	17387
query5	4122	424	455	424
query6	252	158	160	158
query7	4581	294	300	294
query8	239	192	187	187
query9	8421	2374	2382	2374
query10	479	302	260	260
query11	10532	10011	10023	10011
query12	133	88	89	88
query13	1632	367	356	356
query14	10144	6043	6971	6043
query15	216	170	172	170
query16	7157	262	257	257
query17	1307	520	519	519
query18	1920	271	270	270
query19	199	156	155	155
query20	94	83	89	83
query21	201	136	131	131
query22	4245	3927	3878	3878
query23	33648	33130	33112	33112
query24	11447	2879	2737	2737
query25	635	352	357	352
query26	1568	158	177	158
query27	2972	319	315	315
query28	7517	2045	2028	2028
query29	1055	616	600	600
query30	265	172	176	172
query31	965	754	740	740
query32	94	52	56	52
query33	754	270	268	268
query34	971	484	486	484
query35	777	621	593	593
query36	1097	930	932	930
query37	155	68	70	68
query38	2877	2780	2710	2710
query39	832	821	777	777
query40	255	124	125	124
query41	46	43	43	43
query42	106	97	97	97
query43	585	537	558	537
query44	1261	725	763	725
query45	185	160	165	160
query46	1073	706	718	706
query47	1825	1785	1776	1776
query48	364	305	299	299
query49	918	404	404	404
query50	773	392	386	386
query51	6853	6802	6788	6788
query52	103	91	93	91
query53	352	286	295	286
query54	868	437	465	437
query55	74	72	73	72
query56	271	238	246	238
query57	1123	1023	1014	1014
query58	237	205	232	205
query59	3359	3238	3119	3119
query60	273	277	254	254
query61	88	89	86	86
query62	639	449	449	449
query63	316	291	288	288
query64	9885	2347	1748	1748
query65	3175	3126	3112	3112
query66	1376	332	326	326
query67	15171	14675	14828	14675
query68	4509	531	533	531
query69	447	268	276	268
query70	1154	1136	1171	1136
query71	415	267	270	267
query72	7705	5339	5532	5339
query73	728	321	318	318
query74	6095	5647	5666	5647
query75	3349	2648	2624	2624
query76	2234	1017	1050	1017
query77	388	312	267	267
query78	10320	9981	9872	9872
query79	2455	510	525	510
query80	1130	453	426	426
query81	546	252	248	248
query82	747	102	95	95
query83	255	169	184	169
query84	251	85	82	82
query85	1528	268	258	258
query86	461	301	315	301
query87	3274	3139	3088	3088
query88	4252	2310	2325	2310
query89	479	394	391	391
query90	2015	200	184	184
query91	120	148	95	95
query92	60	48	48	48
query93	1969	506	488	488
query94	1229	184	182	182
query95	403	313	316	313
query96	589	262	259	259
query97	3192	2974	2976	2974
query98	248	216	215	215
query99	1124	831	831	831
Total cold run time: 272126 ms
Total hot run time: 171189 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.31 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 55f947e49aa13b6420f8a2657b9acd25708cf318, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.25	0.05	0.06
query4	2.09	0.07	0.08
query5	0.51	0.52	0.51
query6	1.12	0.73	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.54	0.50	0.49
query10	0.54	0.54	0.55
query11	0.15	0.11	0.12
query12	0.14	0.12	0.12
query13	0.60	0.59	0.60
query14	0.76	0.80	0.77
query15	0.82	0.80	0.82
query16	0.37	0.36	0.37
query17	1.05	0.94	0.94
query18	0.24	0.23	0.26
query19	1.89	1.73	1.78
query20	0.02	0.01	0.01
query21	15.49	0.69	0.68
query22	4.69	7.59	1.60
query23	18.32	1.41	1.32
query24	1.49	0.35	0.21
query25	0.15	0.08	0.09
query26	0.26	0.17	0.17
query27	0.08	0.07	0.08
query28	13.37	1.01	1.00
query29	13.30	3.27	3.23
query30	0.25	0.05	0.05
query31	2.86	0.39	0.38
query32	3.27	0.46	0.46
query33	2.88	2.94	2.93
query34	17.14	4.42	4.42
query35	4.52	4.51	4.63
query36	0.65	0.46	0.45
query37	0.17	0.16	0.15
query38	0.14	0.14	0.15
query39	0.05	0.03	0.04
query40	0.15	0.14	0.14
query41	0.09	0.05	0.05
query42	0.05	0.04	0.04
query43	0.04	0.04	0.03
Total cold run time: 110.69 s
Total hot run time: 30.31 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 91d5316 into apache:master May 23, 2024
27 of 29 checks passed
yiguolei pushed a commit that referenced this pull request May 24, 2024
@DarvenDuan @Doris-Extras
[fix](function) support return JsonType for If function (#35199)
dd567fa 
add a FunctionSignature for If to support return Type is JsonType.
dataroaring pushed a commit that referenced this pull request May 26, 2024
@DarvenDuan @dataroaring
[fix](function) support return JsonType for If function (#35199)
e5e5ced 
add a FunctionSignature for If to support return Type is JsonType.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.3-merged dev/3.0.0-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Doris 2.1 throws an exception when parsing a case-when statement using the json_parse function
6 participants
@DarvenDuan @doris-robot @starocean999 @morrySnow @wm1581066 @dataroaring