Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch-2.1][improve](jdbc catalog) Remove all property checks during create #35354

Merged
merged 1 commit into from
May 24, 2024

Conversation

zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented May 24, 2024

Proposed changes

Issue Number: close #xxx

pick #35194
Previously, in order to prevent users from writing wrong parameters when creating a jdbc catalog, we checked all properties. However, we found that when the parent class adds a new property, the subclass cannot sense the parent class's newly added property and can only manually add a check list. In order to avoid this trouble, I will delete this check for now and will check it in a better way later.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zy-kkk zy-kkk changed the title [improve](jdbc catalog) Remove all property checks during create [branch-2.1][improve](jdbc catalog) Remove all property checks during create May 24, 2024
@zy-kkk zy-kkk merged commit cf46ebe into apache:branch-2.1 May 24, 2024
11 checks passed
@zy-kkk zy-kkk deleted the jdbc_resource21 branch May 24, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants