Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](arrow-flight-sql) Fix pipelineX Unknown result sink type #35804

Merged

Conversation

xinyiZzz
Copy link
Contributor

@xinyiZzz xinyiZzz commented Jun 3, 2024

Fix meet error status: [INTERNAL_ERROR]Unknown result sink type

W20240422 14:52:07.509462 40713 status.h:380] meet error status: [INTERNAL_ERROR]Unknown result sink type

        0#  doris::pipeline::ResultSinkLocalState::open(doris::RuntimeState*) at /home/zcp/repo_center/doris_release/doris/be/src/common/status.h:0
        1#  doris::pipeline::PipelineXTask::_open() at /home/zcp/repo_center/doris_release/doris/be/src/common/status.h:449
        2#  doris::pipeline::PipelineXTask::execute(bool*) at /home/zcp/repo_center/doris_release/doris/be/src/common/status.h:449
        3#  doris::pipeline::TaskScheduler::_do_work(unsigned long) at /home/zcp/repo_center/doris_release/doris/be/src/common/status.h:345
        4#  doris::ThreadPool::dispatch_thread() at /home/zcp/repo_center/doris_release/doris/be/src/util/threadpool.cpp:0
        5#  doris::Thread::supervise_thread(void*) at /var/local/ldb_toolchain/bin/../usr/include/pthread.h:562
        6#  start_thread
        7#  clone

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented Jun 3, 2024

run buildall

@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented Jun 3, 2024

run buildall

@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented Jun 3, 2024

run buildall

Copy link
Contributor

github-actions bot commented Jun 3, 2024

clang-tidy review says "All clean, LGTM! 👍"

2 similar comments
Copy link
Contributor

github-actions bot commented Jun 3, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

github-actions bot commented Jun 3, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40226 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 54a9b80e306c0cb81ef5c13954d63772a10e1fca, data reload: false

------ Round 1 ----------------------------------
q1	17632	4390	4281	4281
q2	2031	202	201	201
q3	10437	1263	1225	1225
q4	10495	854	810	810
q5	7796	2679	2665	2665
q6	224	135	139	135
q7	974	612	606	606
q8	9275	2116	2070	2070
q9	9505	6628	6568	6568
q10	10165	3724	3726	3724
q11	456	238	248	238
q12	417	230	235	230
q13	17769	2959	2994	2959
q14	266	225	225	225
q15	516	465	468	465
q16	553	375	368	368
q17	966	731	695	695
q18	8056	7435	7423	7423
q19	5231	1425	1409	1409
q20	654	306	309	306
q21	4999	3289	3937	3289
q22	390	334	336	334
Total cold run time: 118807 ms
Total hot run time: 40226 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4541	4287	4204	4204
q2	360	261	259	259
q3	2963	2720	2697	2697
q4	1841	1588	1587	1587
q5	5214	5274	5258	5258
q6	221	129	129	129
q7	2111	1717	1672	1672
q8	3198	3360	3326	3326
q9	8297	8296	8365	8296
q10	3912	3648	3679	3648
q11	583	489	485	485
q12	771	585	613	585
q13	16737	2985	2936	2936
q14	292	258	276	258
q15	514	479	483	479
q16	467	404	415	404
q17	1769	1502	1483	1483
q18	7612	7356	7404	7356
q19	1717	1497	1608	1497
q20	1989	1771	1781	1771
q21	4844	4715	4800	4715
q22	630	549	548	548
Total cold run time: 70583 ms
Total hot run time: 53593 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.28% (9237/25460)
Line Coverage: 27.65% (75826/274283)
Region Coverage: 26.86% (39263/146168)
Branch Coverage: 23.60% (19906/84358)
Coverage Report: http://coverage.selectdb-in.cc/coverage/54a9b80e306c0cb81ef5c13954d63772a10e1fca_54a9b80e306c0cb81ef5c13954d63772a10e1fca/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 170004 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 54a9b80e306c0cb81ef5c13954d63772a10e1fca, data reload: false

query1	914	367	370	367
query2	6477	2413	2407	2407
query3	6644	205	209	205
query4	20677	17566	17279	17279
query5	4183	453	459	453
query6	244	162	158	158
query7	4587	298	296	296
query8	318	298	281	281
query9	8639	2425	2398	2398
query10	459	318	270	270
query11	10567	10074	10128	10074
query12	136	87	86	86
query13	1635	391	363	363
query14	10073	7580	6910	6910
query15	226	185	186	185
query16	7805	262	266	262
query17	1834	523	539	523
query18	1948	273	268	268
query19	199	153	155	153
query20	100	86	83	83
query21	204	130	124	124
query22	4187	3986	3958	3958
query23	33651	32877	33224	32877
query24	12083	2917	2822	2822
query25	664	356	370	356
query26	1838	151	154	151
query27	3066	323	321	321
query28	7451	2061	2078	2061
query29	1170	608	600	600
query30	292	146	147	146
query31	956	742	711	711
query32	85	55	55	55
query33	770	285	281	281
query34	991	472	471	471
query35	760	603	590	590
query36	1079	934	939	934
query37	292	72	68	68
query38	2865	2745	2714	2714
query39	872	781	792	781
query40	285	124	123	123
query41	53	55	50	50
query42	114	94	96	94
query43	568	560	553	553
query44	1238	728	736	728
query45	201	173	167	167
query46	1092	713	709	709
query47	1898	1789	1778	1778
query48	360	298	302	298
query49	1241	399	405	399
query50	787	387	380	380
query51	6926	6749	6828	6749
query52	98	98	86	86
query53	358	284	284	284
query54	931	443	432	432
query55	72	71	74	71
query56	280	254	261	254
query57	1146	1065	1097	1065
query58	260	249	251	249
query59	3398	3094	3243	3094
query60	297	271	273	271
query61	92	91	90	90
query62	651	453	440	440
query63	312	283	285	283
query64	9951	2208	1726	1726
query65	3164	3091	3109	3091
query66	1361	329	315	315
query67	15340	14962	15091	14962
query68	4500	543	539	539
query69	454	292	290	290
query70	1140	1132	1098	1098
query71	398	295	271	271
query72	7035	5415	2821	2821
query73	757	333	319	319
query74	5958	5489	5528	5489
query75	3351	2665	2660	2660
query76	2614	1016	855	855
query77	450	283	286	283
query78	10331	9865	9898	9865
query79	2543	511	509	509
query80	2044	453	454	453
query81	567	221	219	219
query82	705	100	108	100
query83	308	174	174	174
query84	264	88	93	88
query85	2093	279	280	279
query86	495	313	305	305
query87	3292	3092	3081	3081
query88	4100	2357	2375	2357
query89	486	394	392	392
query90	1799	190	189	189
query91	141	107	107	107
query92	68	51	51	51
query93	1704	517	505	505
query94	1246	196	198	196
query95	413	332	321	321
query96	603	268	268	268
query97	3209	3060	3091	3060
query98	248	221	215	215
query99	1078	862	866	862
Total cold run time: 277809 ms
Total hot run time: 170004 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.19 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 54a9b80e306c0cb81ef5c13954d63772a10e1fca, data reload: false

query1	0.04	0.03	0.03
query2	0.09	0.04	0.04
query3	0.24	0.05	0.04
query4	1.69	0.07	0.07
query5	0.48	0.48	0.49
query6	1.13	0.72	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.52	0.50	0.50
query10	0.55	0.56	0.53
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.60	0.58	0.60
query14	0.78	0.77	0.79
query15	0.84	0.81	0.80
query16	0.36	0.36	0.36
query17	1.02	0.99	1.03
query18	0.22	0.24	0.23
query19	1.84	1.71	1.70
query20	0.01	0.01	0.01
query21	15.47	0.70	0.65
query22	4.04	8.02	1.67
query23	18.31	1.38	1.29
query24	1.78	0.21	0.24
query25	0.16	0.07	0.08
query26	0.27	0.18	0.17
query27	0.08	0.08	0.07
query28	13.40	1.01	0.99
query29	12.92	3.28	3.29
query30	0.24	0.06	0.06
query31	2.88	0.39	0.39
query32	3.28	0.46	0.46
query33	2.85	2.87	2.83
query34	17.14	4.42	4.42
query35	4.46	4.51	4.47
query36	0.64	0.46	0.45
query37	0.18	0.16	0.16
query38	0.14	0.14	0.14
query39	0.04	0.04	0.03
query40	0.16	0.14	0.14
query41	0.08	0.04	0.04
query42	0.06	0.04	0.04
query43	0.04	0.03	0.03
Total cold run time: 109.41 s
Total hot run time: 30.19 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Jun 5, 2024

PR approved by anyone and no changes requested.

Copy link
Contributor

@wangbo wangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinyiZzz xinyiZzz merged commit ddd9f9b into apache:master Jun 5, 2024
26 of 29 checks passed
dataroaring pushed a commit that referenced this pull request Jun 7, 2024
Fix meet error status: [INTERNAL_ERROR]Unknown result sink type

```
W20240422 14:52:07.509462 40713 status.h:380] meet error status: [INTERNAL_ERROR]Unknown result sink type

        0#  doris::pipeline::ResultSinkLocalState::open(doris::RuntimeState*) at /home/zcp/repo_center/doris_release/doris/be/src/common/status.h:0
        1#  doris::pipeline::PipelineXTask::_open() at /home/zcp/repo_center/doris_release/doris/be/src/common/status.h:449
        2#  doris::pipeline::PipelineXTask::execute(bool*) at /home/zcp/repo_center/doris_release/doris/be/src/common/status.h:449
        3#  doris::pipeline::TaskScheduler::_do_work(unsigned long) at /home/zcp/repo_center/doris_release/doris/be/src/common/status.h:345
        4#  doris::ThreadPool::dispatch_thread() at /home/zcp/repo_center/doris_release/doris/be/src/util/threadpool.cpp:0
        5#  doris::Thread::supervise_thread(void*) at /var/local/ldb_toolchain/bin/../usr/include/pthread.h:562
        6#  start_thread
        7#  clone
```
xinyiZzz added a commit to xinyiZzz/incubator-doris that referenced this pull request Jul 9, 2024
…e#35804)

Fix meet error status: [INTERNAL_ERROR]Unknown result sink type

```
W20240422 14:52:07.509462 40713 status.h:380] meet error status: [INTERNAL_ERROR]Unknown result sink type

        0#  doris::pipeline::ResultSinkLocalState::open(doris::RuntimeState*) at /home/zcp/repo_center/doris_release/doris/be/src/common/status.h:0
        1#  doris::pipeline::PipelineXTask::_open() at /home/zcp/repo_center/doris_release/doris/be/src/common/status.h:449
        2#  doris::pipeline::PipelineXTask::execute(bool*) at /home/zcp/repo_center/doris_release/doris/be/src/common/status.h:449
        3#  doris::pipeline::TaskScheduler::_do_work(unsigned long) at /home/zcp/repo_center/doris_release/doris/be/src/common/status.h:345
        4#  doris::ThreadPool::dispatch_thread() at /home/zcp/repo_center/doris_release/doris/be/src/util/threadpool.cpp:0
        5#  doris::Thread::supervise_thread(void*) at /var/local/ldb_toolchain/bin/../usr/include/pthread.h:562
        6#  start_thread
        7#  clone
```
@yiguolei yiguolei mentioned this pull request Jul 19, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.5-merged dev/3.0.0-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants