Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch-1.2](complex type) forbid MAP type and STRUCT type in v1.2 #36494

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

cambyzju
Copy link
Contributor

Proposed changes

There are lots of basic usage problems for MAP and STRUCT in v1.2, so we forbid them on v1.2

such as:

CREATE TABLE `test` (
  `k1` varchar(20) NULL COMMENT "",
  `v` MAP<varchar(20),varchar(200)> NULL COMMENT ""
) ENGINE = OLAP
DISTRIBUTED BY HASH(`k1`)
BUCKETS 1
PROPERTIES ("replication_num"  =  "1");

> desc test;
+-------+------------------------------------------+------+-------+---------+-------+
| Field | Type                                     | Null | Key   | Default | Extra |
+-------+------------------------------------------+------+-------+---------+-------+
| k1    | VARCHAR(20)                              | Yes  | true  | NULL    |       |
| v     | org.apache.doris.catalog.MapType@7c62f50 | Yes  | false | NULL    | NONE  |
+-------+------------------------------------------+------+-------+---------+-------+

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jun 19, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cambyzju cambyzju merged commit af3bf67 into apache:branch-1.2-lts Jun 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants