-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature](show) show backend config using ShowStmt #36525
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TPC-H: Total hot run time: 39959 ms
|
TPC-DS: Total hot run time: 174356 ms
|
ClickBench: Total hot run time: 30.98 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
run p0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this feature(show config) supported in Nereids?
ShowStmt does not differentiate between old and new optimizers,so it works with both. |
should what |
The NereidsParser can't parse all ShowStmt (e.g., |
I think so. But if all ShowStmt are not supported now for nereids, it's also good for this pr. The optimizer group may look forward for nereids compatible in the future |
I have optimized the implementation and now it supports nereids. |
run buildall |
TPC-H: Total hot run time: 39823 ms
|
TPC-DS: Total hot run time: 173010 ms
|
ClickBench: Total hot run time: 31 s
|
75b5602
to
d6163b5
Compare
TPC-DS: Total hot run time: 174697 ms
|
ClickBench: Total hot run time: 31.37 s
|
d6163b5
to
80b39e9
Compare
run buildall |
TPC-H: Total hot run time: 38551 ms
|
TPC-DS: Total hot run time: 191881 ms
|
ClickBench: Total hot run time: 31.57 s
|
fe/fe-core/src/main/java/org/apache/doris/analysis/ShowConfigStmt.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4
Outdated
Show resolved
Hide resolved
80b39e9
to
bc28826
Compare
run buildall |
TPC-H: Total hot run time: 38478 ms
|
TPC-DS: Total hot run time: 190313 ms
|
ClickBench: Total hot run time: 31.24 s
|
PR approved by at least one committer and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Currently, Doris only supports accessing backend configurations via HTTP APIs. To enhance this functionality, I have added some syntax extensions to allow displaying backend configurations using SQL commands. The SQL syntax for displaying backend configurations is similar to that for displaying frontend configurations: 1. Display backend configurations matching a pattern: This statement will display all active backend configurations that match the specified pattern. show backend config like ${pattern} 3. Display backend configurations for a specific BE using the backend ID show backend config from ${beId} 4. Use both a pattern and a backend ID: show backend config like ${pattern} from ${backendID} The output of these statements consists of 6 columns: BE ID, BE host IP, configuration key, configuration value, configuration type, and whether it is mutable or not. +-----------+---------------+---------+-------+---------+-----------+ | BackendId | Host | Key | Value | Type | IsMutable | +-----------+---------------+---------+-------+---------+-----------+ | 10001 | xx.xx.xxx.xxx | be_port | 9060 | int32_t | false | +-----------+---------------+---------+-------+---------+-----------+ This provides an additional way to access backend configurations within Doris. Co-authored-by: duanxujian <duanxujian@jd.com>
Proposed changes
Issue Number: close #36445
Currently, Doris only supports accessing backend configurations via HTTP APIs. To enhance this functionality, I have added some syntax extensions to allow displaying backend configurations using SQL commands.
The SQL syntax for displaying backend configurations is similar to that for displaying frontend configurations:
This statement will display all active backend configurations that match the specified pattern.
The output of these statements consists of 6 columns: BE ID, BE host IP, configuration key, configuration value, configuration type, and whether it is mutable or not.
This provides an additional way to access backend configurations within Doris.