Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[[enhancement](compaction) adjust compaction concurrency based on compaction score and workload #37491

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

luwei16
Copy link
Contributor

@luwei16 luwei16 commented Jul 8, 2024

adjust compaction concurrency based on compaction score and workload #36672
fix null pointer when retrieving CPU load average #37171

…action score and workload (apache#36672)

1 Resolved the issue where the priority queue did not reserve slots for
cumulative compaction.

2 When considering compaction task priorities, introduced metrics for
CPU and memory usage rates. When the compaction score is low, and CPU or
memory usage is high, reduce the number of compaction tasks generated
and allocate CPU and memory resources to queries or load.

3 Integrated the logic of the priority queue and concurrency control
together, removing the previous priority code.
…pache#37171)

1 When enable_system_metrics = false, system_metrics is a null pointer
2 When BE exits, system_metrics has been destructed, and the compaction
background thread may still be running
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@luwei16
Copy link
Contributor Author

luwei16 commented Jul 8, 2024

run buildall

Copy link
Contributor

github-actions bot commented Jul 8, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.33% (9153/25193)
Line Coverage: 27.87% (74742/268173)
Region Coverage: 26.76% (38554/144052)
Branch Coverage: 23.45% (19533/83280)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9042fa19e1cac4f4dc83aac07305fa107d0972b8_9042fa19e1cac4f4dc83aac07305fa107d0972b8/report/index.html

@dataroaring dataroaring merged commit 3337c1b into apache:branch-2.1 Jul 9, 2024
21 of 23 checks passed
@yiguolei yiguolei mentioned this pull request Jul 19, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants