-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug](join) fix broadcast join running when hash table build not finished #37792
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39993 ms
|
TPC-DS: Total hot run time: 173538 ms
|
ClickBench: Total hot run time: 31.37 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
…shed (apache#37792) in pr https://github.com/apache/doris/pull/37643/files wants fix the bug of join which not build hash table, but running early and not wait the finished signal. But this may be a normal phenomenon, as it should allows all sinks to run when the source operator have closed, so here return eof status directly when signal == false.
…shed (#37792) in pr https://github.com/apache/doris/pull/37643/files wants fix the bug of join which not build hash table, but running early and not wait the finished signal. But this may be a normal phenomenon, as it should allows all sinks to run when the source operator have closed, so here return eof status directly when signal == false.
in pr #37643
wants fix the bug of join which not build hash table, but running early and not wait the finished signal.
But this may be a normal phenomenon, as it should allows all sinks to run when the source operator have closed,
so here return eof status directly when signal == false.
Proposed changes
Issue Number: close #xxx