Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Opt](load) don't print stack when some errors occur for stream load #38332

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

liaoxin01
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@liaoxin01
Copy link
Contributor Author

run buildall

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 24, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39833 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2d9572a94a62092ed54f28844363084007ddbb1d, data reload: false

------ Round 1 ----------------------------------
q1	17630	4310	4239	4239
q2	2021	190	181	181
q3	10465	1198	1095	1095
q4	10189	815	746	746
q5	7710	2748	2692	2692
q6	224	139	139	139
q7	975	617	601	601
q8	9241	2086	2079	2079
q9	8793	6530	6632	6530
q10	8837	3768	3794	3768
q11	450	252	238	238
q12	398	230	220	220
q13	17905	2964	2976	2964
q14	276	245	231	231
q15	541	488	493	488
q16	510	380	371	371
q17	955	653	669	653
q18	8075	7637	7442	7442
q19	6474	1462	1394	1394
q20	705	325	322	322
q21	4905	3253	3158	3158
q22	349	282	286	282
Total cold run time: 117628 ms
Total hot run time: 39833 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4387	4250	4267	4250
q2	377	270	275	270
q3	2982	2717	2800	2717
q4	1871	1605	1607	1605
q5	5298	5305	5314	5305
q6	226	129	130	129
q7	2148	1735	1733	1733
q8	3211	3318	3315	3315
q9	8365	8409	8374	8374
q10	3884	3738	3639	3639
q11	566	494	500	494
q12	773	611	571	571
q13	16748	2989	2991	2989
q14	305	267	275	267
q15	518	472	473	472
q16	485	426	412	412
q17	1766	1514	1490	1490
q18	7676	7506	7322	7322
q19	3986	1619	1463	1463
q20	2014	1791	1780	1780
q21	4848	4690	4673	4673
q22	571	496	510	496
Total cold run time: 73005 ms
Total hot run time: 53766 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174092 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2d9572a94a62092ed54f28844363084007ddbb1d, data reload: false

query1	905	375	368	368
query2	6435	1859	1764	1764
query3	6655	207	237	207
query4	28296	17332	17258	17258
query5	4213	487	496	487
query6	267	163	157	157
query7	4590	290	293	290
query8	247	210	213	210
query9	8421	2403	2377	2377
query10	446	308	282	282
query11	11437	10118	10008	10008
query12	135	84	83	83
query13	1643	380	375	375
query14	10419	7741	7697	7697
query15	216	167	169	167
query16	7816	501	502	501
query17	1588	554	552	552
query18	1971	289	287	287
query19	201	159	161	159
query20	91	84	85	84
query21	215	131	134	131
query22	4552	4107	4021	4021
query23	33941	34809	33254	33254
query24	12035	2846	2914	2846
query25	562	389	394	389
query26	1258	154	151	151
query27	2992	278	277	277
query28	7273	2016	1997	1997
query29	902	651	644	644
query30	299	154	159	154
query31	988	736	749	736
query32	94	54	59	54
query33	781	355	362	355
query34	917	481	497	481
query35	880	740	750	740
query36	1100	974	954	954
query37	213	80	83	80
query38	2885	2757	2760	2757
query39	865	811	842	811
query40	274	123	121	121
query41	50	45	44	44
query42	124	99	105	99
query43	512	466	472	466
query44	1209	734	724	724
query45	205	175	177	175
query46	1099	764	727	727
query47	1852	1780	1796	1780
query48	367	294	303	294
query49	1186	427	421	421
query50	794	398	406	398
query51	6709	6786	6574	6574
query52	104	95	96	95
query53	357	297	295	295
query54	880	480	465	465
query55	77	77	76	76
query56	320	296	300	296
query57	1172	1041	1087	1041
query58	377	254	254	254
query59	2872	2705	2695	2695
query60	304	295	310	295
query61	98	94	123	94
query62	843	658	672	658
query63	328	297	292	292
query64	10340	2219	7427	2219
query65	3170	3096	3139	3096
query66	1270	329	331	329
query67	15675	15050	15099	15050
query68	7435	561	564	561
query69	737	470	383	383
query70	1192	1186	1045	1045
query71	557	282	279	279
query72	8288	5564	5501	5501
query73	784	324	328	324
query74	6909	5744	5646	5646
query75	5026	2723	2688	2688
query76	5206	959	954	954
query77	763	315	314	314
query78	9704	9443	8814	8814
query79	9877	541	536	536
query80	1120	506	507	506
query81	588	240	226	226
query82	804	139	134	134
query83	340	171	165	165
query84	272	85	89	85
query85	1500	320	309	309
query86	446	341	301	301
query87	3278	3079	3115	3079
query88	4935	2374	2384	2374
query89	548	386	385	385
query90	2137	196	194	194
query91	133	105	101	101
query92	66	50	54	50
query93	7449	535	526	526
query94	1429	291	291	291
query95	408	323	320	320
query96	626	269	267	267
query97	3253	3078	3029	3029
query98	221	199	197	197
query99	1578	1290	1298	1290
Total cold run time: 308921 ms
Total hot run time: 174092 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.07 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2d9572a94a62092ed54f28844363084007ddbb1d, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.03	0.04
query3	0.22	0.05	0.05
query4	1.68	0.07	0.08
query5	0.50	0.49	0.49
query6	1.14	0.73	0.73
query7	0.02	0.02	0.01
query8	0.06	0.05	0.04
query9	0.55	0.49	0.49
query10	0.55	0.55	0.56
query11	0.15	0.12	0.11
query12	0.15	0.12	0.11
query13	0.60	0.58	0.59
query14	0.75	0.78	0.79
query15	0.85	0.82	0.81
query16	0.37	0.37	0.37
query17	0.98	1.04	0.94
query18	0.23	0.22	0.20
query19	1.76	1.80	1.84
query20	0.01	0.01	0.02
query21	15.40	0.76	0.66
query22	4.11	7.13	2.27
query23	18.30	1.41	1.26
query24	2.09	0.23	0.22
query25	0.15	0.08	0.09
query26	0.31	0.22	0.22
query27	0.46	0.23	0.23
query28	13.33	1.01	1.00
query29	12.62	3.37	3.33
query30	0.26	0.06	0.06
query31	2.86	0.40	0.40
query32	3.25	0.49	0.46
query33	2.92	2.96	2.90
query34	16.83	4.34	4.40
query35	4.42	4.40	4.38
query36	0.66	0.47	0.48
query37	0.19	0.16	0.15
query38	0.15	0.14	0.14
query39	0.04	0.03	0.03
query40	0.15	0.13	0.12
query41	0.10	0.06	0.05
query42	0.06	0.06	0.06
query43	0.05	0.04	0.04
Total cold run time: 109.4 s
Total hot run time: 31.07 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 550d34d into apache:master Jul 25, 2024
28 of 31 checks passed
liaoxin01 added a commit to liaoxin01/doris that referenced this pull request Jul 26, 2024
…pache#38332)

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
dataroaring pushed a commit that referenced this pull request Jul 31, 2024
…38332)

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
liaoxin01 added a commit to liaoxin01/doris that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants