[improvement](mtmv) Not roll up when aggregate rewrite if roll up group by expr is uniform #38387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
seawinde
force-pushed
the
optimize_agg_rewrite_when_has_group_by_filter
branch
from
fc43885
to
e7daa9b
Compare
|
run buildall |
TPC-H: Total hot run time: 39836 ms |
TPC-DS: Total hot run time: 173031 ms |
ClickBench: Total hot run time: 30.69 s |
|
run buildall |
seawinde
force-pushed
the
optimize_agg_rewrite_when_has_group_by_filter
branch
from
c0d00e1
to
76826d4
Compare
|
run buildall |
TPC-H: Total hot run time: 39631 ms |
TPC-DS: Total hot run time: 174074 ms |
ClickBench: Total hot run time: 31.17 s |
…up by expr is uniform
…up by expr is uniform
seawinde
force-pushed
the
optimize_agg_rewrite_when_has_group_by_filter
branch
from
76826d4
to
85e33b0
Compare
|
run buildall |
TPC-H: Total hot run time: 42106 ms |
TPC-DS: Total hot run time: 170248 ms |
ClickBench: Total hot run time: 30.01 s |
morrySnow
reviewed
Jul 31, 2024
Comment on lines
334
to
336
| if (materializationContext instanceof SyncMaterializationContext) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
add comment for this if statement
| } | ||
|
|
||
| /** | ||
| * Check group by is equal or not after group by eliminate |
There was a problem hiding this comment.
the comment of isGroupByEqualsAfterEqualFilterEliminate is easy to understand, but not isGroupByEqualsAfterGroupByEliminate, can we improve that?
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 41561 ms |
TPC-DS: Total hot run time: 168678 ms |
ClickBench: Total hot run time: 29.88 s |
|
run buildall |
TPC-H: Total hot run time: 41321 ms |
TPC-DS: Total hot run time: 169713 ms |
ClickBench: Total hot run time: 30.05 s |
morrySnow
approved these changes
Aug 2, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
starocean999
approved these changes
Aug 2, 2024
dataroaring
pushed a commit
that referenced
this pull request
Aug 6, 2024
…up by expr is uniform (#38387) ## Proposed changes Not roll up when aggregate rewrite if roll up group by expr is uniform Such as mv name is mv3_0, and def is: ```sql CREATE MATERIALIZED VIEW mv3_0 BUILD IMMEDIATE REFRESH COMPLETE ON MANUAL DISTRIBUTED BY RANDOM BUCKETS 2 PROPERTIES ('replication_num' = '1') AS select o_orderdate, o_shippriority, o_comment, sum(o_totalprice) as sum_total, max(o_totalprice) as max_total, min(o_totalprice) as min_total, count(*) as count_all from orders group by o_orderdate, o_shippriority, o_comment; ``` query sql is as following: ```sql select o_comment, sum(o_totalprice), max(o_totalprice), min(o_totalprice), count(*) from orders where o_orderdate = '2023-12-09' and o_shippriority = 1 group by o_comment; ``` after rewrite the plan is as following, not need to add aggregate ``` PhysicalResultSink --filter((mv3_0.o_orderdate = '2023-12-09') and (mv3_0.o_shippriority = 1)) ----PhysicalOlapScan[mv3_0] ```
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Aug 6, 2024
…up by expr is uniform (apache#38387) ## Proposed changes Not roll up when aggregate rewrite if roll up group by expr is uniform Such as mv name is mv3_0, and def is: ```sql CREATE MATERIALIZED VIEW mv3_0 BUILD IMMEDIATE REFRESH COMPLETE ON MANUAL DISTRIBUTED BY RANDOM BUCKETS 2 PROPERTIES ('replication_num' = '1') AS select o_orderdate, o_shippriority, o_comment, sum(o_totalprice) as sum_total, max(o_totalprice) as max_total, min(o_totalprice) as min_total, count(*) as count_all from orders group by o_orderdate, o_shippriority, o_comment; ``` query sql is as following: ```sql select o_comment, sum(o_totalprice), max(o_totalprice), min(o_totalprice), count(*) from orders where o_orderdate = '2023-12-09' and o_shippriority = 1 group by o_comment; ``` after rewrite the plan is as following, not need to add aggregate ``` PhysicalResultSink --filter((mv3_0.o_orderdate = '2023-12-09') and (mv3_0.o_shippriority = 1)) ----PhysicalOlapScan[mv3_0] ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Not roll up when aggregate rewrite if roll up group by expr is uniform
Such as mv name is mv3_0, and def is:
CREATE MATERIALIZED VIEW mv3_0 BUILD IMMEDIATE REFRESH COMPLETE ON MANUAL DISTRIBUTED BY RANDOM BUCKETS 2 PROPERTIES ('replication_num' = '1') AS select o_orderdate, o_shippriority, o_comment, sum(o_totalprice) as sum_total, max(o_totalprice) as max_total, min(o_totalprice) as min_total, count(*) as count_all from orders group by o_orderdate, o_shippriority, o_comment;query sql is as following:
after rewrite the plan is as following, not need to add aggregate