Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix](Json) fix some cast issue #38683

Merged
merged 4 commits into from
Aug 7, 2024
Merged

[Fix](Json) fix some cast issue #38683

merged 4 commits into from
Aug 7, 2024

Conversation

eldenmoon
Copy link
Member

  1. casting to boolean/double type should consider all numeric types including int , double and boolean
  2. casting to floating point type should consisder boolean types and int types

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions github-actions bot added the doing label Aug 1, 2024
@eldenmoon
Copy link
Member Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 41330 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b06f3e3fe1ecb4d99c8304c9fd5442f2e18607ff, data reload: false

------ Round 1 ----------------------------------
q1	17695	4080	4009	4009
q2	2017	202	199	199
q3	10461	1326	1313	1313
q4	10164	776	892	776
q5	7635	2989	2942	2942
q6	220	138	138	138
q7	1019	620	609	609
q8	9435	1901	1939	1901
q9	8651	6627	6563	6563
q10	8753	3834	3805	3805
q11	434	249	253	249
q12	431	229	230	229
q13	17761	2946	2942	2942
q14	268	251	247	247
q15	523	486	493	486
q16	525	393	385	385
q17	954	918	895	895
q18	7996	7327	7193	7193
q19	1488	1213	1202	1202
q20	565	330	335	330
q21	5290	4645	4637	4637
q22	346	298	280	280
Total cold run time: 112631 ms
Total hot run time: 41330 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4026	3997	4028	3997
q2	338	230	226	226
q3	2986	3006	3099	3006
q4	1960	2010	1972	1972
q5	5609	5495	5441	5441
q6	233	130	133	130
q7	2161	1802	1841	1802
q8	3336	3414	3363	3363
q9	8708	8693	8788	8693
q10	3939	4015	3969	3969
q11	536	453	451	451
q12	774	564	604	564
q13	15206	3145	3145	3145
q14	301	270	270	270
q15	527	507	489	489
q16	466	421	414	414
q17	1770	1731	1723	1723
q18	8074	7844	7631	7631
q19	1725	1743	1706	1706
q20	2067	1874	1853	1853
q21	5756	5537	5460	5460
q22	522	462	468	462
Total cold run time: 71020 ms
Total hot run time: 56767 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 169501 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b06f3e3fe1ecb4d99c8304c9fd5442f2e18607ff, data reload: false

query1	905	371	367	367
query2	6452	1635	1669	1635
query3	6666	219	223	219
query4	20428	17286	17191	17191
query5	3633	543	533	533
query6	299	178	163	163
query7	4601	298	293	293
query8	258	202	200	200
query9	8495	2333	2306	2306
query10	426	278	267	267
query11	10453	10049	9857	9857
query12	122	93	87	87
query13	1628	382	373	373
query14	8777	7086	7945	7086
query15	208	161	168	161
query16	6756	462	435	435
query17	971	583	550	550
query18	1880	291	297	291
query19	195	144	148	144
query20	96	85	84	84
query21	205	105	99	99
query22	4229	3927	3991	3927
query23	33953	33915	33557	33557
query24	10086	3114	3121	3114
query25	689	453	443	443
query26	1691	168	158	158
query27	2986	285	290	285
query28	7413	2031	2005	2005
query29	1196	476	459	459
query30	239	158	156	156
query31	941	787	771	771
query32	108	59	59	59
query33	690	328	342	328
query34	933	505	512	505
query35	896	756	762	756
query36	1071	901	901	901
query37	180	86	86	86
query38	2959	2792	2851	2792
query39	892	821	835	821
query40	258	122	126	122
query41	48	46	49	46
query42	122	104	98	98
query43	482	410	416	410
query44	1208	728	718	718
query45	208	185	183	183
query46	1105	793	797	793
query47	1772	1682	1703	1682
query48	368	301	294	294
query49	913	438	434	434
query50	910	434	442	434
query51	6790	6714	6684	6684
query52	104	92	95	92
query53	256	184	190	184
query54	666	460	463	460
query55	76	80	77	77
query56	295	269	270	269
query57	1141	1035	1150	1035
query58	281	264	281	264
query59	2525	2394	2303	2303
query60	292	281	286	281
query61	103	94	95	94
query62	908	683	674	674
query63	213	183	176	176
query64	5651	1918	1930	1918
query65	3151	3091	3157	3091
query66	1326	342	348	342
query67	15146	14718	15130	14718
query68	6195	589	589	589
query69	763	391	348	348
query70	1116	1017	1059	1017
query71	533	283	290	283
query72	8034	2683	2488	2488
query73	995	328	326	326
query74	6004	5584	5519	5519
query75	4388	2705	2735	2705
query76	4453	1352	1376	1352
query77	752	317	317	317
query78	9482	8910	8974	8910
query79	2935	528	533	528
query80	2048	515	508	508
query81	558	219	217	217
query82	1221	138	135	135
query83	269	185	174	174
query84	264	82	81	81
query85	1430	310	314	310
query86	438	289	282	282
query87	3293	3076	3093	3076
query88	3704	2396	2393	2393
query89	411	288	281	281
query90	1974	192	188	188
query91	131	101	102	101
query92	61	51	53	51
query93	3589	619	611	611
query94	843	303	269	269
query95	379	268	272	268
query96	626	283	281	281
query97	3249	3045	3122	3045
query98	230	202	197	197
query99	1611	1311	1333	1311
Total cold run time: 272903 ms
Total hot run time: 169501 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.2 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b06f3e3fe1ecb4d99c8304c9fd5442f2e18607ff, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.04	0.03
query3	0.22	0.05	0.05
query4	1.69	0.07	0.07
query5	0.47	0.48	0.48
query6	1.14	0.72	0.71
query7	0.02	0.02	0.01
query8	0.05	0.05	0.04
query9	0.57	0.51	0.50
query10	0.58	0.56	0.57
query11	0.16	0.12	0.11
query12	0.14	0.12	0.12
query13	0.60	0.59	0.60
query14	0.77	0.80	0.80
query15	0.90	0.86	0.85
query16	0.35	0.36	0.37
query17	1.01	0.97	0.98
query18	0.21	0.21	0.21
query19	1.88	1.72	1.73
query20	0.01	0.01	0.01
query21	15.46	0.79	0.67
query22	4.34	7.06	1.54
query23	17.83	1.38	1.31
query24	2.27	0.23	0.21
query25	0.18	0.08	0.08
query26	0.32	0.21	0.21
query27	0.45	0.23	0.23
query28	13.16	1.01	0.96
query29	12.55	3.36	3.33
query30	0.25	0.06	0.06
query31	2.87	0.40	0.41
query32	3.24	0.49	0.48
query33	2.93	2.92	2.95
query34	15.44	4.25	4.24
query35	4.26	4.27	4.32
query36	0.68	0.47	0.48
query37	0.20	0.17	0.16
query38	0.16	0.14	0.16
query39	0.04	0.04	0.03
query40	0.15	0.13	0.14
query41	0.10	0.04	0.04
query42	0.05	0.04	0.05
query43	0.05	0.05	0.05
Total cold run time: 107.86 s
Total hot run time: 30.2 s

@eldenmoon
Copy link
Member Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 41358 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c3ef9adb0c80b15068184b5c2d0bb25e0737108b, data reload: false

------ Round 1 ----------------------------------
q1	17680	4115	4052	4052
q2	2014	197	195	195
q3	10470	1283	1400	1283
q4	10184	824	945	824
q5	7628	2933	2937	2933
q6	221	141	136	136
q7	1032	606	604	604
q8	9468	1793	1916	1793
q9	8498	6604	6589	6589
q10	8762	3833	3835	3833
q11	430	244	240	240
q12	438	224	225	224
q13	17766	2916	2944	2916
q14	263	243	241	241
q15	518	484	495	484
q16	531	389	382	382
q17	945	912	903	903
q18	8062	7275	7196	7196
q19	1517	1217	1206	1206
q20	555	311	323	311
q21	5296	4743	4739	4739
q22	349	274	274	274
Total cold run time: 112627 ms
Total hot run time: 41358 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4031	4009	3995	3995
q2	327	229	227	227
q3	2964	2969	3094	2969
q4	1975	1990	1990	1990
q5	5566	5436	5437	5436
q6	226	132	131	131
q7	2133	1696	1811	1696
q8	3312	3327	3323	3323
q9	8606	8608	8611	8608
q10	3995	4004	4006	4004
q11	535	433	466	433
q12	771	580	617	580
q13	14756	3139	3187	3139
q14	295	273	264	264
q15	527	494	483	483
q16	470	413	413	413
q17	1724	1715	1727	1715
q18	8172	7852	7652	7652
q19	1728	1722	1722	1722
q20	2067	1854	1852	1852
q21	5704	5502	5239	5239
q22	525	510	473	473
Total cold run time: 70409 ms
Total hot run time: 56344 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 169230 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c3ef9adb0c80b15068184b5c2d0bb25e0737108b, data reload: false

query1	910	372	365	365
query2	6466	1791	1744	1744
query3	6652	217	234	217
query4	19064	17681	17042	17042
query5	3607	510	517	510
query6	309	181	159	159
query7	4605	292	303	292
query8	245	199	191	191
query9	8523	2377	2334	2334
query10	428	271	268	268
query11	10551	9966	10035	9966
query12	123	91	89	89
query13	1643	377	368	368
query14	9352	6855	6881	6855
query15	213	159	162	159
query16	6803	432	424	424
query17	929	554	562	554
query18	1848	275	278	275
query19	191	149	151	149
query20	91	86	86	86
query21	202	100	97	97
query22	4210	4059	3953	3953
query23	33430	33635	33661	33635
query24	9444	3067	3096	3067
query25	698	426	401	401
query26	1468	160	155	155
query27	2968	276	289	276
query28	7420	2015	1982	1982
query29	1044	437	451	437
query30	235	164	158	158
query31	946	763	766	763
query32	100	55	56	55
query33	685	333	339	333
query34	942	510	546	510
query35	873	754	750	750
query36	1061	895	874	874
query37	215	86	85	85
query38	2929	2894	2784	2784
query39	876	795	815	795
query40	247	115	116	115
query41	46	45	46	45
query42	122	102	101	101
query43	462	436	460	436
query44	1174	715	732	715
query45	213	177	176	176
query46	1087	826	796	796
query47	1787	1697	1735	1697
query48	357	288	291	288
query49	858	429	432	429
query50	891	427	432	427
query51	6629	6760	6602	6602
query52	99	94	90	90
query53	257	182	182	182
query54	615	449	457	449
query55	79	76	77	76
query56	310	302	258	258
query57	1135	1045	1041	1041
query58	275	280	282	280
query59	2675	2437	2437	2437
query60	299	276	274	274
query61	111	100	94	94
query62	898	656	640	640
query63	212	183	178	178
query64	4865	1911	1922	1911
query65	3156	3112	3115	3112
query66	1229	338	358	338
query67	15465	14900	14826	14826
query68	4332	564	579	564
query69	673	378	309	309
query70	1055	1081	1050	1050
query71	387	294	288	288
query72	7279	2761	2476	2476
query73	776	330	327	327
query74	6003	5594	5645	5594
query75	3332	2729	2711	2711
query76	2189	1218	1286	1218
query77	427	376	318	318
query78	9465	8889	8928	8889
query79	2727	530	532	530
query80	1006	500	513	500
query81	562	227	229	227
query82	914	138	131	131
query83	254	175	176	175
query84	264	77	81	77
query85	1248	307	303	303
query86	456	298	312	298
query87	3268	3087	3057	3057
query88	3945	2419	2410	2410
query89	379	289	291	289
query90	1731	194	198	194
query91	131	101	101	101
query92	65	109	53	53
query93	1974	616	602	602
query94	809	298	293	293
query95	377	277	279	277
query96	609	284	279	279
query97	3242	3071	3044	3044
query98	219	209	201	201
query99	1601	1275	1313	1275
Total cold run time: 259551 ms
Total hot run time: 169230 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.63 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c3ef9adb0c80b15068184b5c2d0bb25e0737108b, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.69	0.06	0.06
query5	0.49	0.48	0.48
query6	1.13	0.72	0.71
query7	0.02	0.01	0.01
query8	0.06	0.04	0.04
query9	0.57	0.52	0.51
query10	0.55	0.54	0.55
query11	0.15	0.11	0.12
query12	0.15	0.13	0.12
query13	0.61	0.60	0.60
query14	0.77	0.79	0.80
query15	0.90	0.88	0.88
query16	0.36	0.36	0.36
query17	1.00	1.00	1.03
query18	0.22	0.22	0.21
query19	1.80	1.73	1.74
query20	0.01	0.01	0.02
query21	15.39	0.78	0.66
query22	3.82	6.33	1.96
query23	17.94	1.36	1.28
query24	2.25	0.22	0.22
query25	0.17	0.09	0.08
query26	0.32	0.21	0.22
query27	0.46	0.23	0.23
query28	13.16	1.00	0.97
query29	12.52	3.29	3.28
query30	0.25	0.06	0.06
query31	2.86	0.41	0.41
query32	3.25	0.48	0.47
query33	2.95	2.94	2.93
query34	15.45	4.24	4.27
query35	4.30	4.26	4.32
query36	0.67	0.48	0.48
query37	0.19	0.17	0.16
query38	0.17	0.16	0.15
query39	0.04	0.04	0.04
query40	0.16	0.13	0.14
query41	0.10	0.04	0.05
query42	0.06	0.04	0.05
query43	0.04	0.04	0.04
Total cold run time: 107.34 s
Total hot run time: 30.63 s

@eldenmoon
[Fix](Json) fix some cast issue
68691aa 
1. casting to boolean/double type should consider all numeric types including int , double and boolean
2. casting to floating point type should consisder boolean types and int types
@eldenmoon
fix case
5e817f0
@eldenmoon
Copy link
Member Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 41588 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5e817f0bba2d251280cd8da7bea1f766464aaa2d, data reload: false

------ Round 1 ----------------------------------
q1	18170	4198	4190	4190
q2	2419	202	202	202
q3	11508	1272	1387	1272
q4	10770	895	968	895
q5	7854	3018	2987	2987
q6	229	140	138	138
q7	1049	635	634	634
q8	9624	1733	1925	1733
q9	8432	6571	6594	6571
q10	8721	3816	3830	3816
q11	425	246	243	243
q12	406	233	226	226
q13	17745	2902	2939	2902
q14	278	247	241	241
q15	526	475	498	475
q16	502	406	387	387
q17	969	917	934	917
q18	8263	7223	7251	7223
q19	1414	1218	1210	1210
q20	570	318	325	318
q21	5262	4735	4728	4728
q22	347	280	284	280
Total cold run time: 115483 ms
Total hot run time: 41588 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4056	4034	4017	4017
q2	326	224	239	224
q3	2999	3009	3001	3001
q4	1885	1883	1866	1866
q5	5227	5253	5237	5237
q6	214	129	129	129
q7	2068	1691	1681	1681
q8	3185	3269	3246	3246
q9	8258	8281	8286	8281
q10	3748	3837	3821	3821
q11	548	445	445	445
q12	709	569	544	544
q13	13106	2947	2951	2947
q14	286	253	255	253
q15	525	476	472	472
q16	462	394	385	385
q17	1728	1712	1701	1701
q18	7699	7349	7353	7349
q19	1673	1678	1686	1678
q20	1992	1773	1747	1747
q21	5528	5253	5195	5195
q22	513	451	463	451
Total cold run time: 66735 ms
Total hot run time: 54670 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 168113 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5e817f0bba2d251280cd8da7bea1f766464aaa2d, data reload: false

query1	915	371	365	365
query2	6482	1674	1672	1672
query3	6669	216	226	216
query4	18975	17451	17390	17390
query5	4330	506	526	506
query6	289	199	182	182
query7	4593	299	296	296
query8	263	199	203	199
query9	8516	2359	2353	2353
query10	447	273	274	273
query11	10317	10021	9973	9973
query12	142	91	87	87
query13	1628	389	372	372
query14	8978	7131	6496	6496
query15	207	165	162	162
query16	7087	423	470	423
query17	949	563	538	538
query18	1901	276	278	276
query19	201	140	145	140
query20	92	86	84	84
query21	205	99	95	95
query22	4298	3913	3972	3913
query23	33656	33253	33041	33041
query24	10385	3071	2977	2977
query25	687	375	377	375
query26	1780	151	147	147
query27	3013	267	276	267
query28	7049	1961	1946	1946
query29	1349	415	411	411
query30	288	150	150	150
query31	918	768	756	756
query32	108	55	56	55
query33	695	318	315	315
query34	916	508	483	483
query35	851	738	738	738
query36	1003	876	863	863
query37	294	78	79	78
query38	2832	2815	2801	2801
query39	857	827	835	827
query40	286	113	112	112
query41	51	44	43	43
query42	122	96	101	96
query43	467	423	422	422
query44	1180	725	726	725
query45	209	179	175	175
query46	1082	799	791	791
query47	1781	1728	1706	1706
query48	358	291	287	287
query49	1181	437	421	421
query50	893	427	427	427
query51	6765	6623	6674	6623
query52	106	97	85	85
query53	252	184	181	181
query54	629	463	488	463
query55	77	75	74	74
query56	278	265	263	263
query57	1145	1068	1051	1051
query58	279	270	278	270
query59	2585	2412	2365	2365
query60	308	276	278	276
query61	99	94	101	94
query62	928	652	663	652
query63	217	179	178	178
query64	5845	1915	1930	1915
query65	3179	3080	3107	3080
query66	1447	329	338	329
query67	15306	14843	14790	14790
query68	4321	558	599	558
query69	440	296	295	295
query70	1092	1080	1082	1080
query71	408	284	274	274
query72	7046	2672	2475	2475
query73	770	333	327	327
query74	6002	5677	5789	5677
query75	3419	2727	2690	2690
query76	2451	1218	1280	1218
query77	450	333	316	316
query78	9343	8957	8803	8803
query79	1292	539	530	530
query80	993	501	506	501
query81	555	229	228	228
query82	1073	137	132	132
query83	252	176	179	176
query84	349	77	79	77
query85	1280	325	304	304
query86	385	311	288	288
query87	3261	3081	3087	3081
query88	2882	2396	2416	2396
query89	395	291	286	286
query90	1802	187	188	187
query91	126	112	143	112
query92	59	49	51	49
query93	1420	613	609	609
query94	886	286	320	286
query95	370	261	261	261
query96	602	277	274	274
query97	3241	3033	3025	3025
query98	218	204	199	199
query99	1604	1264	1297	1264
Total cold run time: 260007 ms
Total hot run time: 168113 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.53 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5e817f0bba2d251280cd8da7bea1f766464aaa2d, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.04
query3	0.22	0.05	0.05
query4	1.69	0.08	0.08
query5	0.48	0.47	0.49
query6	1.13	0.71	0.71
query7	0.02	0.01	0.02
query8	0.06	0.04	0.05
query9	0.57	0.52	0.51
query10	0.56	0.56	0.57
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.62	0.60	0.60
query14	0.78	0.79	0.78
query15	0.91	0.86	0.87
query16	0.36	0.36	0.35
query17	0.98	1.00	1.01
query18	0.23	0.21	0.21
query19	1.82	1.71	1.71
query20	0.01	0.01	0.01
query21	15.41	0.78	0.65
query22	3.94	7.12	1.80
query23	18.11	1.35	1.37
query24	2.24	0.22	0.21
query25	0.18	0.08	0.07
query26	0.31	0.22	0.21
query27	0.46	0.23	0.23
query28	13.18	0.99	0.97
query29	12.60	3.32	3.29
query30	0.26	0.06	0.05
query31	2.88	0.41	0.42
query32	3.23	0.50	0.48
query33	2.93	2.96	2.99
query34	15.43	4.26	4.25
query35	4.31	4.27	4.29
query36	0.67	0.48	0.48
query37	0.18	0.17	0.16
query38	0.15	0.15	0.14
query39	0.04	0.04	0.04
query40	0.16	0.13	0.13
query41	0.09	0.05	0.04
query42	0.06	0.05	0.05
query43	0.05	0.05	0.04
Total cold run time: 107.73 s
Total hot run time: 30.53 s

@eldenmoon eldenmoon requested a review from xiaokang August 6, 2024 06:40
xiaokang
xiaokang reviewed Aug 6, 2024
View reviewed changes
be/src/vec/functions/function_cast.h Outdated Show resolved Hide resolved
be/src/vec/functions/function_cast.h Outdated Show resolved Hide resolved
@eldenmoon
Copy link
Member Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

amorynan
amorynan approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@amorynan amorynan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

ClickBench: Total hot run time: 30.01 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5d92205d550bdbc2f92838d4c101db6a5d76a608, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.04
query4	1.68	0.07	0.08
query5	0.48	0.48	0.49
query6	1.16	0.72	0.72
query7	0.02	0.01	0.01
query8	0.06	0.05	0.05
query9	0.55	0.49	0.51
query10	0.56	0.57	0.56
query11	0.16	0.12	0.12
query12	0.15	0.12	0.12
query13	0.61	0.60	0.60
query14	0.78	0.80	0.79
query15	0.91	0.87	0.86
query16	0.35	0.35	0.37
query17	1.00	0.96	0.99
query18	0.21	0.25	0.21
query19	1.81	1.78	1.74
query20	0.02	0.01	0.01
query21	15.78	0.76	0.67
query22	4.16	8.15	1.42
query23	18.11	1.38	1.29
query24	2.29	0.21	0.22
query25	0.20	0.08	0.07
query26	0.33	0.21	0.21
query27	0.45	0.23	0.23
query28	13.17	1.00	0.96
query29	12.55	3.30	3.29
query30	0.26	0.05	0.06
query31	2.88	0.41	0.40
query32	3.25	0.49	0.49
query33	2.92	2.97	2.89
query34	15.52	4.25	4.23
query35	4.30	4.29	4.29
query36	0.67	0.49	0.47
query37	0.18	0.16	0.16
query38	0.16	0.15	0.16
query39	0.04	0.03	0.04
query40	0.16	0.14	0.12
query41	0.09	0.05	0.04
query42	0.05	0.04	0.05
query43	0.05	0.04	0.04
Total cold run time: 108.43 s
Total hot run time: 30.01 s

xiaokang
xiaokang approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 7, 2024
@xiaokang xiaokang merged commit 353c04e into apache:master Aug 7, 2024
27 of 28 checks passed
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Aug 7, 2024
@eldenmoon
[Fix](Json) fix some cast issue (apache#38683)
d543fa9 
1. casting to boolean/double type should consider all numeric types
including int , double and boolean
2. casting to floating point type should consisder boolean types and int types
@eldenmoon eldenmoon mentioned this pull request Aug 7, 2024
Merged
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Aug 7, 2024
@eldenmoon
[Fix](Json) fix some cast issue (apache#38683)
7cac459 
1. casting to boolean/double type should consider all numeric types
including int , double and boolean
2. casting to floating point type should consisder boolean types and int types
@eldenmoon eldenmoon deleted the json-cast branch August 7, 2024 11:55
yiguolei pushed a commit that referenced this pull request Aug 7, 2024
@eldenmoon
[Fix](Json) fix some cast issue (#38683) (#39025)
773008d 
#38683
@eldenmoon
Copy link
Member Author

not merge 2.0, reason 1. behavior change 2. no user encountered only in variant cases

@amorynan amorynan mentioned this pull request Aug 9, 2024
Merged
dataroaring pushed a commit that referenced this pull request Aug 9, 2024
@amorynan
[fix](outfile) fix jsonb boolean outfile (#39136)
c9cdaf8 
## Proposed changes
this pr: #38683 omit some outfile to
be fixed
Issue Number: close #xxx

<!--Describe your changes.-->
dataroaring pushed a commit that referenced this pull request Aug 9, 2024
@amorynan @dataroaring
[fix](outfile) fix jsonb boolean outfile (#39136)
1548de2 
## Proposed changes
this pr: #38683 omit some outfile to
be fixed
Issue Number: close #xxx

<!--Describe your changes.-->
dataroaring pushed a commit that referenced this pull request Aug 11, 2024
@eldenmoon @dataroaring
[Fix](Json) fix some cast issue (#38683)
b8f35a7 
1. casting to boolean/double type should consider all numeric types
including int , double and boolean
2. casting to floating point type should consisder boolean types and int types
@xiaokang xiaokang removed the doing label Aug 12, 2024
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Aug 14, 2024
@eldenmoon @wyxxxcat
[Fix](Json) fix some cast issue (apache#38683)
7f7fed3 
1. casting to boolean/double type should consider all numeric types
including int , double and boolean
2. casting to floating point type should consisder boolean types and int types
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Aug 14, 2024
@amorynan @wyxxxcat
[fix](outfile) fix jsonb boolean outfile (apache#39136)
ce5b43c 
## Proposed changes
this pr: apache#38683 omit some outfile to
be fixed
Issue Number: close #xxx

<!--Describe your changes.-->
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Sep 2, 2024
@eldenmoon
[ut](jsonb) fix expected output for cast json type
c195270 
related PR apache#38683
@eldenmoon eldenmoon mentioned this pull request Sep 2, 2024
Merged
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Sep 2, 2024
@eldenmoon
[ut](jsonb) fix expected output for cast json type
d5924de 
related PR apache#38683
eldenmoon added a commit that referenced this pull request Sep 2, 2024
@eldenmoon
[ut](jsonb) fix expected output for cast json type (#40251)
3615a36 
some expected output is not correct after #38683
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
@eldenmoon @dataroaring
[ut](jsonb) fix expected output for cast json type (#40251)
90ef0de 
some expected output is not correct after #38683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amorynan amorynan amorynan approved these changes

@xiaokang xiaokang xiaokang approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.1-merged kind/behavior-changed reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eldenmoon @doris-robot @xiaokang @amorynan @yiguolei @dataroaring