Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]use awaitility.await() in schema testcases #37817 #38869

Merged
merged 6 commits into from
Aug 21, 2024
Merged

[Enhancement]use awaitility.await() in schema testcases #37817 #38869

merged 6 commits into from
Aug 21, 2024

Conversation

Vallishp
Copy link
Contributor

@Vallishp Vallishp commented Aug 5, 2024 •
edited
Loading

Proposed changes

Issue Number: close #xxx
#37817
use awaitility.await() in schema testcases(part2)

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions github-actions bot added the doing label Aug 5, 2024
@Vallishp
Copy link
Contributor Author

Vallishp commented Aug 5, 2024

run build all

@Vallishp Vallishp changed the title [enhancement]use awaitility.await() in schema testcases #37817 [Enhancement]use awaitility.await() in schema testcases #37817 Aug 5, 2024
xinyiZzz
xinyiZzz previously approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@xinyiZzz xinyiZzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vallishp
Copy link
Contributor Author

Vallishp commented Aug 7, 2024

run buildall

@Vallishp Vallishp force-pushed the thread_sleep_schema_change_2 branch from aeab232 to d866dc8 Compare August 8, 2024 09:54
@Vallishp
Copy link
Contributor Author

Vallishp commented Aug 8, 2024

run buildall

@Vallishp
Copy link
Contributor Author

run buildall

1 similar comment
@Vallishp
Copy link
Contributor Author

run buildall

xinyiZzz
xinyiZzz approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@xinyiZzz xinyiZzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinyiZzz
Copy link
Contributor

run buildall

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Aug 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@xinyiZzz
Copy link
Contributor

run buildall

dataroaring
dataroaring approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 9c4ebeb into apache:master Aug 21, 2024
27 of 28 checks passed
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
@Vallishp @xinyiZzz @dataroaring
[Enhancement]use awaitility.await() in schema testcases #37817 (#38869)
9d7bfef 
## Proposed changes

Issue Number: close #xxx
#37817
use awaitility.await() in schema testcases(part2)

Co-authored-by: Xinyi Zou <zouxinyi02@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@xinyiZzz xinyiZzz xinyiZzz approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.3-merged doing reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vallishp @doris-robot @xinyiZzz @dataroaring