Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](window_funnel) fix wrong result of window_funnel #38954

Merged
merged 1 commit into from
Aug 12, 2024
Merged

[fix](window_funnel) fix wrong result of window_funnel #38954

merged 1 commit into from
Aug 12, 2024

Conversation

jacktengg
Copy link
Contributor

@jacktengg jacktengg commented Aug 6, 2024 •
edited
Loading

Proposed changes

Issue Number: close #xxx

Current logic of window_funnel is wrong, it cannot express the semantic of the function.

This PR re-implement the logic.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions github-actions bot added the doing label Aug 6, 2024
github-actions[bot]
github-actions bot reviewed Aug 6, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/vec/aggregate_functions/aggregate_function_window_funnel.h Show resolved Hide resolved
be/src/vec/aggregate_functions/aggregate_function_window_funnel.h Show resolved Hide resolved
be/src/vec/aggregate_functions/aggregate_function_window_funnel.h Show resolved Hide resolved
@jacktengg jacktengg force-pushed the fix-window_funnel branch 2 times, most recently from d4cddec to 935bd0b Compare August 6, 2024 09:05
@jacktengg
Copy link
Contributor Author

run buildall

github-actions[bot]
github-actions bot reviewed Aug 6, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/vec/aggregate_functions/aggregate_function_window_funnel.h Show resolved Hide resolved
be/src/vec/aggregate_functions/aggregate_function_window_funnel.h Show resolved Hide resolved
@doris-robot
Copy link

TPC-H: Total hot run time: 41880 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 935bd0b2d4dc41de9b751762ed47880110d4b100, data reload: false

------ Round 1 ----------------------------------
q1	17713	4111	4113	4111
q2	2013	206	207	206
q3	10455	1278	1311	1278
q4	10163	819	928	819
q5	7666	2981	2981	2981
q6	224	147	142	142
q7	1065	624	616	616
q8	9446	1927	1954	1927
q9	8535	6642	6631	6631
q10	8784	3854	3831	3831
q11	425	257	263	257
q12	442	232	233	232
q13	17760	2933	2929	2929
q14	275	240	244	240
q15	523	480	486	480
q16	526	418	411	411
q17	977	950	933	933
q18	8015	7273	7300	7273
q19	1505	1220	1215	1215
q20	561	331	350	331
q21	5251	4753	4818	4753
q22	355	292	284	284
Total cold run time: 112679 ms
Total hot run time: 41880 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4088	4048	4036	4036
q2	325	224	221	221
q3	2991	2996	3165	2996
q4	1990	2066	1980	1980
q5	5630	5518	5451	5451
q6	217	132	137	132
q7	2137	1895	1808	1808
q8	3287	3407	3342	3342
q9	8667	8653	8685	8653
q10	3978	3970	4009	3970
q11	564	474	463	463
q12	825	632	622	622
q13	15394	3101	3151	3101
q14	293	279	262	262
q15	526	487	498	487
q16	459	404	410	404
q17	1789	1747	1721	1721
q18	8129	7720	7689	7689
q19	1722	1745	1750	1745
q20	2075	1860	1839	1839
q21	5773	5443	5483	5443
q22	533	453	468	453
Total cold run time: 71392 ms
Total hot run time: 56818 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 169024 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 935bd0b2d4dc41de9b751762ed47880110d4b100, data reload: false

query1	915	371	363	363
query2	6489	1712	1691	1691
query3	6656	214	221	214
query4	19938	17431	17233	17233
query5	3628	520	520	520
query6	286	173	178	173
query7	4604	313	287	287
query8	248	197	194	194
query9	8503	2397	2377	2377
query10	422	270	267	267
query11	10360	10104	10060	10060
query12	116	89	92	89
query13	1631	364	373	364
query14	9580	7624	6753	6753
query15	201	165	162	162
query16	6955	456	451	451
query17	945	563	547	547
query18	1916	280	295	280
query19	189	145	141	141
query20	90	84	84	84
query21	202	100	97	97
query22	4156	3985	4087	3985
query23	33616	33788	33473	33473
query24	10371	3076	3027	3027
query25	687	412	417	412
query26	1689	158	153	153
query27	3052	289	290	289
query28	7535	2028	2016	2016
query29	1271	441	454	441
query30	237	157	160	157
query31	954	772	790	772
query32	109	63	73	63
query33	728	334	343	334
query34	942	511	517	511
query35	895	745	752	745
query36	1040	886	896	886
query37	287	82	77	77
query38	2911	2786	2739	2739
query39	863	804	824	804
query40	286	113	113	113
query41	46	44	48	44
query42	119	102	100	100
query43	494	413	427	413
query44	1209	742	729	729
query45	209	180	179	179
query46	1083	812	787	787
query47	1790	1710	1722	1710
query48	362	287	293	287
query49	992	432	419	419
query50	903	448	459	448
query51	6822	6698	6623	6623
query52	106	92	93	92
query53	258	189	192	189
query54	644	465	460	460
query55	79	77	77	77
query56	283	269	263	263
query57	1158	1064	1054	1054
query58	269	267	279	267
query59	2567	2414	2313	2313
query60	293	302	288	288
query61	117	114	112	112
query62	940	652	668	652
query63	215	185	179	179
query64	5660	1908	1856	1856
query65	3139	3084	3101	3084
query66	1303	332	352	332
query67	15308	14682	14929	14682
query68	4294	574	576	574
query69	436	307	294	294
query70	1202	1066	1135	1066
query71	411	285	290	285
query72	7003	2646	2465	2465
query73	769	335	330	330
query74	5960	5696	5643	5643
query75	3429	2733	2704	2704
query76	2321	1228	1289	1228
query77	443	308	317	308
query78	9367	9025	8806	8806
query79	1938	536	533	533
query80	1110	509	496	496
query81	527	227	219	219
query82	1042	135	131	131
query83	234	171	166	166
query84	252	79	84	79
query85	1260	318	299	299
query86	456	325	314	314
query87	3277	3087	3099	3087
query88	2943	2404	2419	2404
query89	388	295	284	284
query90	1727	200	189	189
query91	124	100	103	100
query92	55	49	50	49
query93	1992	629	608	608
query94	899	299	309	299
query95	386	274	268	268
query96	616	277	280	277
query97	3204	3071	3076	3071
query98	225	210	201	201
query99	1640	1269	1264	1264
Total cold run time: 261801 ms
Total hot run time: 169024 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.99 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 935bd0b2d4dc41de9b751762ed47880110d4b100, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.04	0.04
query3	0.23	0.05	0.05
query4	1.69	0.07	0.09
query5	0.48	0.48	0.48
query6	1.14	0.72	0.71
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.58	0.53	0.51
query10	0.57	0.57	0.57
query11	0.15	0.12	0.12
query12	0.15	0.12	0.12
query13	0.62	0.61	0.60
query14	0.78	0.79	0.80
query15	0.91	0.87	0.87
query16	0.35	0.36	0.35
query17	0.98	1.00	0.98
query18	0.22	0.22	0.21
query19	1.83	1.71	1.76
query20	0.03	0.01	0.01
query21	15.40	0.79	0.66
query22	3.68	8.99	1.02
query23	17.97	1.36	1.35
query24	2.30	0.22	0.22
query25	0.19	0.08	0.08
query26	0.31	0.22	0.21
query27	0.46	0.23	0.23
query28	13.15	1.01	0.98
query29	12.50	3.29	3.30
query30	0.27	0.06	0.06
query31	2.85	0.42	0.40
query32	3.23	0.49	0.49
query33	2.91	2.97	2.96
query34	15.43	4.29	4.30
query35	4.37	4.40	4.36
query36	0.69	0.49	0.50
query37	0.21	0.16	0.16
query38	0.17	0.16	0.16
query39	0.05	0.03	0.04
query40	0.16	0.13	0.13
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 107.4 s
Total hot run time: 29.99 s

@jacktengg jacktengg force-pushed the fix-window_funnel branch 2 times, most recently from 831fc42 to 23adf20 Compare August 6, 2024 16:14
@jacktengg
Copy link
Contributor Author

run buildall

github-actions[bot]
github-actions bot reviewed Aug 6, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/vec/aggregate_functions/aggregate_function_window_funnel.h Show resolved Hide resolved
be/src/vec/aggregate_functions/aggregate_function_window_funnel.h Show resolved Hide resolved
@doris-robot
Copy link

TPC-H: Total hot run time: 41686 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 23adf207facd08da141d395359bfd686e8143a89, data reload: false

------ Round 1 ----------------------------------
q1	18957	4251	4151	4151
q2	2837	206	200	200
q3	12389	1317	1328	1317
q4	11156	868	878	868
q5	7651	2954	2949	2949
q6	221	139	136	136
q7	1048	602	612	602
q8	9446	1906	1937	1906
q9	8356	6603	6618	6603
q10	8747	3843	3838	3838
q11	425	256	252	252
q12	410	225	224	224
q13	17763	2914	2902	2902
q14	274	240	239	239
q15	529	491	489	489
q16	521	389	400	389
q17	965	909	907	907
q18	8311	7239	7251	7239
q19	1421	1211	1228	1211
q20	578	332	346	332
q21	5243	4673	4653	4653
q22	352	279	282	279
Total cold run time: 117600 ms
Total hot run time: 41686 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4126	3999	3984	3984
q2	324	225	227	225
q3	3014	3012	2951	2951
q4	1857	1860	1872	1860
q5	5226	5221	5233	5221
q6	215	131	129	129
q7	2068	1683	1711	1683
q8	3197	3231	3253	3231
q9	8254	8199	8251	8199
q10	3731	3800	3833	3800
q11	547	442	453	442
q12	738	541	546	541
q13	8328	2943	2937	2937
q14	298	256	258	256
q15	514	474	477	474
q16	443	397	399	397
q17	1735	1715	1674	1674
q18	7860	7303	7203	7203
q19	1692	1656	1660	1656
q20	1947	1764	1732	1732
q21	5464	5257	5272	5257
q22	514	441	448	441
Total cold run time: 62092 ms
Total hot run time: 54293 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 167778 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 23adf207facd08da141d395359bfd686e8143a89, data reload: false

query1	927	367	378	367
query2	6499	1678	1622	1622
query3	6677	211	225	211
query4	20131	17331	17247	17247
query5	4275	503	516	503
query6	281	169	172	169
query7	4603	299	293	293
query8	250	201	201	201
query9	8518	2370	2350	2350
query10	437	279	270	270
query11	10628	10032	10027	10027
query12	135	88	89	88
query13	1641	379	378	378
query14	8541	6923	6068	6068
query15	202	157	164	157
query16	7114	469	446	446
query17	972	571	565	565
query18	1912	293	296	293
query19	196	152	151	151
query20	93	91	88	88
query21	209	100	100	100
query22	4225	4125	4068	4068
query23	33732	33068	32971	32971
query24	10346	3049	2992	2992
query25	708	407	409	407
query26	1787	155	153	153
query27	3000	276	280	276
query28	7015	1998	1984	1984
query29	1331	443	440	440
query30	290	152	151	151
query31	930	750	766	750
query32	105	55	56	55
query33	718	332	310	310
query34	908	474	472	472
query35	855	765	715	715
query36	1034	867	875	867
query37	305	83	82	82
query38	2889	2784	2805	2784
query39	849	817	809	809
query40	292	116	115	115
query41	48	54	43	43
query42	114	98	103	98
query43	452	422	424	422
query44	1270	730	726	726
query45	208	178	176	176
query46	1075	801	776	776
query47	1831	1764	1787	1764
query48	366	291	287	287
query49	1171	410	412	410
query50	886	430	433	430
query51	6664	6709	6533	6533
query52	102	91	94	91
query53	259	181	181	181
query54	618	449	475	449
query55	73	76	75	75
query56	282	252	252	252
query57	1166	1062	1044	1044
query58	279	263	277	263
query59	2450	2306	2288	2288
query60	292	279	270	270
query61	94	116	92	92
query62	911	675	686	675
query63	224	182	179	179
query64	5901	1913	1885	1885
query65	3131	3102	3081	3081
query66	1430	338	330	330
query67	15314	14961	14877	14877
query68	4434	562	581	562
query69	483	312	306	306
query70	1108	1078	1060	1060
query71	440	290	296	290
query72	7823	2692	2510	2510
query73	757	325	331	325
query74	5992	5690	5672	5672
query75	3776	2729	2747	2729
query76	2721	1159	1294	1159
query77	620	349	308	308
query78	9507	8886	8897	8886
query79	2887	533	532	532
query80	2202	498	494	494
query81	579	227	230	227
query82	1337	134	130	130
query83	336	170	180	170
query84	266	81	76	76
query85	1585	313	290	290
query86	479	306	310	306
query87	3365	3123	3064	3064
query88	3738	2402	2379	2379
query89	397	288	286	286
query90	1912	189	191	189
query91	129	102	104	102
query92	63	51	50	50
query93	2523	618	611	611
query94	940	296	299	296
query95	376	267	312	267
query96	604	284	275	275
query97	3237	3099	3072	3072
query98	219	195	199	195
query99	1584	1268	1271	1268
Total cold run time: 268590 ms
Total hot run time: 167778 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.88 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 23adf207facd08da141d395359bfd686e8143a89, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.07	0.06
query5	0.48	0.48	0.49
query6	1.15	0.72	0.72
query7	0.02	0.01	0.02
query8	0.04	0.04	0.04
query9	0.57	0.54	0.51
query10	0.56	0.58	0.56
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.61	0.61	0.60
query14	0.78	0.79	0.79
query15	0.92	0.85	0.86
query16	0.36	0.35	0.35
query17	0.99	1.01	1.00
query18	0.22	0.21	0.21
query19	1.84	1.73	1.73
query20	0.01	0.01	0.01
query21	15.39	0.74	0.66
query22	4.68	7.04	1.14
query23	18.11	1.37	1.32
query24	2.25	0.22	0.22
query25	0.18	0.08	0.09
query26	0.32	0.22	0.22
query27	0.46	0.22	0.23
query28	13.19	0.98	0.96
query29	12.56	3.30	3.27
query30	0.25	0.06	0.07
query31	2.88	0.40	0.41
query32	3.24	0.49	0.47
query33	2.92	2.98	2.99
query34	15.42	4.25	4.26
query35	4.32	4.28	4.31
query36	0.69	0.48	0.48
query37	0.19	0.17	0.16
query38	0.17	0.15	0.15
query39	0.04	0.04	0.04
query40	0.15	0.12	0.12
query41	0.09	0.04	0.05
query42	0.06	0.04	0.04
query43	0.05	0.04	0.04
Total cold run time: 108.5 s
Total hot run time: 29.88 s

@jacktengg jacktengg force-pushed the fix-window_funnel branch 2 times, most recently from 26beba5 to 07c1d61 Compare August 7, 2024 02:22
@jacktengg
Copy link
Contributor Author

run buildall

github-actions[bot]
github-actions bot reviewed Aug 7, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/vec/aggregate_functions/aggregate_function_window_funnel.h Show resolved Hide resolved
be/src/vec/aggregate_functions/aggregate_function_window_funnel.h Show resolved Hide resolved
@jacktengg
Copy link
Contributor Author

run performance

@jacktengg
Copy link
Contributor Author

run cloud_p1

@jacktengg
Copy link
Contributor Author

run cloud_p0

@jacktengg
Copy link
Contributor Author

run performance

@doris-robot
Copy link

TPC-H: Total hot run time: 39729 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 07c1d61a7d1f8a8e971e20b6aba28c86c9402cde, data reload: false

------ Round 1 ----------------------------------
q1	17607	4541	4318	4318
q2	2021	181	177	177
q3	10479	1153	1078	1078
q4	10144	780	720	720
q5	7509	2607	2577	2577
q6	224	145	141	141
q7	979	604	603	603
q8	9220	1934	1894	1894
q9	8925	6560	6577	6560
q10	7089	2214	2194	2194
q11	449	252	241	241
q12	504	226	230	226
q13	18668	2975	2991	2975
q14	274	231	234	231
q15	523	475	501	475
q16	499	386	382	382
q17	977	718	757	718
q18	8075	7633	7408	7408
q19	3743	919	955	919
q20	687	332	332	332
q21	5329	4546	4663	4546
q22	1131	1059	1014	1014
Total cold run time: 115056 ms
Total hot run time: 39729 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4539	4298	4306	4298
q2	375	272	283	272
q3	2853	2575	2730	2575
q4	2030	1777	1748	1748
q5	5576	5568	5549	5549
q6	228	135	133	133
q7	2121	1822	1819	1819
q8	3318	3448	3458	3448
q9	8780	8832	8857	8832
q10	3483	3337	3222	3222
q11	598	503	496	496
q12	827	694	657	657
q13	17051	3210	3173	3173
q14	313	283	285	283
q15	524	485	506	485
q16	487	446	446	446
q17	1838	1563	1500	1500
q18	8257	8084	7897	7897
q19	1746	1480	1555	1480
q20	2096	1880	1867	1867
q21	7910	5380	5381	5380
q22	1162	1104	1061	1061
Total cold run time: 76112 ms
Total hot run time: 56621 ms

@jacktengg jacktengg force-pushed the fix-window_funnel branch 2 times, most recently from 2299321 to 585c571 Compare August 8, 2024 06:49
@jacktengg
Copy link
Contributor Author

run buildall

@jacktengg
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39658 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 11001c750331be82858a8962a204c8d5eb32e1c5, data reload: false

------ Round 1 ----------------------------------
q1	17605	4420	4288	4288
q2	2018	176	169	169
q3	10499	1146	1145	1145
q4	10133	734	686	686
q5	7506	2548	2530	2530
q6	223	138	138	138
q7	976	596	587	587
q8	9216	1953	2092	1953
q9	8773	6560	6582	6560
q10	7059	2198	2207	2198
q11	452	242	240	240
q12	481	221	226	221
q13	17754	2986	2976	2976
q14	281	232	249	232
q15	526	486	486	486
q16	503	393	383	383
q17	1002	691	737	691
q18	8015	7485	7368	7368
q19	2723	942	1091	942
q20	666	318	337	318
q21	5361	4641	4531	4531
q22	1111	1047	1016	1016
Total cold run time: 112883 ms
Total hot run time: 39658 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4451	4270	4257	4257
q2	373	272	262	262
q3	2847	2621	2629	2621
q4	1918	1750	1708	1708
q5	5544	5684	5481	5481
q6	224	136	132	132
q7	2150	1701	1712	1701
q8	3325	3503	3408	3408
q9	8782	8826	8811	8811
q10	3604	3290	3299	3290
q11	612	531	495	495
q12	822	645	644	644
q13	15954	3093	3196	3093
q14	310	279	275	275
q15	533	501	481	481
q16	499	443	435	435
q17	1874	1557	1544	1544
q18	8120	7792	7736	7736
q19	2771	1527	1552	1527
q20	2128	1881	1872	1872
q21	5578	5304	5454	5304
q22	1117	1021	1023	1021
Total cold run time: 73536 ms
Total hot run time: 56098 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 201808 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 11001c750331be82858a8962a204c8d5eb32e1c5, data reload: false

query1	916	363	357	357
query2	6439	1825	1827	1825
query3	6637	205	214	205
query4	34146	23175	23027	23027
query5	3660	497	485	485
query6	257	182	174	174
query7	4581	298	297	297
query8	252	205	204	204
query9	8631	2481	2448	2448
query10	551	468	472	468
query11	17641	15027	15041	15027
query12	131	99	97	97
query13	1650	388	364	364
query14	10349	7675	7708	7675
query15	288	211	232	211
query16	7763	493	500	493
query17	1710	556	548	548
query18	1984	294	302	294
query19	192	164	154	154
query20	124	116	113	113
query21	207	109	106	106
query22	4889	4448	4487	4448
query23	34339	33776	33839	33776
query24	10520	2729	2584	2584
query25	567	379	365	365
query26	690	150	148	148
query27	2167	272	275	272
query28	5764	2037	2049	2037
query29	779	395	407	395
query30	254	170	142	142
query31	979	758	693	693
query32	93	51	50	50
query33	630	274	270	270
query34	861	453	469	453
query35	967	832	818	818
query36	1093	941	918	918
query37	133	77	78	77
query38	4342	4165	4218	4165
query39	1429	1413	1391	1391
query40	191	120	114	114
query41	43	43	45	43
query42	112	94	93	93
query43	495	469	453	453
query44	1071	719	740	719
query45	235	207	202	202
query46	1114	753	730	730
query47	1836	1774	1790	1774
query48	357	291	295	291
query49	848	429	425	425
query50	812	409	406	406
query51	6839	6677	6756	6677
query52	101	88	91	88
query53	258	185	180	180
query54	846	457	439	439
query55	75	70	72	70
query56	261	243	240	240
query57	1122	1074	1060	1060
query58	264	235	230	230
query59	3086	2791	2814	2791
query60	290	254	274	254
query61	96	93	92	92
query62	794	633	613	613
query63	218	178	184	178
query64	9204	2247	1706	1706
query65	3184	3152	3175	3152
query66	768	332	327	327
query67	15483	14881	14774	14774
query68	4508	531	548	531
query69	402	370	387	370
query70	1164	1125	1081	1081
query71	349	269	279	269
query72	17126	16627	16498	16498
query73	766	328	323	323
query74	9245	8653	8704	8653
query75	3354	2671	2690	2671
query76	2183	976	948	948
query77	473	299	307	299
query78	9637	8957	9041	8957
query79	1995	525	516	516
query80	1574	482	480	480
query81	604	230	226	226
query82	713	140	131	131
query83	233	145	149	145
query84	225	75	76	75
query85	1819	343	272	272
query86	473	265	303	265
query87	4569	4484	4543	4484
query88	3926	2480	2527	2480
query89	401	280	282	280
query90	1741	196	192	192
query91	119	93	92	92
query92	64	47	50	47
query93	2264	544	535	535
query94	824	289	304	289
query95	349	256	261	256
query96	597	275	275	275
query97	3275	3081	3040	3040
query98	206	208	193	193
query99	1641	1240	1261	1240
Total cold run time: 305427 ms
Total hot run time: 201808 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.34 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 11001c750331be82858a8962a204c8d5eb32e1c5, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.69	0.08	0.08
query5	0.50	0.50	0.49
query6	1.13	0.71	0.71
query7	0.02	0.01	0.02
query8	0.05	0.04	0.05
query9	0.55	0.49	0.48
query10	0.55	0.54	0.55
query11	0.16	0.11	0.12
query12	0.14	0.13	0.12
query13	0.59	0.59	0.58
query14	0.74	0.80	0.76
query15	0.88	0.81	0.81
query16	0.37	0.38	0.36
query17	1.03	1.03	1.04
query18	0.23	0.22	0.21
query19	1.90	1.72	1.68
query20	0.01	0.01	0.00
query21	15.40	0.75	0.66
query22	5.00	6.81	1.64
query23	18.20	1.34	1.21
query24	2.03	0.23	0.20
query25	0.16	0.09	0.07
query26	0.29	0.21	0.20
query27	0.46	0.23	0.21
query28	13.38	1.03	1.01
query29	12.64	3.37	3.37
query30	0.23	0.05	0.04
query31	2.88	0.40	0.39
query32	3.26	0.48	0.46
query33	2.87	2.95	2.86
query34	17.01	4.34	4.38
query35	4.42	4.49	4.46
query36	0.64	0.47	0.47
query37	0.18	0.16	0.16
query38	0.16	0.15	0.14
query39	0.05	0.04	0.04
query40	0.15	0.13	0.13
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.05	0.04
Total cold run time: 110.49 s
Total hot run time: 30.34 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

mrhhsg
mrhhsg approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@mrhhsg mrhhsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yiguolei yiguolei merged commit 4910a5a into apache:master Aug 12, 2024
28 of 30 checks passed
@mrhhsg mrhhsg deleted the fix-window_funnel branch August 12, 2024 08:26
jacktengg added a commit to jacktengg/incubator-doris that referenced this pull request Aug 13, 2024
@jacktengg
[fix](window_funnel) fix wrong result of window_funnel apache#38954
1d85bd3
@jacktengg jacktengg mentioned this pull request Aug 13, 2024
Merged
jacktengg added a commit to jacktengg/incubator-doris that referenced this pull request Aug 13, 2024
@jacktengg
[fix](window_funnel) fix wrong result of window_funnel apache#38954
5c18d51
jacktengg added a commit to jacktengg/incubator-doris that referenced this pull request Aug 13, 2024
@jacktengg
[fix](window_funnel) fix wrong result of window_funnel apache#38954
415ba5a
@morrySnow morrySnow mentioned this pull request Aug 13, 2024
Merged
morrySnow added a commit that referenced this pull request Aug 14, 2024
@morrySnow
[fix](compile) failed on MacOS because size_t is not uint64_t on MacOS (
b871a57 
#39296)

intro by #38954
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Aug 14, 2024
@jacktengg @wyxxxcat
[fix](window_funnel) fix wrong result of window_funnel (apache#38954)
c049a13 
## Proposed changes

Issue Number: close #xxx

Current logic of `window_funnel` is wrong, it cannot express the
semantic of the function.

This PR re-implement the logic.
wyxxxcat pushed a commit to wyxxxcat/doris that referenced this pull request Aug 14, 2024
@morrySnow @wyxxxcat
[fix](compile) failed on MacOS because size_t is not uint64_t on MacOS (
3bd2d58 
apache#39296)

intro by apache#38954
jacktengg added a commit to jacktengg/incubator-doris that referenced this pull request Aug 15, 2024
@jacktengg
[fix](window_funnel) fix wrong result of window_funnel apache#38954
480e1c2
yiguolei pushed a commit that referenced this pull request Aug 16, 2024
@jacktengg
[fix](window_funnel) fix wrong result of window_funnel #38954 (#39270)
021678c 
## Proposed changes

BP #38954
dataroaring pushed a commit that referenced this pull request Aug 17, 2024
@jacktengg @dataroaring
[fix](window_funnel) fix wrong result of window_funnel (#38954)
26b494f 
## Proposed changes

Issue Number: close #xxx

Current logic of `window_funnel` is wrong, it cannot express the
semantic of the function.

This PR re-implement the logic.
dataroaring pushed a commit that referenced this pull request Aug 17, 2024
@morrySnow @dataroaring
[fix](compile) failed on MacOS because size_t is not uint64_t on MacOS (
3de7a76 
#39296)

intro by #38954
jacktengg added a commit to jacktengg/incubator-doris that referenced this pull request Aug 27, 2024
@jacktengg
[fix](window_funnel) fix wrong result of window_funnel apache#38954
50586c0
@jacktengg jacktengg mentioned this pull request Aug 27, 2024
Open
cambyzju added a commit to cambyzju/incubator-doris that referenced this pull request Sep 12, 2024
@cambyzju
Revert "[fix](window_funnel) fix wrong result of window_funnel apache…
1bdac0f 
…#38954 (apache#39270)"

This reverts commit 021678c.
cambyzju pushed a commit to cambyzju/incubator-doris that referenced this pull request Sep 12, 2024
@morrySnow @cambyzju
[fix](compile) failed on MacOS because size_t is not uint64_t on MacOS (
241b709 
apache#39296)

intro by apache#38954
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@yiguolei yiguolei yiguolei approved these changes

@mrhhsg mrhhsg mrhhsg approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.x dev/2.1.6-merged dev/3.0.2-merged doing reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jacktengg @doris-robot @mrhhsg @yiguolei @gavinchou @dataroaring