[improve](partition_topn) Add partition threshold check in hash table to control partition nums #39057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
zhangstar333
force-pushed
the
add_session_partition_topn
branch
from
647345b
to
2b39316
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40163 ms |
TPC-H: Total hot run time: 39465 ms |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
zhangstar333
force-pushed
the
add_session_partition_topn
branch
from
9daad35
to
6a24f85
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40128 ms |
TPC-DS: Total hot run time: 189905 ms |
ClickBench: Total hot run time: 29.96 s |
zhangstar333
force-pushed
the
add_session_partition_topn
branch
2 times, most recently
from
345ebcd
to
8259137
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
zhangstar333
force-pushed
the
add_session_partition_topn
branch
from
8259137
to
ad301a8
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
zhangstar333
changed the title
|
clang-tidy review says "All clean, LGTM! 👍" |
zhangstar333
dismissed stale reviews from BiteTheDDDDt and HappenLee
via
5b9de17
zhangstar333
force-pushed
the
add_session_partition_topn
branch
from
e1ae016
to
5b9de17
Compare
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41771 ms |
TPC-DS: Total hot run time: 198489 ms |
ClickBench: Total hot run time: 33.93 s |
BiteTheDDDDt
approved these changes
Sep 20, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
dataroaring
pushed a commit
that referenced
this pull request
Oct 9, 2024
… to control partition nums (#39057) ## Proposed changes 1. Add a session variable to control partition_topn partition threshold 2. move the partition threshold check at emplace data to hash table to control partition nums, so get check every rows. this could improve some bad case about 50%+ performance improvement， and some better case before, after move the check in hash table, maybe have performance degradation almost 10%, I think this is within the acceptable result。 <!--Describe your changes.-->
zhangstar333
added a commit
to zhangstar333/incubator-doris
that referenced
this pull request
Oct 16, 2024
… to control partition nums (apache#39057) 1. Add a session variable to control partition_topn partition threshold 2. move the partition threshold check at emplace data to hash table to control partition nums, so get check every rows. this could improve some bad case about 50%+ performance improvement， and some better case before, after move the check in hash table, maybe have performance degradation almost 10%, I think this is within the acceptable result。 <!--Describe your changes.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
this could improve some bad case about 50%+ performance improvement， and some better case before, after move the check in hash table, maybe have performance degradation almost 10%, I think this is within the acceptable result。