Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](Export) Export delete multiple times when specify the delete_existing_files property () #39304

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

BePPPower
Copy link
Contributor

bp: #38400

When the Export statement specifies the delete_existing_files property, each Outfile statement generated by the Export will carry this property. This causes each Outfile statement to delete existing files, so only the result of the last Outfile statement will be retained.

So, we add a rpc method which can delete existing files for Export statement and the Outfile statements generated by the Export will not carry delete_existing_files property any more.

Proposed changes

Issue Number: close #xxx

…xisting_files` property (apache#38400)

When the `Export` statement specifies the `delete_existing_files`
property, each `Outfile` statement generated by the `Export` will carry
this property. This causes each `Outfile` statement to delete existing
files, so only the result of the last Outfile statement will be
retained.

So, we add a rpc method which can delete existing files for `Export`
statement and the `Outfile` statements generated by the `Export` will
not carry `delete_existing_files` property any more.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@BePPPower
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.52% (9317/25512)
Line Coverage: 28.01% (76323/272497)
Region Coverage: 26.81% (39202/146200)
Branch Coverage: 23.54% (19902/84530)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f2e4e5eae071b70e9135b23c171d072e18b62fdd_f2e4e5eae071b70e9135b23c171d072e18b62fdd/report/index.html

@yiguolei yiguolei merged commit 187461e into apache:branch-2.1 Aug 13, 2024
20 of 22 checks passed
@yiguolei yiguolei mentioned this pull request Sep 5, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants