Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore](cloud) log the num segments of rowset meta #39544

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Aug 19, 2024

No description provided.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@w41ter
Copy link
Contributor Author

w41ter commented Aug 19, 2024

run buildall

dataroaring
dataroaring previously approved these changes Aug 19, 2024
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 19, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@w41ter
Copy link
Contributor Author

w41ter commented Aug 20, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 20, 2024
@w41ter
Copy link
Contributor Author

w41ter commented Aug 20, 2024

run buildall

dataroaring
dataroaring previously approved these changes Aug 20, 2024
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 20, 2024
@@ -1269,6 +1270,12 @@ void commit_txn_immediately(
max_size = v.ByteSizeLong();
max_idx = i;
}
if (v.num_segments() >= 100) {
Copy link
Contributor

@gavinchou gavinchou Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

record a max_num_seg and log it at line 1280

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 21, 2024
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@w41ter
Copy link
Contributor Author

w41ter commented Aug 21, 2024

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 21, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit 6d8b756 into apache:master Aug 22, 2024
29 of 32 checks passed
@w41ter w41ter deleted the log_num_segments branch August 22, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.2-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants