[optimize](table stat) Reduce lock when get table statistics #39807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
github-actions
bot
added
the
area/planner
liutang123
reviewed
Aug 23, 2024
| @@ -148,6 +150,8 @@ public enum OlapTableState { | |||
|
|
|||
| private TableProperty tableProperty; | |||
|
|
|||
| private volatile Statistics statistics = new Statistics(); | |||
There was a problem hiding this comment.
When fe restarted, the statistics has not inited and the dataSize will be 0. At this point, createTable behavior will not be restricted.
Should we deal with this situation?
There was a problem hiding this comment.
As we discuss, if statistics is not inited, we should try init it first.
But I think we may first implement this logic in master branch.
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: this pr will pick part of #35457 to reduce the potential of dead lock with following example:
This deadlock situation usually occurs when it is a fair lock. So we should optimize the read lock.
This PR places the updates of table statistics(such as data size/replica count) in the Table Stats Thread to be done on a scheduled basis, so that there is no need to add a read lock when obtaining table statistics.