Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix](Variant) use uinque id to access column reader #39841

Merged
merged 1 commit into from
Aug 28, 2024
Merged

[Fix](Variant) use uinque id to access column reader #39841

merged 1 commit into from
Aug 28, 2024

Conversation

eldenmoon
Copy link
Member

Currently, the variant type is not supported rename column because its column reader accesses columns by path rather than by unique ID. If the name is modified, the column reader may not locate the column correctly.So we should access by unique id

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@eldenmoon
Copy link
Member Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 37852 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2f1d8fd59f0ebbc724afdca262adbb84543fc676, data reload: false

------ Round 1 ----------------------------------
q1	17624	4469	4326	4326
q2	2034	188	176	176
q3	11622	986	1136	986
q4	10514	740	727	727
q5	7756	2869	2818	2818
q6	224	142	142	142
q7	981	612	616	612
q8	9314	2089	2113	2089
q9	7177	6547	6565	6547
q10	7000	2244	2213	2213
q11	475	248	253	248
q12	392	226	223	223
q13	18771	3034	3047	3034
q14	297	234	244	234
q15	542	488	494	488
q16	502	393	396	393
q17	999	612	673	612
q18	7466	6839	6901	6839
q19	1399	1041	969	969
q20	719	344	336	336
q21	3920	2832	2847	2832
q22	1099	1025	1008	1008
Total cold run time: 110827 ms
Total hot run time: 37852 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4527	4347	4317	4317
q2	391	262	268	262
q3	2886	2659	2672	2659
q4	1919	1655	1603	1603
q5	5621	5674	5746	5674
q6	223	135	134	134
q7	2268	1870	1839	1839
q8	3333	3434	3487	3434
q9	8876	8859	8831	8831
q10	3546	3401	3357	3357
q11	629	507	507	507
q12	837	668	652	652
q13	15424	3178	3286	3178
q14	342	293	291	291
q15	534	499	494	494
q16	504	460	453	453
q17	1875	1552	1564	1552
q18	8280	7835	7789	7789
q19	1755	1646	1520	1520
q20	2151	1921	1900	1900
q21	5961	5462	5483	5462
q22	1135	1033	1025	1025
Total cold run time: 73017 ms
Total hot run time: 56933 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191512 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2f1d8fd59f0ebbc724afdca262adbb84543fc676, data reload: false

query1	1253	898	871	871
query2	6327	1943	1890	1890
query3	10616	3887	3893	3887
query4	59952	26616	23262	23262
query5	5408	506	511	506
query6	415	163	162	162
query7	5755	297	290	290
query8	306	214	217	214
query9	8618	2502	2504	2502
query10	495	275	278	275
query11	16162	14946	15420	14946
query12	166	105	105	105
query13	1524	410	383	383
query14	11068	7404	7329	7329
query15	238	178	166	166
query16	7467	490	442	442
query17	1092	574	603	574
query18	1772	335	296	296
query19	303	161	157	157
query20	121	111	111	111
query21	208	106	103	103
query22	4542	4446	4570	4446
query23	34434	33452	33172	33172
query24	5965	2883	2900	2883
query25	548	405	400	400
query26	685	163	157	157
query27	1782	282	287	282
query28	3898	2063	2049	2049
query29	669	428	422	422
query30	240	154	154	154
query31	984	781	763	763
query32	89	55	51	51
query33	423	293	275	275
query34	843	465	481	465
query35	858	763	716	716
query36	1050	943	943	943
query37	148	87	86	86
query38	3883	3866	3745	3745
query39	1438	1385	1407	1385
query40	203	115	112	112
query41	46	46	43	43
query42	113	99	96	96
query43	511	458	459	458
query44	1120	749	760	749
query45	192	166	159	159
query46	1086	750	724	724
query47	1889	1769	1810	1769
query48	363	301	297	297
query49	747	424	430	424
query50	844	408	416	408
query51	7173	6981	6941	6941
query52	104	89	85	85
query53	262	177	176	176
query54	558	460	451	451
query55	79	75	76	75
query56	280	249	248	248
query57	1189	1064	1082	1064
query58	212	227	229	227
query59	3068	2760	2835	2760
query60	288	263	276	263
query61	113	125	97	97
query62	760	676	632	632
query63	220	183	185	183
query64	4278	2275	1736	1736
query65	3205	3195	3127	3127
query66	657	327	352	327
query67	15513	15310	15440	15310
query68	3361	594	571	571
query69	398	282	337	282
query70	1179	1176	1039	1039
query71	362	277	276	276
query72	2681	2098	2074	2074
query73	709	319	320	319
query74	9091	8757	8833	8757
query75	3345	2671	2748	2671
query76	1463	1018	970	970
query77	533	331	316	316
query78	9728	9143	10310	9143
query79	1018	559	546	546
query80	692	519	517	517
query81	463	229	222	222
query82	296	133	136	133
query83	175	151	151	151
query84	252	75	72	72
query85	716	287	287	287
query86	331	297	297	297
query87	4336	4284	4297	4284
query88	3303	2296	2291	2291
query89	383	281	295	281
query90	2004	195	195	195
query91	125	98	102	98
query92	64	53	54	53
query93	1079	530	529	529
query94	746	304	302	302
query95	354	266	266	266
query96	587	272	270	270
query97	3201	3037	3061	3037
query98	238	210	206	206
query99	1490	1251	1278	1251
Total cold run time: 301521 ms
Total hot run time: 191512 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.36 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2f1d8fd59f0ebbc724afdca262adbb84543fc676, data reload: false

query1	0.05	0.04	0.04
query2	0.09	0.04	0.04
query3	0.22	0.06	0.05
query4	1.66	0.08	0.08
query5	0.50	0.50	0.49
query6	1.12	0.71	0.73
query7	0.02	0.02	0.02
query8	0.06	0.04	0.04
query9	0.54	0.49	0.48
query10	0.53	0.55	0.53
query11	0.16	0.12	0.11
query12	0.15	0.12	0.12
query13	0.60	0.59	0.58
query14	0.78	0.79	0.78
query15	0.84	0.81	0.81
query16	0.38	0.36	0.35
query17	0.98	1.00	0.98
query18	0.22	0.20	0.20
query19	1.94	1.88	1.77
query20	0.01	0.02	0.01
query21	15.41	0.67	0.66
query22	4.01	7.59	1.61
query23	18.31	1.36	1.28
query24	2.14	0.22	0.22
query25	0.14	0.08	0.08
query26	0.27	0.18	0.18
query27	0.08	0.08	0.08
query28	13.20	1.02	1.00
query29	12.67	3.28	3.30
query30	0.24	0.07	0.06
query31	2.87	0.41	0.39
query32	3.24	0.47	0.47
query33	2.93	3.03	3.05
query34	17.02	4.39	4.36
query35	4.37	4.44	4.40
query36	0.65	0.50	0.47
query37	0.19	0.16	0.15
query38	0.16	0.15	0.15
query39	0.05	0.04	0.04
query40	0.17	0.13	0.13
query41	0.10	0.05	0.05
query42	0.06	0.04	0.04
query43	0.05	0.04	0.05
Total cold run time: 109.18 s
Total hot run time: 30.36 s

xiaokang
xiaokang previously approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

be/src/olap/rowset/segment_v2/hierarchical_data_reader.cpp Outdated Show resolved Hide resolved
be/src/olap/field.h Outdated Show resolved Hide resolved
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@eldenmoon
Copy link
Member Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 38847 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3c05735810a444057938265dd52bbe0b7abf44b7, data reload: false

------ Round 1 ----------------------------------
q1	18060	4590	4583	4583
q2	2519	195	180	180
q3	11181	1170	1219	1170
q4	10483	772	717	717
q5	7768	2964	2888	2888
q6	225	139	146	139
q7	994	633	618	618
q8	9680	2129	2079	2079
q9	7167	6560	6582	6560
q10	7000	2304	2217	2217
q11	449	250	254	250
q12	399	226	221	221
q13	17771	3003	3033	3003
q14	271	229	239	229
q15	516	490	499	490
q16	492	387	395	387
q17	989	708	710	708
q18	7479	6904	6973	6904
q19	1392	1071	1058	1058
q20	704	340	336	336
q21	3896	3174	3092	3092
q22	1122	1018	1035	1018
Total cold run time: 110557 ms
Total hot run time: 38847 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4390	4280	4300	4280
q2	375	291	275	275
q3	2889	2638	2633	2633
q4	1894	1664	1654	1654
q5	5469	5424	5416	5416
q6	218	130	131	130
q7	2139	1740	1739	1739
q8	3248	3407	3343	3343
q9	8462	8432	8486	8432
q10	3475	3241	3174	3174
q11	598	509	500	500
q12	790	612	619	612
q13	8693	3094	3064	3064
q14	319	285	286	285
q15	530	494	483	483
q16	480	441	426	426
q17	1815	1498	1478	1478
q18	7831	7419	7661	7419
q19	1671	1604	1568	1568
q20	2078	1858	1843	1843
q21	5430	5182	5356	5182
q22	1134	1026	1043	1026
Total cold run time: 63928 ms
Total hot run time: 54962 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187233 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3c05735810a444057938265dd52bbe0b7abf44b7, data reload: false

query1	915	380	378	378
query2	6448	2077	1876	1876
query3	6639	211	217	211
query4	33948	23188	23236	23188
query5	4166	508	524	508
query6	260	162	172	162
query7	4585	305	296	296
query8	250	213	200	200
query9	8499	2500	2482	2482
query10	436	271	279	271
query11	15821	15037	15055	15037
query12	150	98	97	97
query13	1629	383	378	378
query14	9514	7063	7141	7063
query15	269	164	175	164
query16	8090	453	491	453
query17	1594	578	563	563
query18	2134	296	298	296
query19	223	151	148	148
query20	117	112	111	111
query21	213	105	104	104
query22	4444	4149	4074	4074
query23	34073	33703	33762	33703
query24	11320	2851	2793	2793
query25	622	386	402	386
query26	1387	157	169	157
query27	2874	282	279	279
query28	7665	2088	2053	2053
query29	858	416	400	400
query30	306	158	150	150
query31	1008	788	761	761
query32	102	56	57	56
query33	755	285	276	276
query34	989	478	483	478
query35	850	726	727	726
query36	1101	941	929	929
query37	166	85	82	82
query38	3983	3915	3816	3816
query39	1450	1392	1395	1392
query40	274	120	115	115
query41	47	70	46	46
query42	117	96	98	96
query43	512	484	463	463
query44	1242	745	753	745
query45	201	170	175	170
query46	1112	748	742	742
query47	1886	1784	1799	1784
query48	372	289	294	289
query49	1098	413	426	413
query50	804	424	410	410
query51	7268	7013	7056	7013
query52	98	88	89	88
query53	254	180	181	180
query54	942	454	455	454
query55	77	77	81	77
query56	280	249	261	249
query57	1211	1062	1043	1043
query58	243	221	239	221
query59	2976	2748	2736	2736
query60	300	260	300	260
query61	97	101	99	99
query62	834	648	677	648
query63	215	182	179	179
query64	6472	2267	1710	1710
query65	3232	3407	3154	3154
query66	1357	359	341	341
query67	15496	15306	15289	15289
query68	4070	549	567	549
query69	402	272	286	272
query70	1195	1086	1122	1086
query71	347	270	275	270
query72	6421	2347	2042	2042
query73	766	325	329	325
query74	9152	8883	8885	8883
query75	3400	2661	2711	2661
query76	2241	1047	985	985
query77	476	309	324	309
query78	9649	8935	9058	8935
query79	1027	550	545	545
query80	692	493	492	492
query81	451	238	229	229
query82	231	137	140	137
query83	177	150	154	150
query84	217	76	79	76
query85	738	287	282	282
query86	304	309	309	309
query87	4383	4263	4301	4263
query88	3017	2353	2352	2352
query89	374	296	285	285
query90	1825	204	195	195
query91	125	100	97	97
query92	64	53	50	50
query93	1030	537	539	537
query94	803	304	294	294
query95	362	271	271	271
query96	592	275	275	275
query97	3224	3085	3102	3085
query98	213	210	212	210
query99	1500	1271	1289	1271
Total cold run time: 288338 ms
Total hot run time: 187233 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.59 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3c05735810a444057938265dd52bbe0b7abf44b7, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.05	0.06
query4	1.66	0.08	0.07
query5	0.50	0.51	0.51
query6	1.14	0.73	0.74
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.54	0.50	0.50
query10	0.55	0.55	0.55
query11	0.15	0.12	0.12
query12	0.15	0.12	0.12
query13	0.61	0.58	0.58
query14	0.76	0.80	0.79
query15	0.88	0.82	0.81
query16	0.38	0.37	0.36
query17	1.04	1.05	1.01
query18	0.21	0.20	0.21
query19	1.93	1.76	1.81
query20	0.02	0.01	0.01
query21	15.40	0.67	0.66
query22	4.00	6.62	2.52
query23	18.27	1.33	1.33
query24	2.10	0.26	0.23
query25	0.16	0.09	0.08
query26	0.27	0.19	0.19
query27	0.09	0.08	0.08
query28	13.19	1.03	1.00
query29	12.64	3.38	3.36
query30	0.23	0.05	0.06
query31	2.89	0.42	0.40
query32	3.23	0.47	0.48
query33	2.95	3.03	3.01
query34	16.93	4.41	4.44
query35	4.49	4.41	4.50
query36	0.66	0.48	0.49
query37	0.19	0.16	0.16
query38	0.16	0.15	0.15
query39	0.05	0.04	0.04
query40	0.16	0.12	0.12
query41	0.10	0.05	0.05
query42	0.05	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.21 s
Total hot run time: 31.59 s

xiaokang
xiaokang previously approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@eldenmoon
[Fix](Variant) use uinque id to access column reader
123a583 
Currently, the variant type is not supported because its column reader accesses
columns by path rather than by unique ID. If the name is modified, the column
reader may not locate the column correctly.So we forbid it temporaryly.
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 27, 2024
@eldenmoon
Copy link
Member Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 38472 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 123a58375b6c6dc57850ebed5dd9e8c12c4a6c74, data reload: false

------ Round 1 ----------------------------------
q1	17611	4663	4390	4390
q2	2023	190	175	175
q3	11448	997	1115	997
q4	10510	744	681	681
q5	7784	2855	2870	2855
q6	234	141	137	137
q7	977	636	623	623
q8	9333	2100	2116	2100
q9	7360	6590	6609	6590
q10	7017	2181	2180	2180
q11	461	258	249	249
q12	399	221	225	221
q13	17773	3048	3059	3048
q14	300	233	239	233
q15	518	489	504	489
q16	516	401	400	400
q17	1017	691	696	691
q18	7419	6930	6877	6877
q19	1406	1111	1141	1111
q20	676	342	337	337
q21	4069	3282	3104	3104
q22	1117	1031	984	984
Total cold run time: 109968 ms
Total hot run time: 38472 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4412	4340	4311	4311
q2	379	261	272	261
q3	2897	2545	2691	2545
q4	1958	1693	1657	1657
q5	5651	5691	5779	5691
q6	228	138	139	138
q7	2276	1822	1805	1805
q8	3328	3497	3547	3497
q9	8892	8904	8830	8830
q10	3614	3410	3405	3405
q11	598	515	509	509
q12	822	680	685	680
q13	15881	3166	3252	3166
q14	325	310	300	300
q15	539	497	487	487
q16	475	478	459	459
q17	1853	1562	1561	1561
q18	8213	7795	7981	7795
q19	1761	1743	1464	1464
q20	2147	1922	1926	1922
q21	5721	5512	5587	5512
q22	1196	1020	1018	1018
Total cold run time: 73166 ms
Total hot run time: 57013 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192911 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 123a58375b6c6dc57850ebed5dd9e8c12c4a6c74, data reload: false

query1	1277	888	867	867
query2	6281	2002	1966	1966
query3	10618	4178	3911	3911
query4	59936	24463	23261	23261
query5	5388	503	499	499
query6	403	160	181	160
query7	5775	300	304	300
query8	296	211	215	211
query9	9084	2483	2473	2473
query10	499	273	266	266
query11	16168	15224	15239	15224
query12	152	105	104	104
query13	1573	393	397	393
query14	11293	7118	7666	7118
query15	244	177	177	177
query16	7390	475	464	464
query17	1146	587	601	587
query18	1619	316	309	309
query19	296	169	157	157
query20	123	118	118	118
query21	211	104	103	103
query22	4530	4307	4309	4307
query23	34582	33818	33805	33805
query24	5979	2917	2894	2894
query25	511	398	401	398
query26	677	159	159	159
query27	1767	289	292	289
query28	3921	2101	2077	2077
query29	664	434	424	424
query30	236	155	150	150
query31	893	778	741	741
query32	88	54	64	54
query33	519	305	302	302
query34	892	468	478	468
query35	846	736	731	731
query36	1096	934	943	934
query37	139	86	82	82
query38	4053	3900	3972	3900
query39	1451	1412	1415	1412
query40	199	117	120	117
query41	47	51	46	46
query42	115	99	97	97
query43	530	491	479	479
query44	1121	766	776	766
query45	204	166	169	166
query46	1110	766	780	766
query47	1891	1796	1859	1796
query48	380	316	303	303
query49	781	442	448	442
query50	832	430	420	420
query51	7269	6993	7010	6993
query52	100	87	94	87
query53	255	184	184	184
query54	580	459	459	459
query55	82	77	75	75
query56	301	271	261	261
query57	1202	1058	1091	1058
query58	249	238	237	237
query59	3111	3067	2921	2921
query60	295	274	271	271
query61	97	98	109	98
query62	759	641	649	641
query63	216	183	180	180
query64	4288	2254	1771	1771
query65	3244	3186	3160	3160
query66	658	336	347	336
query67	15480	15445	15103	15103
query68	4852	568	565	565
query69	613	393	293	293
query70	1127	1103	1053	1053
query71	523	275	279	275
query72	2729	2128	2082	2082
query73	754	331	328	328
query74	9257	8785	8908	8785
query75	3420	2659	2714	2659
query76	3209	1047	1008	1008
query77	637	342	326	326
query78	9694	9167	9059	9059
query79	1099	559	542	542
query80	824	496	523	496
query81	564	228	232	228
query82	295	138	136	136
query83	184	151	148	148
query84	265	120	82	82
query85	823	288	273	273
query86	379	281	304	281
query87	4420	4385	4325	4325
query88	2969	2399	2409	2399
query89	397	298	284	284
query90	2018	200	200	200
query91	124	103	109	103
query92	59	50	54	50
query93	1810	544	544	544
query94	730	302	286	286
query95	356	264	302	264
query96	605	278	275	275
query97	3278	3075	3089	3075
query98	221	194	196	194
query99	1606	1282	1265	1265
Total cold run time: 307853 ms
Total hot run time: 192911 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.71 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 123a58375b6c6dc57850ebed5dd9e8c12c4a6c74, data reload: false

query1	0.05	0.05	0.04
query2	0.08	0.04	0.05
query3	0.23	0.05	0.05
query4	1.67	0.07	0.08
query5	0.51	0.48	0.48
query6	1.13	0.74	0.74
query7	0.02	0.01	0.02
query8	0.06	0.05	0.04
query9	0.55	0.48	0.49
query10	0.55	0.54	0.53
query11	0.15	0.11	0.12
query12	0.16	0.12	0.13
query13	0.62	0.59	0.60
query14	0.77	0.80	0.78
query15	0.86	0.82	0.81
query16	0.38	0.38	0.38
query17	1.06	1.06	0.99
query18	0.21	0.19	0.21
query19	1.84	1.72	1.72
query20	0.02	0.01	0.01
query21	15.43	0.68	0.67
query22	4.81	6.78	1.92
query23	18.33	1.45	1.30
query24	2.05	0.24	0.20
query25	0.15	0.07	0.09
query26	0.27	0.17	0.17
query27	0.08	0.07	0.07
query28	13.28	1.04	0.99
query29	12.63	3.34	3.30
query30	0.24	0.06	0.06
query31	2.86	0.41	0.39
query32	3.25	0.48	0.47
query33	2.99	3.01	3.04
query34	17.14	4.42	4.44
query35	4.44	4.42	4.45
query36	0.65	0.47	0.49
query37	0.18	0.16	0.15
query38	0.15	0.15	0.14
query39	0.05	0.04	0.04
query40	0.16	0.13	0.13
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.04	0.04	0.05
Total cold run time: 110.26 s
Total hot run time: 30.71 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

amorynan
amorynan approved these changes Aug 28, 2024
View reviewed changes
Copy link
Contributor

@amorynan amorynan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldenmoon eldenmoon merged commit 4a0c15a into apache:master Aug 28, 2024
28 of 31 checks passed
@eldenmoon eldenmoon deleted the forbit-rename-var branch August 28, 2024 13:20
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Sep 2, 2024
@eldenmoon
[Fix](Variant) use uinque id to access column reader (apache#39841)
7b1ced6 
Currently, the variant type is not supported rename column because its
column reader accesses columns by path rather than by unique ID. If the
name is modified, the column reader may not locate the column
correctly.So we should access by unique id
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Sep 2, 2024
@eldenmoon
[Fix](Variant) use uinque id to access column reader (apache#39841)
fc653a8 
Currently, the variant type is not supported rename column because its
column reader accesses columns by path rather than by unique ID. If the
name is modified, the column reader may not locate the column
correctly.So we should access by unique id
@eldenmoon eldenmoon mentioned this pull request Sep 3, 2024
Merged
@eldenmoon eldenmoon mentioned this pull request Sep 3, 2024
Merged
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Sep 3, 2024
@eldenmoon
[Fix](Variant) use uinque id to access column reader (apache#39841)
0b62261 
Currently, the variant type is not supported rename column because its
column reader accesses columns by path rather than by unique ID. If the
name is modified, the column reader may not locate the column
correctly.So we should access by unique id
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Sep 3, 2024
@eldenmoon
[Fix](Variant) use uinque id to access column reader (apache#39841)
c546d84 
Currently, the variant type is not supported rename column because its
column reader accesses columns by path rather than by unique ID. If the
name is modified, the column reader may not locate the column
correctly.So we should access by unique id
eldenmoon added a commit that referenced this pull request Sep 3, 2024
@eldenmoon
[pick](Variant) pick nested impl and unique_id fix (#40320)
839f9b8 
#39841
#39022
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Sep 4, 2024
@eldenmoon
[Fix](Variant) use uinque id to access column reader (apache#39841)
e9025fd 
Currently, the variant type is not supported rename column because its
column reader accesses columns by path rather than by unique ID. If the
name is modified, the column reader may not locate the column
correctly.So we should access by unique id
eldenmoon added a commit that referenced this pull request Sep 9, 2024
@eldenmoon
[Fix](Variant) use uinque id to access column reader (#39841) (#40269)
f69063e 
#39841
#40295
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qidaye qidaye qidaye approved these changes

@amorynan amorynan amorynan approved these changes

@xiaokang xiaokang xiaokang left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.2-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@eldenmoon @doris-robot @xiaokang @amorynan @qidaye @gavinchou @dataroaring