Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement](Group commit) Remove the redundant iscloud parameter #40120

Merged
merged 2 commits into from
Sep 3, 2024
Merged

[Enhancement](Group commit) Remove the redundant iscloud parameter #40120

merged 2 commits into from
Sep 3, 2024

Conversation

Yukang-Lian
Copy link
Collaborator

Proposed changes

isCloud parameter is redundant because we can use Config.isCloud() to replace it.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Yukang-Lian
Copy link
Collaborator Author

run buildall

dataroaring
dataroaring previously approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

mymeiyi
mymeiyi reviewed Aug 29, 2024
View reviewed changes
fe/fe-core/src/main/java/org/apache/doris/cloud/planner/CloudGroupCommitPlanner.java Outdated
@@ -46,7 +46,7 @@ public CloudGroupCommitPlanner(Database db, OlapTable table, List<String> target
protected void selectBackends(ConnectContext ctx) throws DdlException {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same as parent class

@doris-robot
Copy link

TPC-H: Total hot run time: 38535 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 082925163bc821876cb21f1b89c3c6ef82ad4a76, data reload: false

------ Round 1 ----------------------------------
q1	17925	4583	4403	4403
q2	2363	181	167	167
q3	10479	1151	1108	1108
q4	10128	831	799	799
q5	7723	2915	2856	2856
q6	235	137	138	137
q7	968	619	608	608
q8	9345	2095	2087	2087
q9	7091	6547	6517	6517
q10	7020	2212	2186	2186
q11	461	245	248	245
q12	403	223	220	220
q13	17765	3019	3036	3019
q14	273	234	234	234
q15	517	479	478	478
q16	585	515	511	511
q17	990	710	740	710
q18	7504	6900	6978	6900
q19	1394	1003	1026	1003
q20	678	349	348	348
q21	3863	3009	3094	3009
q22	1112	990	1020	990
Total cold run time: 108822 ms
Total hot run time: 38535 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4361	4358	4308	4308
q2	378	282	277	277
q3	2899	2707	2679	2679
q4	1931	1637	1664	1637
q5	5475	5431	5408	5408
q6	222	130	130	130
q7	2124	1770	1763	1763
q8	3248	3396	3389	3389
q9	8441	8442	8377	8377
q10	3443	3206	3223	3206
q11	586	504	510	504
q12	803	637	608	608
q13	12294	3033	3001	3001
q14	315	282	276	276
q15	520	478	484	478
q16	597	569	551	551
q17	1793	1489	1479	1479
q18	7756	7447	7489	7447
q19	1677	1533	1601	1533
q20	2071	1849	1798	1798
q21	5541	5134	5152	5134
q22	1102	1050	1019	1019
Total cold run time: 67577 ms
Total hot run time: 55002 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187667 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 082925163bc821876cb21f1b89c3c6ef82ad4a76, data reload: false

query1	904	383	361	361
query2	6479	2070	2010	2010
query3	6638	215	225	215
query4	34276	23121	23273	23121
query5	4170	503	492	492
query6	259	171	164	164
query7	4590	299	288	288
query8	258	207	206	206
query9	8607	2493	2491	2491
query10	429	266	273	266
query11	16980	15112	15110	15110
query12	148	103	97	97
query13	1627	376	373	373
query14	9701	7301	6535	6535
query15	262	166	187	166
query16	8091	471	443	443
query17	1587	573	573	573
query18	2137	286	295	286
query19	307	142	142	142
query20	115	109	110	109
query21	209	106	101	101
query22	4506	3965	4103	3965
query23	34113	33565	33411	33411
query24	11134	2896	2875	2875
query25	627	375	381	375
query26	1148	162	160	160
query27	2559	286	282	282
query28	7219	2121	2128	2121
query29	797	411	408	408
query30	310	163	164	163
query31	998	760	826	760
query32	99	58	61	58
query33	777	288	295	288
query34	970	483	490	483
query35	866	766	706	706
query36	1097	925	929	925
query37	162	99	88	88
query38	4041	3843	3865	3843
query39	1448	1412	1391	1391
query40	206	117	117	117
query41	48	49	44	44
query42	113	94	100	94
query43	533	496	503	496
query44	1235	756	754	754
query45	195	167	165	165
query46	1105	711	770	711
query47	1893	1797	1797	1797
query48	391	296	298	296
query49	1091	438	423	423
query50	827	413	451	413
query51	7306	7122	6995	6995
query52	103	89	90	89
query53	254	186	180	180
query54	989	452	447	447
query55	76	75	78	75
query56	287	246	257	246
query57	1178	1050	1090	1050
query58	252	235	264	235
query59	3090	2938	2968	2938
query60	303	269	276	269
query61	104	97	99	97
query62	818	666	658	658
query63	225	191	180	180
query64	5312	689	669	669
query65	3180	3146	3169	3146
query66	1431	346	327	327
query67	15543	15271	15195	15195
query68	3534	592	581	581
query69	388	281	325	281
query70	1143	1159	1123	1123
query71	348	278	277	277
query72	6322	4071	4053	4053
query73	751	333	336	333
query74	9269	8842	8716	8716
query75	3430	2661	2683	2661
query76	2230	970	989	970
query77	497	318	312	312
query78	9487	9052	9125	9052
query79	1029	556	550	550
query80	682	507	507	507
query81	459	238	239	238
query82	241	149	151	149
query83	171	176	154	154
query84	230	91	74	74
query85	692	295	392	295
query86	297	272	304	272
query87	4399	4195	4371	4195
query88	3153	2360	2347	2347
query89	381	293	285	285
query90	1794	199	198	198
query91	128	108	102	102
query92	60	55	52	52
query93	1035	554	546	546
query94	694	309	309	309
query95	350	261	280	261
query96	598	279	274	274
query97	3233	3117	3069	3069
query98	212	206	217	206
query99	1489	1300	1268	1268
Total cold run time: 287459 ms
Total hot run time: 187667 ms

@Yukang-Lian
Copy link
Collaborator Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 37879 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit cd6cbe44cb94b17be6be6d0c6f5afc8f354b4fa4, data reload: false

------ Round 1 ----------------------------------
q1	19005	6405	4334	4334
q2	2030	184	173	173
q3	11553	979	1096	979
q4	10389	668	779	668
q5	7763	2826	2759	2759
q6	227	140	141	140
q7	966	615	594	594
q8	9321	2038	2088	2038
q9	7230	6509	6531	6509
q10	7010	2190	2134	2134
q11	426	235	241	235
q12	398	226	228	226
q13	18966	3025	3048	3025
q14	292	255	222	222
q15	512	474	490	474
q16	592	526	492	492
q17	983	702	643	643
q18	7228	6995	6945	6945
q19	1390	1089	1085	1085
q20	710	341	340	340
q21	4074	2878	3124	2878
q22	1132	986	1016	986
Total cold run time: 112197 ms
Total hot run time: 37879 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4404	4334	4401	4334
q2	371	281	274	274
q3	2867	2630	2685	2630
q4	1859	1694	1759	1694
q5	5721	5685	5751	5685
q6	227	133	137	133
q7	2239	1841	1775	1775
q8	3297	3488	3459	3459
q9	8824	8761	8819	8761
q10	3638	3375	3328	3328
q11	625	508	504	504
q12	844	691	714	691
q13	14094	3151	3246	3151
q14	327	298	289	289
q15	539	485	484	484
q16	611	575	567	567
q17	1875	1557	1536	1536
q18	8196	7833	7983	7833
q19	1733	1608	1615	1608
q20	2170	1920	1922	1920
q21	5694	5501	5537	5501
q22	1122	1056	1050	1050
Total cold run time: 71277 ms
Total hot run time: 57207 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193386 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit cd6cbe44cb94b17be6be6d0c6f5afc8f354b4fa4, data reload: false

query1	1259	900	865	865
query2	6363	2029	1978	1978
query3	10610	3996	3995	3995
query4	60152	24021	23302	23302
query5	5284	520	518	518
query6	416	159	178	159
query7	5765	309	305	305
query8	293	201	209	201
query9	8922	2545	2521	2521
query10	501	281	297	281
query11	17946	15108	15393	15108
query12	158	108	108	108
query13	1568	394	381	381
query14	10839	7672	7542	7542
query15	247	171	183	171
query16	7600	458	511	458
query17	1121	590	590	590
query18	2113	299	300	299
query19	301	147	150	147
query20	121	114	119	114
query21	207	107	105	105
query22	4542	4258	4517	4258
query23	34283	33907	33429	33429
query24	5964	2878	2879	2878
query25	541	378	376	376
query26	692	159	158	158
query27	1774	288	288	288
query28	3823	2136	2129	2129
query29	704	411	422	411
query30	245	153	164	153
query31	928	777	794	777
query32	88	56	60	56
query33	489	302	319	302
query34	858	493	501	493
query35	841	727	736	727
query36	1044	912	943	912
query37	158	100	88	88
query38	3923	3771	3866	3771
query39	1443	1402	1409	1402
query40	193	117	115	115
query41	49	46	45	45
query42	113	96	100	96
query43	511	481	473	473
query44	1089	747	753	747
query45	198	168	169	168
query46	1104	763	733	733
query47	1897	1785	1782	1782
query48	370	298	305	298
query49	774	435	433	433
query50	840	439	427	427
query51	7228	7057	7023	7023
query52	97	87	89	87
query53	251	183	182	182
query54	572	454	467	454
query55	80	78	78	78
query56	280	257	267	257
query57	1193	1087	1093	1087
query58	235	233	242	233
query59	3111	3057	2718	2718
query60	304	294	287	287
query61	127	126	119	119
query62	763	662	653	653
query63	231	192	193	192
query64	2964	800	758	758
query65	3237	3179	3173	3173
query66	684	369	358	358
query67	15815	15124	15069	15069
query68	3007	590	601	590
query69	414	288	289	288
query70	1189	1115	1137	1115
query71	365	282	287	282
query72	6433	3796	3987	3796
query73	761	336	344	336
query74	9007	8831	8866	8831
query75	3349	2681	2731	2681
query76	1357	1023	995	995
query77	542	332	322	322
query78	9973	9114	8928	8928
query79	1089	536	537	536
query80	830	559	524	524
query81	475	239	237	237
query82	468	155	146	146
query83	173	154	156	154
query84	249	80	77	77
query85	846	295	285	285
query86	314	309	308	308
query87	4367	4251	4246	4246
query88	3345	2372	2364	2364
query89	395	292	288	288
query90	1790	208	197	197
query91	129	102	104	102
query92	64	62	57	57
query93	1089	555	554	554
query94	718	292	309	292
query95	366	276	275	275
query96	595	273	280	273
query97	3215	3115	3043	3043
query98	237	202	195	195
query99	1529	1277	1268	1268
Total cold run time: 307116 ms
Total hot run time: 193386 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.42 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit cd6cbe44cb94b17be6be6d0c6f5afc8f354b4fa4, data reload: false

query1	0.05	0.04	0.04
query2	0.09	0.04	0.03
query3	0.23	0.06	0.06
query4	1.66	0.09	0.10
query5	0.51	0.50	0.51
query6	1.13	0.73	0.74
query7	0.02	0.01	0.01
query8	0.05	0.04	0.05
query9	0.55	0.48	0.50
query10	0.55	0.54	0.56
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.63	0.60	0.59
query14	2.04	2.06	2.12
query15	0.84	0.82	0.81
query16	0.37	0.39	0.36
query17	1.05	0.98	1.07
query18	0.22	0.20	0.20
query19	1.91	1.81	1.89
query20	0.01	0.02	0.01
query21	15.42	0.66	0.67
query22	3.98	7.25	2.25
query23	18.28	1.28	1.25
query24	2.07	0.23	0.25
query25	0.14	0.08	0.09
query26	0.28	0.18	0.17
query27	0.08	0.08	0.08
query28	13.17	1.02	1.00
query29	12.64	3.38	3.36
query30	0.24	0.06	0.05
query31	2.87	0.40	0.40
query32	3.25	0.47	0.47
query33	2.95	2.99	2.99
query34	16.96	4.38	4.37
query35	4.46	4.43	4.44
query36	0.66	0.47	0.48
query37	0.19	0.17	0.16
query38	0.16	0.16	0.15
query39	0.04	0.04	0.04
query40	0.15	0.12	0.13
query41	0.08	0.04	0.04
query42	0.07	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 110.39 s
Total hot run time: 32.42 s

dataroaring
dataroaring approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit 8bf3ff4 into apache:master Sep 3, 2024
26 of 29 checks passed
@Yukang-Lian Yukang-Lian mentioned this pull request Sep 3, 2024
Merged
yiguolei pushed a commit that referenced this pull request Sep 5, 2024
@Yukang-Lian
[cherry-pick](branch-2.1) Fix some group commit fault (#40319)
52393f8 
## Proposed changes

Pick #39986 #40120

<!--Describe your changes.-->
gavinchou pushed a commit that referenced this pull request Sep 10, 2024
@Yukang-Lian @gavinchou
[Enhancement](Group commit) Remove the redundant iscloud parameter (#…
e03b6d1 
…40120)

`isCloud` parameter is redundant because we can use `Config.isCloud()`
to replace it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@mymeiyi mymeiyi mymeiyi approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.2-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yukang-Lian @doris-robot @mymeiyi @dataroaring @yiguolei