Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](delete) Fix error when creating a non-MOW table while the default value of enable_mow_light_delete is true #40197

Merged

Conversation

Yukang-Lian
Copy link
Collaborator

Proposed changes

Fix the issue where an error occurs when creating a non-MOW table while the default value of enable_mow_light_delete is set to true.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Yukang-Lian
Copy link
Collaborator Author

run buildall

@Yukang-Lian
Copy link
Collaborator Author

run performance

@doris-robot
Copy link

TPC-H: Total hot run time: 38235 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 911fdbdb432e6bd84634a9521671d8c7342ba3d3, data reload: false

------ Round 1 ----------------------------------
q1	18245	4453	4369	4369
q2	2363	188	178	178
q3	11022	1119	1172	1119
q4	10639	722	677	677
q5	8157	2915	2896	2896
q6	239	144	147	144
q7	974	647	614	614
q8	9374	2092	2033	2033
q9	7273	6519	6592	6519
q10	7006	2216	2165	2165
q11	429	241	244	241
q12	390	232	227	227
q13	17773	3059	3016	3016
q14	289	231	235	231
q15	532	500	477	477
q16	579	502	516	502
q17	1006	746	761	746
q18	7355	6934	6845	6845
q19	1395	1047	983	983
q20	676	346	336	336
q21	4245	3162	2901	2901
q22	1106	1022	1016	1016
Total cold run time: 111067 ms
Total hot run time: 38235 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4341	4301	4266	4266
q2	376	283	263	263
q3	2896	2720	2692	2692
q4	1998	1662	1609	1609
q5	5428	5398	5419	5398
q6	225	134	132	132
q7	2136	1708	1730	1708
q8	3195	3372	3355	3355
q9	8524	8528	8478	8478
q10	3458	3217	3193	3193
q11	586	496	514	496
q12	803	623	602	602
q13	10289	3092	3088	3088
q14	318	281	286	281
q15	523	486	494	486
q16	610	556	552	552
q17	1818	1504	1481	1481
q18	7615	7457	7298	7298
q19	1663	1650	1603	1603
q20	2078	1838	1826	1826
q21	5607	5234	5207	5207
q22	1092	1056	1014	1014
Total cold run time: 65579 ms
Total hot run time: 55028 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 188175 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 911fdbdb432e6bd84634a9521671d8c7342ba3d3, data reload: false

query1	920	389	368	368
query2	6437	2066	1972	1972
query3	6668	209	215	209
query4	34016	23182	23154	23154
query5	4163	495	494	494
query6	253	162	173	162
query7	4585	290	287	287
query8	257	205	215	205
query9	8460	2484	2475	2475
query10	467	303	275	275
query11	17840	15025	15047	15025
query12	152	102	100	100
query13	1639	374	378	374
query14	9293	7203	7011	7011
query15	252	167	169	167
query16	8076	480	450	450
query17	1566	554	540	540
query18	2140	286	274	274
query19	243	145	145	145
query20	115	119	110	110
query21	210	107	104	104
query22	4610	4275	4137	4137
query23	33966	33527	33431	33431
query24	10934	2892	2905	2892
query25	617	376	382	376
query26	1189	161	170	161
query27	2526	288	284	284
query28	7348	2154	2103	2103
query29	814	412	403	403
query30	307	154	155	154
query31	977	752	814	752
query32	100	58	58	58
query33	754	284	283	283
query34	997	491	499	491
query35	846	730	729	729
query36	1095	923	900	900
query37	165	100	96	96
query38	4010	3825	3862	3825
query39	1472	1400	1391	1391
query40	200	117	118	117
query41	46	51	45	45
query42	117	99	99	99
query43	530	466	474	466
query44	1249	778	766	766
query45	196	171	170	170
query46	1110	789	745	745
query47	1885	1779	1812	1779
query48	369	293	291	291
query49	1105	452	436	436
query50	813	412	410	410
query51	7140	7172	7125	7125
query52	101	89	90	89
query53	266	192	180	180
query54	905	460	454	454
query55	78	80	82	80
query56	274	259	264	259
query57	1165	1098	1097	1097
query58	231	249	231	231
query59	3097	2909	2787	2787
query60	297	266	301	266
query61	105	98	101	98
query62	845	657	663	657
query63	225	186	186	186
query64	4227	688	710	688
query65	3196	3120	3167	3120
query66	1386	330	328	328
query67	15710	15234	15407	15234
query68	3543	574	573	573
query69	415	273	286	273
query70	1151	1093	1121	1093
query71	329	278	279	278
query72	6383	4180	3973	3973
query73	751	326	329	326
query74	9142	8773	8935	8773
query75	3417	2717	2674	2674
query76	2119	962	1048	962
query77	529	333	330	330
query78	9554	9042	10593	9042
query79	1009	559	542	542
query80	666	527	532	527
query81	462	240	239	239
query82	244	153	153	153
query83	236	153	151	151
query84	220	82	77	77
query85	692	286	280	280
query86	295	306	294	294
query87	4377	4361	4278	4278
query88	2907	2312	2326	2312
query89	382	291	287	287
query90	1783	191	191	191
query91	123	102	100	100
query92	64	54	51	51
query93	1029	541	543	541
query94	714	290	306	290
query95	352	268	258	258
query96	584	265	267	265
query97	3244	3054	3121	3054
query98	222	209	196	196
query99	1516	1271	1222	1222
Total cold run time: 285801 ms
Total hot run time: 188175 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.65 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 911fdbdb432e6bd84634a9521671d8c7342ba3d3, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.09	0.09
query5	0.49	0.49	0.49
query6	1.13	0.73	0.74
query7	0.02	0.01	0.01
query8	0.06	0.04	0.04
query9	0.54	0.49	0.48
query10	0.54	0.56	0.53
query11	0.16	0.12	0.12
query12	0.15	0.12	0.12
query13	0.61	0.58	0.58
query14	2.06	2.05	2.07
query15	0.89	0.82	0.84
query16	0.39	0.37	0.37
query17	0.96	1.01	1.03
query18	0.21	0.20	0.20
query19	1.79	1.77	1.74
query20	0.01	0.02	0.01
query21	15.41	0.67	0.65
query22	3.86	6.96	2.58
query23	18.27	1.44	1.24
query24	2.08	0.23	0.22
query25	0.16	0.08	0.08
query26	0.27	0.18	0.18
query27	0.08	0.08	0.07
query28	13.23	1.02	1.01
query29	12.64	3.36	3.32
query30	0.25	0.06	0.06
query31	2.88	0.41	0.40
query32	3.23	0.48	0.48
query33	2.96	2.96	3.03
query34	16.97	4.40	4.43
query35	4.49	4.42	4.44
query36	0.67	0.48	0.49
query37	0.17	0.15	0.16
query38	0.15	0.15	0.15
query39	0.06	0.03	0.04
query40	0.16	0.14	0.13
query41	0.09	0.05	0.04
query42	0.06	0.04	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.23 s
Total hot run time: 32.65 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 31, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit cc2fa78 into apache:master Sep 2, 2024
29 of 31 checks passed
Yukang-Lian added a commit to Yukang-Lian/doris that referenced this pull request Sep 2, 2024
…lt value of `enable_mow_light_delete` is true (apache#40197)

## Proposed changes

Fix the issue where an error occurs when creating a non-MOW table while
the default value of `enable_mow_light_delete` is set to true.

<!--Describe your changes.-->
Yukang-Lian added a commit to Yukang-Lian/doris that referenced this pull request Sep 2, 2024
…lt value of `enable_mow_light_delete` is true (apache#40197)

## Proposed changes

Fix the issue where an error occurs when creating a non-MOW table while
the default value of `enable_mow_light_delete` is set to true.

<!--Describe your changes.-->
yiguolei pushed a commit that referenced this pull request Sep 3, 2024
…#40283)

## Proposed changes

Pick #40104 #40197

<!--Describe your changes.-->
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
…lt value of `enable_mow_light_delete` is true (#40197)

## Proposed changes

Fix the issue where an error occurs when creating a non-MOW table while
the default value of `enable_mow_light_delete` is set to true.

<!--Describe your changes.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants