Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](unary function) Fix wrong result of asin, acos and sqrt when processing invalid input #40267

Merged
merged 5 commits into from
Sep 4, 2024
Merged

[fix](unary function) Fix wrong result of asin, acos and sqrt when processing invalid input #40267

merged 5 commits into from
Sep 4, 2024

Conversation

zhiqiang-hhhh
Copy link
Contributor

When input of asin, acos and sqrt is invalid, result of them should be null (same with mysql).

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 38046 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fa5335c2ae9c50e175ef9df753724b8dc7e7fdb0, data reload: false

------ Round 1 ----------------------------------
q1	17619	4409	4248	4248
q2	2020	187	175	175
q3	11773	977	1112	977
q4	10508	742	822	742
q5	7772	2861	2846	2846
q6	230	138	140	138
q7	953	618	617	617
q8	9327	2103	2037	2037
q9	7090	6487	6506	6487
q10	6986	2220	2156	2156
q11	459	243	241	241
q12	392	235	232	232
q13	17758	3093	3057	3057
q14	279	244	245	244
q15	521	496	488	488
q16	588	496	500	496
q17	991	677	751	677
q18	7212	6812	6872	6812
q19	1384	1057	1065	1057
q20	672	346	342	342
q21	3942	2984	3003	2984
q22	1080	993	1002	993
Total cold run time: 109556 ms
Total hot run time: 38046 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4334	4276	4226	4226
q2	387	281	278	278
q3	2886	2613	2669	2613
q4	1899	1616	1659	1616
q5	5555	5674	5685	5674
q6	223	130	142	130
q7	2247	1798	1836	1798
q8	3303	3408	3381	3381
q9	8827	8865	8864	8864
q10	3574	3305	3358	3305
q11	608	497	517	497
q12	820	650	659	650
q13	14329	3345	3235	3235
q14	315	291	285	285
q15	531	496	490	490
q16	643	576	568	568
q17	1844	1519	1517	1517
q18	8127	7716	7908	7716
q19	1720	1504	1677	1504
q20	2201	1888	1916	1888
q21	5755	5462	5549	5462
q22	1119	1065	1037	1037
Total cold run time: 71247 ms
Total hot run time: 56734 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192688 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fa5335c2ae9c50e175ef9df753724b8dc7e7fdb0, data reload: false

query1	1239	896	853	853
query2	6185	2011	1944	1944
query3	10610	3959	3832	3832
query4	59672	26247	23276	23276
query5	5386	501	502	501
query6	407	161	160	160
query7	5784	288	293	288
query8	287	200	203	200
query9	9021	2469	2449	2449
query10	483	271	258	258
query11	17935	15064	15303	15064
query12	162	102	102	102
query13	1551	383	398	383
query14	11115	7182	7280	7182
query15	235	175	186	175
query16	7224	451	401	401
query17	1179	569	562	562
query18	2028	296	300	296
query19	285	148	154	148
query20	117	113	109	109
query21	204	102	107	102
query22	4562	4563	4921	4563
query23	34377	33413	33486	33413
query24	5986	2851	2745	2745
query25	530	364	375	364
query26	681	154	152	152
query27	1788	283	279	279
query28	3781	2050	2025	2025
query29	670	405	399	399
query30	233	155	162	155
query31	921	766	774	766
query32	82	50	53	50
query33	439	288	291	288
query34	848	472	491	472
query35	828	706	726	706
query36	1088	923	953	923
query37	146	91	94	91
query38	3955	3823	3830	3823
query39	1443	1396	1393	1393
query40	196	118	111	111
query41	43	45	45	45
query42	118	93	95	93
query43	513	472	481	472
query44	1073	722	741	722
query45	197	161	164	161
query46	1088	765	724	724
query47	1910	1836	1846	1836
query48	372	287	294	287
query49	770	434	440	434
query50	822	416	402	402
query51	6905	6860	6856	6856
query52	99	85	86	85
query53	254	179	180	179
query54	574	462	450	450
query55	78	76	73	73
query56	290	266	278	266
query57	1214	1099	1075	1075
query58	236	255	238	238
query59	3240	3033	2871	2871
query60	293	268	274	268
query61	121	124	118	118
query62	725	658	659	658
query63	221	185	189	185
query64	2868	749	734	734
query65	3235	3141	3131	3131
query66	695	348	351	348
query67	15603	15394	15258	15258
query68	3074	587	593	587
query69	431	292	284	284
query70	1199	1071	1154	1071
query71	355	279	280	279
query72	6316	4271	4164	4164
query73	754	328	323	323
query74	9205	8863	8986	8863
query75	3381	2682	2652	2652
query76	1530	992	1009	992
query77	536	309	314	309
query78	9884	9023	9034	9023
query79	1892	520	517	517
query80	879	503	501	501
query81	570	236	234	234
query82	293	138	138	138
query83	251	148	147	147
query84	259	77	73	73
query85	978	281	275	275
query86	425	300	288	288
query87	4470	4283	4327	4283
query88	4233	2307	2292	2292
query89	381	283	282	282
query90	1999	181	183	181
query91	122	97	97	97
query92	62	46	47	46
query93	1933	537	531	531
query94	830	279	290	279
query95	382	247	249	247
query96	598	265	259	259
query97	3198	3068	3117	3068
query98	215	200	203	200
query99	1566	1251	1231	1231
Total cold run time: 309421 ms
Total hot run time: 192688 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.4 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fa5335c2ae9c50e175ef9df753724b8dc7e7fdb0, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.03
query3	0.22	0.05	0.05
query4	1.68	0.10	0.09
query5	0.50	0.50	0.49
query6	1.13	0.74	0.74
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.54	0.48	0.49
query10	0.54	0.54	0.55
query11	0.15	0.12	0.11
query12	0.15	0.12	0.12
query13	0.60	0.58	0.59
query14	2.09	2.04	2.10
query15	0.90	0.82	0.84
query16	0.35	0.38	0.38
query17	1.00	0.99	1.05
query18	0.22	0.20	0.21
query19	1.93	1.79	1.80
query20	0.01	0.01	0.01
query21	15.39	0.68	0.65
query22	4.20	6.99	2.22
query23	18.32	1.50	1.30
query24	2.11	0.23	0.23
query25	0.14	0.08	0.07
query26	0.27	0.18	0.18
query27	0.08	0.08	0.09
query28	13.25	1.02	1.01
query29	12.61	3.39	3.35
query30	0.24	0.05	0.05
query31	3.22	0.42	0.40
query32	3.54	0.49	0.47
query33	2.98	2.96	3.00
query34	17.03	4.41	4.37
query35	4.44	4.41	4.49
query36	0.66	0.49	0.49
query37	0.19	0.16	0.15
query38	0.16	0.15	0.15
query39	0.05	0.04	0.04
query40	0.16	0.13	0.13
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 111.45 s
Total hot run time: 32.4 s

yiguolei
yiguolei reviewed Sep 2, 2024
View reviewed changes
...ion-test/suites/query_p0/sql_functions/math_functions/test_math_unary_always_nullable.groovy
sql """
set debug_skip_fold_constant=true;
"""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我们所有的函数测试，都得测试 两种：

  1. 常量
  2. 把数据插入到一个表中，然后select的时候运行函数
  3. 二元函数检查，参数是否都可以为常量或者变量

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

yiguolei
yiguolei reviewed Sep 2, 2024
View reviewed changes
be/src/vec/functions/function_math_unary_alway_nullable.h Outdated
// specific language governing permissions and limitations
// under the License.
// This file is copied from
// https://github.com/ClickHouse/ClickHouse/blob/master/src/Functions/FunctionMathUnary.h
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why add this? do you refer these code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied from be/src/vec/functions/function_math_unary.h

@doris-robot
Copy link

TPC-H: Total hot run time: 38205 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 65bd8e54d91c12e90127768680185fc7f2afa979, data reload: false

------ Round 1 ----------------------------------
q1	18170	5021	4412	4412
q2	2916	194	176	176
q3	11213	1112	1100	1100
q4	10384	787	770	770
q5	7785	2883	2868	2868
q6	229	138	139	138
q7	960	639	600	600
q8	9508	2068	2022	2022
q9	6999	6538	6497	6497
q10	6979	2173	2193	2173
q11	455	231	247	231
q12	395	218	221	218
q13	17767	3086	3072	3072
q14	280	232	238	232
q15	517	492	491	491
q16	585	499	520	499
q17	979	676	697	676
q18	7256	6904	6907	6904
q19	1386	1020	998	998
q20	666	324	327	324
q21	3953	2865	2786	2786
q22	1093	1018	1023	1018
Total cold run time: 110475 ms
Total hot run time: 38205 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4333	4312	4293	4293
q2	368	268	271	268
q3	2856	2624	2618	2618
q4	1885	1626	1619	1619
q5	5380	5380	5403	5380
q6	222	134	128	128
q7	2120	1743	1750	1743
q8	3205	3315	3358	3315
q9	8456	8437	8387	8387
q10	3412	3239	3149	3149
q11	619	488	498	488
q12	774	634	618	618
q13	10333	3052	3066	3052
q14	303	268	268	268
q15	522	477	485	477
q16	650	562	578	562
q17	1781	1488	1470	1470
q18	7802	7570	7512	7512
q19	1689	1445	1402	1402
q20	2078	1834	1848	1834
q21	5462	5310	5337	5310
q22	1119	1001	1003	1001
Total cold run time: 65369 ms
Total hot run time: 54894 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187348 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 65bd8e54d91c12e90127768680185fc7f2afa979, data reload: false

query1	912	373	367	367
query2	6457	2085	2030	2030
query3	6661	200	211	200
query4	34229	23254	23076	23076
query5	4171	502	476	476
query6	252	164	160	160
query7	4586	295	285	285
query8	273	208	207	207
query9	8626	2451	2459	2451
query10	452	289	273	273
query11	17972	14978	15025	14978
query12	152	96	97	96
query13	1625	363	358	358
query14	9615	7004	7310	7004
query15	254	167	186	167
query16	8046	437	437	437
query17	1615	575	534	534
query18	2059	282	278	278
query19	326	139	144	139
query20	114	111	109	109
query21	213	103	104	103
query22	4398	4180	3999	3999
query23	34014	33276	34002	33276
query24	11254	2958	2842	2842
query25	629	400	397	397
query26	1168	164	155	155
query27	2435	283	280	280
query28	7363	2065	2038	2038
query29	826	447	420	420
query30	317	161	156	156
query31	995	757	764	757
query32	98	56	66	56
query33	759	300	298	298
query34	955	473	472	472
query35	881	724	700	700
query36	1078	918	928	918
query37	168	95	90	90
query38	3972	3835	3957	3835
query39	1446	1394	1410	1394
query40	211	119	117	117
query41	52	48	50	48
query42	115	94	95	94
query43	520	481	489	481
query44	1230	754	742	742
query45	201	164	168	164
query46	1102	745	755	745
query47	1881	1776	1829	1776
query48	373	293	290	290
query49	1052	429	433	429
query50	793	413	405	405
query51	7086	6908	6795	6795
query52	101	88	89	88
query53	255	190	179	179
query54	1007	477	465	465
query55	77	74	76	74
query56	291	270	267	267
query57	1225	1084	1079	1079
query58	246	232	249	232
query59	3102	2997	3013	2997
query60	302	274	270	270
query61	123	121	121	121
query62	868	687	636	636
query63	225	181	178	178
query64	5377	749	722	722
query65	3217	3405	3147	3147
query66	1409	337	348	337
query67	15693	15344	15269	15269
query68	4584	563	557	557
query69	420	274	281	274
query70	1134	1109	1112	1109
query71	343	283	282	282
query72	6791	3968	4169	3968
query73	773	327	326	326
query74	9162	8853	8788	8788
query75	3397	2669	2681	2669
query76	2622	1100	1019	1019
query77	522	325	317	317
query78	10143	9127	9023	9023
query79	2209	523	526	523
query80	993	494	495	494
query81	591	236	231	231
query82	637	145	141	141
query83	248	152	150	150
query84	280	78	74	74
query85	1587	303	278	278
query86	472	295	304	295
query87	4496	4366	4137	4137
query88	3989	2296	2406	2296
query89	386	283	287	283
query90	1879	186	182	182
query91	123	97	99	97
query92	66	50	49	49
query93	1958	553	538	538
query94	953	284	285	284
query95	346	244	240	240
query96	588	263	261	261
query97	3237	3042	3033	3033
query98	221	198	195	195
query99	1767	1308	1277	1277
Total cold run time: 296417 ms
Total hot run time: 187348 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.88 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 65bd8e54d91c12e90127768680185fc7f2afa979, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.68	0.07	0.07
query5	0.50	0.50	0.50
query6	1.13	0.74	0.72
query7	0.02	0.01	0.01
query8	0.06	0.05	0.05
query9	0.55	0.49	0.50
query10	0.53	0.53	0.55
query11	0.15	0.12	0.11
query12	0.15	0.12	0.12
query13	0.60	0.58	0.58
query14	2.10	2.05	2.06
query15	0.89	0.82	0.82
query16	0.38	0.37	0.38
query17	1.00	1.04	0.98
query18	0.21	0.20	0.20
query19	1.92	1.79	1.80
query20	0.01	0.01	0.00
query21	15.42	0.67	0.66
query22	4.97	6.24	1.85
query23	18.29	1.35	1.29
query24	2.09	0.21	0.23
query25	0.15	0.08	0.08
query26	0.27	0.18	0.17
query27	0.08	0.08	0.08
query28	13.30	1.02	0.99
query29	12.65	3.36	3.34
query30	0.24	0.06	0.05
query31	2.87	0.39	0.40
query32	3.28	0.48	0.47
query33	2.92	2.96	2.99
query34	17.06	4.36	4.47
query35	4.46	4.45	4.40
query36	0.66	0.47	0.51
query37	0.19	0.16	0.16
query38	0.16	0.14	0.14
query39	0.05	0.04	0.04
query40	0.15	0.12	0.12
query41	0.09	0.04	0.05
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 111.68 s
Total hot run time: 31.88 s

@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

clang-tidy review says "All clean, LGTM! 👍"

zclllyybb
zclllyybb approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 38171 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 493f28c82600d6593f26e085448c13becab41b2d, data reload: false

------ Round 1 ----------------------------------
q1	18176	4469	4405	4405
q2	2415	184	175	175
q3	11107	1119	1021	1021
q4	11463	729	761	729
q5	7859	2911	2844	2844
q6	234	151	140	140
q7	978	613	620	613
q8	9307	2066	2031	2031
q9	7065	6533	6538	6533
q10	7003	2226	2213	2213
q11	482	243	243	243
q12	404	220	226	220
q13	18838	3079	3086	3079
q14	281	242	231	231
q15	518	492	504	492
q16	572	500	524	500
q17	986	649	671	649
q18	7384	6876	6890	6876
q19	1398	1017	1033	1017
q20	713	341	331	331
q21	3974	3079	2828	2828
q22	1088	1001	1018	1001
Total cold run time: 112245 ms
Total hot run time: 38171 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4396	4349	4280	4280
q2	391	265	281	265
q3	2878	2668	2688	2668
q4	1922	1700	1639	1639
q5	5373	5406	5421	5406
q6	222	130	131	130
q7	2093	1729	1702	1702
q8	3184	3367	3418	3367
q9	8472	8442	8501	8442
q10	3457	3204	3187	3187
q11	603	516	503	503
q12	795	625	574	574
q13	10939	3098	3085	3085
q14	301	276	290	276
q15	514	482	483	482
q16	610	566	581	566
q17	1776	1502	1492	1492
q18	7821	7480	7491	7480
q19	1642	1561	1604	1561
q20	2075	1799	1837	1799
q21	5604	5387	5150	5150
q22	1126	1044	1047	1044
Total cold run time: 66194 ms
Total hot run time: 55098 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 188674 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 493f28c82600d6593f26e085448c13becab41b2d, data reload: false

query1	911	379	376	376
query2	6460	2095	2051	2051
query3	6646	211	213	211
query4	34546	23281	23219	23219
query5	4135	515	487	487
query6	277	166	169	166
query7	4605	316	301	301
query8	263	205	200	200
query9	8755	2461	2449	2449
query10	441	285	270	270
query11	17856	15002	15109	15002
query12	156	99	96	96
query13	1653	374	374	374
query14	9944	7622	7412	7412
query15	240	172	170	170
query16	7747	466	491	466
query17	1591	586	573	573
query18	1875	298	293	293
query19	207	151	154	151
query20	115	114	109	109
query21	212	108	105	105
query22	4505	4132	4311	4132
query23	34219	33396	33425	33396
query24	11212	2982	2864	2864
query25	652	439	408	408
query26	1187	161	161	161
query27	2702	286	282	282
query28	7436	2066	2058	2058
query29	818	445	427	427
query30	325	167	157	157
query31	1028	786	761	761
query32	103	57	61	57
query33	787	299	290	290
query34	966	493	505	493
query35	875	722	745	722
query36	1135	952	938	938
query37	161	98	95	95
query38	3987	3839	3905	3839
query39	1456	1389	1377	1377
query40	211	122	120	120
query41	52	48	47	47
query42	122	100	108	100
query43	534	511	469	469
query44	1225	762	755	755
query45	197	170	172	170
query46	1114	772	752	752
query47	1865	1737	1808	1737
query48	382	301	308	301
query49	1106	444	453	444
query50	822	418	425	418
query51	7026	6876	6956	6876
query52	101	93	89	89
query53	266	193	193	193
query54	1094	462	460	460
query55	76	83	81	81
query56	291	266	270	266
query57	1220	1048	1072	1048
query58	277	227	245	227
query59	3059	2956	2840	2840
query60	304	285	286	285
query61	129	123	122	122
query62	864	663	660	660
query63	233	189	189	189
query64	5370	769	725	725
query65	3245	3170	3206	3170
query66	1405	350	354	350
query67	15694	15318	15368	15318
query68	4777	574	567	567
query69	433	279	274	274
query70	1165	1143	1005	1005
query71	347	282	278	278
query72	6688	4030	3985	3985
query73	763	327	337	327
query74	9139	8758	8958	8758
query75	3482	2665	2682	2665
query76	2779	1025	1045	1025
query77	517	372	328	328
query78	9773	9070	9243	9070
query79	2624	555	568	555
query80	1133	515	506	506
query81	594	235	243	235
query82	762	148	153	148
query83	219	151	150	150
query84	234	73	80	73
query85	1511	287	317	287
query86	410	300	294	294
query87	4414	4272	4162	4162
query88	4149	2322	2308	2308
query89	378	288	283	283
query90	1697	196	194	194
query91	133	105	107	105
query92	62	50	50	50
query93	1683	561	552	552
query94	759	292	294	292
query95	350	261	254	254
query96	593	263	270	263
query97	3228	3074	3083	3074
query98	222	205	195	195
query99	1711	1288	1262	1262
Total cold run time: 297202 ms
Total hot run time: 188674 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.34 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 493f28c82600d6593f26e085448c13becab41b2d, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.08	0.08
query5	0.49	0.48	0.51
query6	1.12	0.75	0.73
query7	0.02	0.02	0.02
query8	0.05	0.05	0.04
query9	0.55	0.49	0.49
query10	0.54	0.53	0.54
query11	0.16	0.12	0.11
query12	0.15	0.13	0.12
query13	0.61	0.59	0.59
query14	2.05	2.06	2.05
query15	0.92	0.83	0.81
query16	0.38	0.36	0.38
query17	1.05	0.99	0.97
query18	0.21	0.20	0.19
query19	1.91	1.76	1.71
query20	0.01	0.01	0.01
query21	15.40	0.68	0.66
query22	4.58	7.82	1.27
query23	18.27	1.43	1.30
query24	2.15	0.22	0.20
query25	0.14	0.08	0.08
query26	0.27	0.18	0.18
query27	0.07	0.07	0.08
query28	13.19	1.01	1.02
query29	12.65	3.34	3.32
query30	0.25	0.05	0.05
query31	2.88	0.41	0.39
query32	3.24	0.49	0.48
query33	2.92	3.06	3.04
query34	17.12	4.40	4.37
query35	4.45	4.45	4.53
query36	0.66	0.48	0.47
query37	0.19	0.15	0.15
query38	0.15	0.14	0.15
query39	0.04	0.04	0.03
query40	0.16	0.12	0.12
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 111.24 s
Total hot run time: 31.34 s

yiguolei
yiguolei previously approved these changes Sep 3, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 3, 2024
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 3, 2024
@zhiqiang-hhhh
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 3, 2024
@zhiqiang-hhhh zhiqiang-hhhh mentioned this pull request Sep 3, 2024
Merged
6 tasks
@doris-robot
Copy link

TPC-H: Total hot run time: 38307 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c9359f18cb42609e6157caeb7941979b33ac229e, data reload: false

------ Round 1 ----------------------------------
q1	17617	4632	4371	4371
q2	2021	188	182	182
q3	11652	942	1192	942
q4	10513	750	750	750
q5	7750	2889	2864	2864
q6	233	142	137	137
q7	968	618	606	606
q8	9347	2119	2090	2090
q9	7047	6539	6605	6539
q10	7032	2207	2257	2207
q11	462	243	247	243
q12	407	223	226	223
q13	18829	3072	3089	3072
q14	299	231	237	231
q15	519	507	487	487
q16	580	533	510	510
q17	986	753	737	737
q18	7426	6967	6810	6810
q19	1391	1005	1125	1005
q20	695	330	351	330
q21	3982	2977	3068	2977
q22	1093	1024	994	994
Total cold run time: 110849 ms
Total hot run time: 38307 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4413	4299	4358	4299
q2	375	264	277	264
q3	2895	2695	2664	2664
q4	1920	1624	1649	1624
q5	5719	5687	6112	5687
q6	231	133	137	133
q7	2197	1856	1819	1819
q8	3316	3489	3522	3489
q9	8929	8849	8812	8812
q10	3659	3480	3366	3366
q11	604	509	496	496
q12	825	656	653	653
q13	16940	3272	3323	3272
q14	313	297	291	291
q15	529	511	491	491
q16	633	567	573	567
q17	1842	1581	1522	1522
q18	8258	8029	7944	7944
q19	1764	1625	1619	1619
q20	2109	1976	1896	1896
q21	5814	5505	5187	5187
q22	1123	1055	1089	1055
Total cold run time: 74408 ms
Total hot run time: 57150 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193103 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c9359f18cb42609e6157caeb7941979b33ac229e, data reload: false

query1	1242	882	855	855
query2	6446	2020	2005	2005
query3	10641	4102	4061	4061
query4	59428	24724	23316	23316
query5	5385	504	499	499
query6	399	157	179	157
query7	5791	286	284	284
query8	285	204	197	197
query9	8822	2453	2456	2453
query10	514	270	259	259
query11	18098	15051	15265	15051
query12	154	99	98	98
query13	1579	411	386	386
query14	10800	7382	7399	7382
query15	220	179	184	179
query16	7321	472	451	451
query17	1124	558	549	549
query18	1768	308	289	289
query19	275	144	145	144
query20	119	113	197	113
query21	213	106	103	103
query22	4668	4773	4454	4454
query23	34414	33359	33508	33359
query24	5979	2905	2801	2801
query25	534	408	392	392
query26	667	149	151	149
query27	1772	279	276	276
query28	3820	2038	2014	2014
query29	644	404	400	400
query30	236	151	160	151
query31	943	770	763	763
query32	81	52	51	51
query33	443	284	277	277
query34	860	480	475	475
query35	830	722	711	711
query36	1074	896	941	896
query37	148	82	96	82
query38	4021	3845	3927	3845
query39	1464	1421	1418	1418
query40	207	117	116	116
query41	48	49	45	45
query42	122	100	96	96
query43	507	474	480	474
query44	1087	732	739	732
query45	198	167	169	167
query46	1079	747	735	735
query47	1925	1786	1813	1786
query48	363	294	294	294
query49	770	456	463	456
query50	825	413	410	410
query51	6934	6895	6917	6895
query52	104	87	88	87
query53	269	187	180	180
query54	576	459	458	458
query55	76	75	77	75
query56	277	279	263	263
query57	1218	1059	1080	1059
query58	227	238	237	237
query59	3016	2914	2846	2846
query60	303	286	299	286
query61	125	127	118	118
query62	768	661	633	633
query63	215	186	187	186
query64	2698	769	742	742
query65	3234	3135	3146	3135
query66	690	350	367	350
query67	15490	15215	15196	15196
query68	3222	570	570	570
query69	413	282	292	282
query70	1159	1147	1157	1147
query71	358	280	281	280
query72	6485	4180	4179	4179
query73	792	338	342	338
query74	9224	8752	8840	8752
query75	3348	2672	2670	2670
query76	1361	946	984	946
query77	523	318	330	318
query78	9772	9096	9142	9096
query79	2378	521	529	521
query80	1321	507	484	484
query81	571	242	230	230
query82	1178	141	143	141
query83	189	145	141	141
query84	256	72	81	72
query85	971	288	277	277
query86	415	293	297	293
query87	4395	4292	4183	4183
query88	3490	2339	2318	2318
query89	393	285	283	283
query90	1884	192	192	192
query91	126	98	97	97
query92	65	47	46	46
query93	2926	521	518	518
query94	893	306	281	281
query95	343	291	253	253
query96	618	267	263	263
query97	3156	3077	3075	3075
query98	210	204	201	201
query99	1667	1277	1254	1254
Total cold run time: 310675 ms
Total hot run time: 193103 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.55 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c9359f18cb42609e6157caeb7941979b33ac229e, data reload: false

query1	0.05	0.05	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.67	0.07	0.07
query5	0.52	0.52	0.51
query6	1.13	0.72	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.55	0.49	0.49
query10	0.55	0.53	0.54
query11	0.15	0.12	0.12
query12	0.15	0.13	0.12
query13	0.60	0.58	0.59
query14	2.04	2.06	2.04
query15	0.90	0.84	0.81
query16	0.38	0.39	0.37
query17	1.03	1.06	1.03
query18	0.21	0.21	0.21
query19	1.97	1.77	1.77
query20	0.01	0.00	0.01
query21	15.41	0.66	0.65
query22	3.95	7.78	1.36
query23	18.22	1.30	1.35
query24	2.12	0.23	0.21
query25	0.15	0.09	0.08
query26	0.27	0.18	0.18
query27	0.07	0.08	0.08
query28	13.22	1.00	1.00
query29	12.58	3.37	3.36
query30	0.25	0.06	0.06
query31	2.88	0.39	0.40
query32	3.25	0.48	0.47
query33	2.98	3.07	2.99
query34	16.68	4.41	4.48
query35	4.44	4.42	4.48
query36	0.66	0.46	0.48
query37	0.18	0.16	0.15
query38	0.16	0.15	0.16
query39	0.05	0.03	0.04
query40	0.16	0.12	0.13
query41	0.10	0.04	0.04
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 110.16 s
Total hot run time: 31.55 s

@yiguolei yiguolei merged commit 4c1b929 into apache:master Sep 4, 2024
25 of 27 checks passed
@zhiqiang-hhhh zhiqiang-hhhh deleted the fix-acos-related branch September 4, 2024 03:41
zhiqiang-hhhh added a commit to zhiqiang-hhhh/doris that referenced this pull request Sep 4, 2024
@zhiqiang-hhhh
[fix](unary function) Fix wrong result of asin, acos and sqrt when pr…
7817461 
…ocessing invalid input (apache#40267)

When input of asin, acos and sqrt is invalid, result of them should be
null (same with mysql).
@zhiqiang-hhhh zhiqiang-hhhh mentioned this pull request Sep 4, 2024
Merged
yiguolei pushed a commit that referenced this pull request Sep 5, 2024
@zhiqiang-hhhh
[fix](unary function) Fix wrong result of asin, acos and sqrt when pr…
0928c9c 
…ocessing invalid input #40267 (#40358)

cherry pick from #40267
morningman pushed a commit to apache/doris-website that referenced this pull request Sep 6, 2024
@zhiqiang-hhhh
[doc](update) asin/acos/sqrt related (#1081)
c260761 
apache/doris#40267

# Versions 

- [x] dev
- [x] 3.0
- [x] 2.1
- [x] 2.0

# Languages

- [x] Chinese
- [x] English
dataroaring pushed a commit that referenced this pull request Sep 12, 2024
@zhiqiang-hhhh @dataroaring
[fix](unary function) Fix wrong result of asin, acos and sqrt when pr…
07364f7 
…ocessing invalid input (#40267)

When input of asin, acos and sqrt is invalid, result of them should be
null (same with mysql).
Gabriel39 pushed a commit to Gabriel39/doris-website that referenced this pull request Sep 23, 2024
@zhiqiang-hhhh @Gabriel39
[doc](update) asin/acos/sqrt related (apache#1081)
4aaef06 
apache/doris#40267

# Versions 

- [x] dev
- [x] 3.0
- [x] 2.1
- [x] 2.0

# Languages

- [x] Chinese
- [x] English
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zclllyybb zclllyybb zclllyybb approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.2-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhiqiang-hhhh @doris-robot @yiguolei @zclllyybb @dataroaring