[fix](mtmv) Fix partition trace wrong when partition name is same from both side of join #40485
+40
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 37867 ms |
TPC-DS: Total hot run time: 192311 ms |
ClickBench: Total hot run time: 31.27 s |
|
run buildall |
TPC-H: Total hot run time: 38424 ms |
TPC-DS: Total hot run time: 196960 ms |
ClickBench: Total hot run time: 31.22 s |
morrySnow
approved these changes
Sep 9, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
zddr
approved these changes
Sep 10, 2024
|
run p0 |
seawinde
force-pushed
the
fix_partition_trace_wrong
branch
from
e8e82ab
to
4d16e1b
Compare
|
run buildall |
TPC-H: Total hot run time: 38033 ms |
TPC-DS: Total hot run time: 197486 ms |
ClickBench: Total hot run time: 32.05 s |
morrySnow
approved these changes
Sep 13, 2024
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Sep 13, 2024
…m both side of join (apache#40485) This is brought by apache#35562 if partition mv def is as following: CREATE MATERIALIZED VIEW mv1 BUILD IMMEDIATE REFRESH COMPLETE ON MANUAL PARTITION BY (upgrade_day) DISTRIBUTED BY RANDOM BUCKETS 2 PROPERTIES ('replication_num' = '1') AS select t1.upgrade_day, t2.batch_no, count(*) from test2 t2 join test1 t1 on t1.upgrade_day = t2.upgrade_day group by t1.upgrade_day, t2.batch_no; the mv related partition table should `test1`, but now is `test2`, this pr fix this.
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Sep 14, 2024
…m both side of join (apache#40485) This is brought by apache#35562 if partition mv def is as following: CREATE MATERIALIZED VIEW mv1 BUILD IMMEDIATE REFRESH COMPLETE ON MANUAL PARTITION BY (upgrade_day) DISTRIBUTED BY RANDOM BUCKETS 2 PROPERTIES ('replication_num' = '1') AS select t1.upgrade_day, t2.batch_no, count(*) from test2 t2 join test1 t1 on t1.upgrade_day = t2.upgrade_day group by t1.upgrade_day, t2.batch_no; the mv related partition table should `test1`, but now is `test2`, this pr fix this.
gavinchou
pushed a commit
that referenced
this pull request
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is brought by #35562
if partition mv def is as following:
CREATE MATERIALIZED VIEW mv1 BUILD IMMEDIATE REFRESH COMPLETE ON MANUAL PARTITION BY (upgrade_day) DISTRIBUTED BY RANDOM BUCKETS 2 PROPERTIES ('replication_num' = '1') AS select t1.upgrade_day, t2.batch_no, count(*) from test2 t2 join test1 t1 on t1.upgrade_day = t2.upgrade_day group by t1.upgrade_day, t2.batch_no;the mv related partition table should
test1, but now istest2, this pr fix this.