[fix](routine load) write edit log when rescheduled job #40728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
sollhui
force-pushed
the
fix_rl_replay_exception
branch
from
adacb14
to
293cba7
Compare
|
run buildall |
sollhui
force-pushed
the
fix_rl_replay_exception
branch
from
293cba7
to
12398ff
Compare
|
run buildall |
TPC-H: Total hot run time: 39963 ms |
TPC-DS: Total hot run time: 193876 ms |
ClickBench: Total hot run time: 31.45 s |
sollhui
force-pushed
the
fix_rl_replay_exception
branch
from
12398ff
to
d5ee4b3
Compare
|
run buildall |
TPC-H: Total hot run time: 40176 ms |
TPC-DS: Total hot run time: 194957 ms |
ClickBench: Total hot run time: 31.15 s |
sollhui
force-pushed
the
fix_rl_replay_exception
branch
from
d5ee4b3
to
9e14b09
Compare
|
run buildall |
sollhui
force-pushed
the
fix_rl_replay_exception
branch
from
9e14b09
to
fd42d4b
Compare
|
run buildall |
TPC-H: Total hot run time: 43271 ms |
TPC-DS: Total hot run time: 196041 ms |
ClickBench: Total hot run time: 31.5 s |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
dataroaring
pushed a commit
that referenced
this pull request
Sep 23, 2024
``` 2024-09-11 20:00:53,079 ERROR (replayer|105) [RoutineLoadManager.replayChangeRoutineLoadJob():836] should not happened org.apache.doris.common.DdlException: errCode = 2, detailMessage = Could not transform PAUSED to PAUSED at org.apache.doris.load.routineload.RoutineLoadJob.checkStateTransform(RoutineLoadJob.java:855) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.load.routineload.RoutineLoadJob.unprotectUpdateState(RoutineLoadJob.java:1407) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.load.routineload.RoutineLoadJob.updateState(RoutineLoadJob.java:1394) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.load.routineload.RoutineLoadManager.replayChangeRoutineLoadJob(RoutineLoadManager.java:834) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.persist.EditLog.loadJournal(EditLog.java:717) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.Env.replayJournal(Env.java:2913) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.Env$4.runOneCycle(Env.java:2675) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.common.util.Daemon.run(Daemon.java:116) ~[doris-fe.jar:1.2-SNAPSHOT] ``` `unprotectNeedReschedule()` will change job state to `JobState.NEED_SCHEDULE` without `logOpRoutineLoadJob`.If job is paused then rescheduled and paused finally, the record of two consecutive edit logs will be 'PAUSED', the correct replay sequence should be: `PAUSED` -> `NEED_SCHEDULE` ->` PAUSED`. Therefore, it is need to write edit log when rescheduled job.
sollhui
added a commit
to sollhui/doris
that referenced
this pull request
Sep 23, 2024
``` 2024-09-11 20:00:53,079 ERROR (replayer|105) [RoutineLoadManager.replayChangeRoutineLoadJob():836] should not happened org.apache.doris.common.DdlException: errCode = 2, detailMessage = Could not transform PAUSED to PAUSED at org.apache.doris.load.routineload.RoutineLoadJob.checkStateTransform(RoutineLoadJob.java:855) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.load.routineload.RoutineLoadJob.unprotectUpdateState(RoutineLoadJob.java:1407) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.load.routineload.RoutineLoadJob.updateState(RoutineLoadJob.java:1394) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.load.routineload.RoutineLoadManager.replayChangeRoutineLoadJob(RoutineLoadManager.java:834) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.persist.EditLog.loadJournal(EditLog.java:717) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.Env.replayJournal(Env.java:2913) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.Env$4.runOneCycle(Env.java:2675) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.common.util.Daemon.run(Daemon.java:116) ~[doris-fe.jar:1.2-SNAPSHOT] ``` `unprotectNeedReschedule()` will change job state to `JobState.NEED_SCHEDULE` without `logOpRoutineLoadJob`.If job is paused then rescheduled and paused finally, the record of two consecutive edit logs will be 'PAUSED', the correct replay sequence should be: `PAUSED` -> `NEED_SCHEDULE` ->` PAUSED`. Therefore, it is need to write edit log when rescheduled job.
yiguolei
pushed a commit
that referenced
this pull request
Sep 24, 2024
) pick (#40728) ``` 2024-09-11 20:00:53,079 ERROR (replayer|105) [RoutineLoadManager.replayChangeRoutineLoadJob():836] should not happened org.apache.doris.common.DdlException: errCode = 2, detailMessage = Could not transform PAUSED to PAUSED at org.apache.doris.load.routineload.RoutineLoadJob.checkStateTransform(RoutineLoadJob.java:855) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.load.routineload.RoutineLoadJob.unprotectUpdateState(RoutineLoadJob.java:1407) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.load.routineload.RoutineLoadJob.updateState(RoutineLoadJob.java:1394) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.load.routineload.RoutineLoadManager.replayChangeRoutineLoadJob(RoutineLoadManager.java:834) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.persist.EditLog.loadJournal(EditLog.java:717) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.Env.replayJournal(Env.java:2913) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.Env$4.runOneCycle(Env.java:2675) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.common.util.Daemon.run(Daemon.java:116) ~[doris-fe.jar:1.2-SNAPSHOT] ``` `unprotectNeedReschedule()` will change job state to `JobState.NEED_SCHEDULE` without `logOpRoutineLoadJob`.If job is paused then rescheduled and paused finally, the record of two consecutive edit logs will be 'PAUSED', the correct replay sequence should be: `PAUSED` -> `NEED_SCHEDULE` ->` PAUSED`. Therefore, it is need to write edit log when rescheduled job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unprotectNeedReschedule()will change job state toJobState.NEED_SCHEDULEwithoutlogOpRoutineLoadJob.If job is paused then rescheduled and paused finally, the record of two consecutive edit logs will be 'PAUSED', the correctreplay sequence should be:
PAUSED->NEED_SCHEDULE->PAUSED.Therefore, it is need to write edit log when rescheduled job.