[improvement](nereids) Simplify ScanNode projection handling by removing redundant conditions #40801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 42806 ms |
morrySnow
reviewed
Sep 13, 2024
| @@ -2008,20 +2008,10 @@ public PlanFragment visitPhysicalProject(PhysicalProject<? extends Plan> project | |||
| // if we change the output order in translate project, the upper node will receive wrong order | |||
| // tuple, since they get the order from project.getOutput() not scan.getOutput()./ | |||
| List<SlotId> slotIdsByOrder = Lists.newArrayList(); | |||
zy-kkk
force-pushed
the
slots_order
branch
2 times, most recently
from
4803763
to
667d867
Compare
morrySnow
approved these changes
Sep 19, 2024
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
starocean999
approved these changes
Sep 19, 2024
TPC-H: Total hot run time: 41251 ms |
TPC-DS: Total hot run time: 190544 ms |
ClickBench: Total hot run time: 33.43 s |
…ing redundant conditions
|
run buildall |
TPC-H: Total hot run time: 40520 ms |
TPC-DS: Total hot run time: 191477 ms |
ClickBench: Total hot run time: 33.02 s |
|
run cloud_p0 |
morrySnow
approved these changes
Sep 24, 2024
zy-kkk
added a commit
to zy-kkk/doris
that referenced
this pull request
Sep 25, 2024
…ing redundant conditions (apache#40801) This PR simplifies the handling of `ScanNode` projection logic. Previously, the code included multiple conditional checks to determine whether a `projectionTuple` should be generated. These conditions have been removed, and now `projectionTuple `is always generated for `ScanNode`, ensuring a consistent projection setup. Additionally, redundant handling of `SlotId` and `SlotRef` has been eliminated, making the code cleaner and easier to maintain. The behavior for `OlapScanNode` remains unchanged.
morrySnow
pushed a commit
that referenced
this pull request
Sep 26, 2024
…ing redundant conditions (#40801) (#41315) pick from master #40801 This PR simplifies the handling of `ScanNode` projection logic. Previously, the code included multiple conditional checks to determine whether a `projectionTuple` should be generated. These conditions have been removed, and now `projectionTuple `is always generated for `ScanNode`, ensuring a consistent projection setup. Additionally, redundant handling of `SlotId` and `SlotRef` has been eliminated, making the code cleaner and easier to maintain. The behavior for `OlapScanNode` remains unchanged.
dataroaring
pushed a commit
that referenced
this pull request
Oct 9, 2024
…ing redundant conditions (#40801) This PR simplifies the handling of `ScanNode` projection logic. Previously, the code included multiple conditional checks to determine whether a `projectionTuple` should be generated. These conditions have been removed, and now `projectionTuple `is always generated for `ScanNode`, ensuring a consistent projection setup. Additionally, redundant handling of `SlotId` and `SlotRef` has been eliminated, making the code cleaner and easier to maintain. The behavior for `OlapScanNode` remains unchanged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the handling of
ScanNodeprojection logic. Previously, the code included multiple conditional checks to determine whether aprojectionTupleshould be generated. These conditions have been removed, and nowprojectionTupleis always generated forScanNode, ensuring a consistent projection setup. Additionally, redundant handling ofSlotIdandSlotRefhas been eliminated, making the code cleaner and easier to maintain. The behavior forOlapScanNoderemains unchanged.