Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improvement](statistics)Support cloud version set row count to -1 when not reported. #41015

Merged
merged 1 commit into from
Sep 24, 2024
Merged

[improvement](statistics)Support cloud version set row count to -1 when not reported. #41015

merged 1 commit into from
Sep 24, 2024

Conversation

Jibing-Li
Copy link
Contributor

Follow up #40457. Support cloud version.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Jibing-Li
Copy link
Contributor Author

run buildall

@Jibing-Li Jibing-Li marked this pull request as ready for review September 19, 2024 11:47
@doris-robot
Copy link

TPC-H: Total hot run time: 41441 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e098a91f0481082c9886d0a137fb9c016e426a74, data reload: false

------ Round 1 ----------------------------------
q1	17570	7312	7251	7251
q2	2030	166	161	161
q3	10641	1057	1171	1057
q4	10571	679	818	679
q5	7751	3065	3057	3057
q6	237	151	148	148
q7	1004	624	603	603
q8	9436	2044	2038	2038
q9	6796	6400	6402	6400
q10	7047	2283	2275	2275
q11	442	240	248	240
q12	408	212	217	212
q13	17777	2974	2951	2951
q14	241	210	220	210
q15	571	534	538	534
q16	695	628	609	609
q17	973	807	794	794
q18	7177	6758	6759	6758
q19	1408	1049	953	953
q20	574	286	277	277
q21	3946	3209	3315	3209
q22	1095	1025	1027	1025
Total cold run time: 108390 ms
Total hot run time: 41441 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7222	7195	7255	7195
q2	330	243	226	226
q3	2993	2945	3016	2945
q4	2035	1824	1880	1824
q5	5630	5580	5539	5539
q6	241	142	147	142
q7	2228	1837	1804	1804
q8	3269	3414	3399	3399
q9	8754	8813	8776	8776
q10	3524	3368	3496	3368
q11	594	483	479	479
q12	821	601	640	601
q13	10620	3157	3172	3157
q14	330	267	272	267
q15	581	537	513	513
q16	725	671	671	671
q17	1838	1591	1575	1575
q18	8161	7674	7682	7674
q19	1721	1533	1605	1533
q20	2142	1908	1861	1861
q21	5430	5417	5310	5310
q22	1179	1051	1044	1044
Total cold run time: 70368 ms
Total hot run time: 59903 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195462 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e098a91f0481082c9886d0a137fb9c016e426a74, data reload: false

query1	1267	872	886	872
query2	6394	2198	2142	2142
query3	10821	3852	3940	3852
query4	62792	27228	23523	23523
query5	5177	464	467	464
query6	426	168	169	168
query7	5451	308	300	300
query8	314	228	224	224
query9	8774	2637	2628	2628
query10	458	289	280	280
query11	17419	15173	15772	15173
query12	163	99	103	99
query13	1457	429	410	410
query14	10867	7257	7443	7257
query15	202	178	178	178
query16	6899	511	507	507
query17	1142	621	582	582
query18	1509	310	311	310
query19	208	158	159	158
query20	134	107	109	107
query21	212	103	105	103
query22	5094	4649	4900	4649
query23	34376	33987	33932	33932
query24	6033	2863	2874	2863
query25	517	396	402	396
query26	616	159	158	158
query27	1597	280	286	280
query28	4288	2425	2418	2418
query29	671	416	430	416
query30	232	158	156	156
query31	966	786	810	786
query32	75	51	56	51
query33	402	292	294	292
query34	885	488	483	483
query35	828	755	726	726
query36	1049	924	907	907
query37	143	84	88	84
query38	3925	3890	3907	3890
query39	1464	1410	1427	1410
query40	210	96	95	95
query41	49	47	48	47
query42	110	93	94	93
query43	538	491	479	479
query44	1112	809	787	787
query45	192	165	164	164
query46	1125	775	735	735
query47	1952	1819	1840	1819
query48	463	356	360	356
query49	680	391	400	391
query50	826	394	412	394
query51	7045	6926	6908	6908
query52	95	85	84	84
query53	249	180	174	174
query54	582	453	442	442
query55	74	80	73	73
query56	274	247	242	242
query57	1209	1119	1109	1109
query58	215	235	239	235
query59	3212	3191	3086	3086
query60	291	265	267	265
query61	102	102	104	102
query62	746	677	654	654
query63	207	181	174	174
query64	1293	643	610	610
query65	3205	3163	3156	3156
query66	648	302	304	302
query67	15795	15474	15575	15474
query68	3998	590	565	565
query69	600	408	296	296
query70	1174	1129	1099	1099
query71	513	272	277	272
query72	6601	3961	4044	3961
query73	787	335	323	323
query74	9609	8994	8900	8900
query75	3748	2641	2673	2641
query76	3175	887	918	887
query77	598	284	275	275
query78	10031	9302	9268	9268
query79	1109	544	537	537
query80	954	450	443	443
query81	513	237	239	237
query82	240	143	139	139
query83	153	132	144	132
query84	281	77	85	77
query85	907	282	275	275
query86	349	278	305	278
query87	4540	4254	4434	4254
query88	3500	2351	2357	2351
query89	387	281	279	279
query90	2148	187	183	183
query91	191	140	146	140
query92	55	46	47	46
query93	1995	537	527	527
query94	756	277	288	277
query95	328	248	252	248
query96	614	285	282	282
query97	3300	3102	3128	3102
query98	206	207	194	194
query99	1828	1290	1292	1290
Total cold run time: 312934 ms
Total hot run time: 195462 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.73 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e098a91f0481082c9886d0a137fb9c016e426a74, data reload: false

query1	0.04	0.04	0.04
query2	0.06	0.03	0.03
query3	0.22	0.06	0.06
query4	1.65	0.10	0.10
query5	0.53	0.50	0.48
query6	1.14	0.73	0.73
query7	0.02	0.02	0.01
query8	0.03	0.03	0.03
query9	0.56	0.50	0.50
query10	0.55	0.56	0.56
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.60	0.59	0.60
query14	2.90	3.00	2.94
query15	0.91	0.83	0.82
query16	0.41	0.40	0.41
query17	1.07	1.03	1.03
query18	0.20	0.19	0.20
query19	1.88	1.86	2.04
query20	0.02	0.01	0.01
query21	15.38	0.58	0.61
query22	2.56	3.10	1.66
query23	17.36	0.80	0.85
query24	3.15	1.83	0.19
query25	0.28	0.06	0.09
query26	0.47	0.14	0.13
query27	0.04	0.04	0.04
query28	10.80	1.09	1.07
query29	12.58	3.20	3.23
query30	0.24	0.05	0.06
query31	2.88	0.38	0.38
query32	3.28	0.45	0.45
query33	3.00	2.99	3.03
query34	16.73	4.36	4.43
query35	4.42	4.41	4.43
query36	0.66	0.51	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 107.37 s
Total hot run time: 31.73 s

@Jibing-Li
Copy link
Contributor Author

run p0

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

zfr9527
zfr9527 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@zfr9527 zfr9527 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jibing-Li Jibing-Li merged commit 0b92e5a into apache:master Sep 24, 2024
26 of 29 checks passed
@Jibing-Li Jibing-Li deleted the cloudrow branch September 24, 2024 07:37
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Oct 16, 2024
@Jibing-Li
[improvement](statistics)Support cloud version set row count to -1 wh…
c22625a 
…en not reported. (apache#41015)

Follow up apache#40457. Support cloud
version.
@Jibing-Li Jibing-Li mentioned this pull request Oct 16, 2024
Merged
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Oct 16, 2024
@Jibing-Li
[improvement](statistics)Support cloud version set row count to -1 wh…
e20d5ad 
…en not reported. (apache#41015)

Follow up apache#40457. Support cloud
version.
Jibing-Li added a commit that referenced this pull request Oct 16, 2024
@Jibing-Li
[improvement](statistics)Support cloud version set row count to -1 wh…
d1d2a78 
…en not reported. (#41015) (#41924)

backport: #41015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zfr9527 zfr9527 zfr9527 approved these changes

@englefly englefly englefly approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.3-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Jibing-Li @doris-robot @englefly @zfr9527 @morrySnow