Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch-2.1] Picks "[opt](autoinc) Remove some restrictions on schema change on table that has auto-increment column #40280" #41096

Merged
merged 6 commits into from
Sep 23, 2024

Conversation

bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Sep 22, 2024

picks #40280

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@bobhan1
Copy link
Contributor Author

bobhan1 commented Sep 22, 2024

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.15% (9332/25813)
Line Coverage: 27.70% (76641/276671)
Region Coverage: 26.49% (39385/148654)
Branch Coverage: 23.29% (20050/86102)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5806620de9737f5a5ad27fad923fb992680aa539_5806620de9737f5a5ad27fad923fb992680aa539/report/index.html

@yiguolei yiguolei merged commit 7d64c8c into apache:branch-2.1 Sep 23, 2024
20 of 22 checks passed
dataroaring pushed a commit that referenced this pull request Sep 24, 2024
…t has auto-increment column (#40280)

## Proposed changes

- #37186 forbids some schema change on table with auto-increment column,
one of which is to forbid schema change that involves double write on
tables which has auto-increment column. However, the process of
generating auto-increment column values is before the distributing data
to indexes. So this restriction can be removed.

branch-2.1-pick: #41096
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
…t has auto-increment column (#40280)

## Proposed changes

- #37186 forbids some schema change on table with auto-increment column,
one of which is to forbid schema change that involves double write on
tables which has auto-increment column. However, the process of
generating auto-increment column values is before the distributing data
to indexes. So this restriction can be removed.

branch-2.1-pick: #41096
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants